| Message ID | 42bf6244582d6208f51db1a9299fe1c8afab4e14.1683630932.git.quic_varada@quicinc.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Enable IPQ9754 USB | expand |
On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > Add LDO regulator node > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v10: > - Add LDO regulator node > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Minor question below: > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index bdc1434..1f5d14f 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -60,6 +60,13 @@ > regulator-min-microvolt = <725000>; > regulator-max-microvolt = <1075000>; > }; > + > + mp5496_l2: l2 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; This usually points out that there are other users which are not yet enabled/properly specified. What users are there for this supply which demand it to be always on? > + }; > }; > }; > > -- > 2.7.4 >
On Tue, May 09, 2023 at 04:08:59PM +0300, Dmitry Baryshkov wrote: > On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > Add LDO regulator node > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v10: > > - Add LDO regulator node > > --- > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Minor question below: > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > index bdc1434..1f5d14f 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > @@ -60,6 +60,13 @@ > > regulator-min-microvolt = <725000>; > > regulator-max-microvolt = <1075000>; > > }; > > + > > + mp5496_l2: l2 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > This usually points out that there are other users which are not yet > enabled/properly specified. What users are there for this supply which > demand it to be always on? The 1.8v rail is used by PCIe PHY, PLL for Ethernet SerDes interface and PLLs that generate SoC clocks. The voting for this rail is managed by the RPM f/w. Thanks Varada > > + }; > > }; > > }; > > > > -- > > 2.7.4 > > > > > -- > With best wishes > Dmitry
On Wed, 10 May 2023 at 13:23, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > On Tue, May 09, 2023 at 04:08:59PM +0300, Dmitry Baryshkov wrote: > > On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > > > > > > Add LDO regulator node > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > Changes in v10: > > > - Add LDO regulator node > > > --- > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Minor question below: > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > index bdc1434..1f5d14f 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > @@ -60,6 +60,13 @@ > > > regulator-min-microvolt = <725000>; > > > regulator-max-microvolt = <1075000>; > > > }; > > > + > > > + mp5496_l2: l2 { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > > This usually points out that there are other users which are not yet > > enabled/properly specified. What users are there for this supply which > > demand it to be always on? > > The 1.8v rail is used by PCIe PHY, PLL for Ethernet SerDes > interface and PLLs that generate SoC clocks. The voting for this > rail is managed by the RPM f/w. Then I'm looking forward to seeing the patch which declares all the actual users of the lane. Please do not declare power lanes as boot-on/always-on unless there is a strong reason for doing it. > > Thanks > Varada > > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4 > > > > > > > > > -- > > With best wishes > > Dmitry
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts index bdc1434..1f5d14f 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts @@ -60,6 +60,13 @@ regulator-min-microvolt = <725000>; regulator-max-microvolt = <1075000>; }; + + mp5496_l2: l2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; }; };
Add LDO regulator node Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- Changes in v10: - Add LDO regulator node --- arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ 1 file changed, 7 insertions(+)