| Message ID | 1683718725-14869-1-git-send-email-quic_rohiagar@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add pinctrl support for SDX75 | expand |
On 5/10/2023 5:08 PM, Rohit Agarwal wrote: > Hi, > > Changes in v6: > - Refactoring as per suggestions from Andy to remove msm_function and > reusing the pinfunction and pingroup struct with macros as well. Patch 2/4 didnt go through in the mailing list linux-arm-msm because of char length. BOUNCE linux-arm-msm@vger.kernel.org: Message too long (>100000 chars) Here is the link for it. https://lore.kernel.org/all/1683718725-14869-3-git-send-email-quic_rohiagar@quicinc.com/ Please suggest if this patch needs to be broken down. Thanks, Rohit. > Changes in v5: > - Refactor the pinctrl target files based on the new macro and > structure defined as suggested by Andy. > > Changes in v4: > - Fixed the bindings check and rebased on linux-next. > > Changes in v3: > - Rebased the bindings on linux-next as suggested by Krzysztof. > > Changes in v2: > - Updated the bindings to clear the bindings check. > > This patch series adds pinctrl bindings and tlmm support for SDX75. > > Thanks, > Rohit. > > Rohit Agarwal (4): > dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible > pinctrl: qcom: Remove the msm_function struct > pinctrl: qcom: Refactor generic qcom pinctrl driver > pinctrl: qcom: Add SDX75 pincontrol driver > > .../bindings/pinctrl/qcom,sdx75-tlmm.yaml | 169 +++ > drivers/pinctrl/qcom/Kconfig | 30 +- > drivers/pinctrl/qcom/Makefile | 3 +- > drivers/pinctrl/qcom/pinctrl-apq8064.c | 104 +- > drivers/pinctrl/qcom/pinctrl-apq8084.c | 264 ++-- > drivers/pinctrl/qcom/pinctrl-ipq4019.c | 104 +- > drivers/pinctrl/qcom/pinctrl-ipq5332.c | 206 ++- > drivers/pinctrl/qcom/pinctrl-ipq6018.c | 260 ++-- > drivers/pinctrl/qcom/pinctrl-ipq8064.c | 114 +- > drivers/pinctrl/qcom/pinctrl-ipq8074.c | 240 ++- > drivers/pinctrl/qcom/pinctrl-mdm9607.c | 276 ++-- > drivers/pinctrl/qcom/pinctrl-mdm9615.c | 90 +- > drivers/pinctrl/qcom/pinctrl-msm.c | 13 +- > drivers/pinctrl/qcom/pinctrl-msm.h | 42 +- > drivers/pinctrl/qcom/pinctrl-msm8226.c | 156 +- > drivers/pinctrl/qcom/pinctrl-msm8660.c | 252 ++- > drivers/pinctrl/qcom/pinctrl-msm8909.c | 268 ++-- > drivers/pinctrl/qcom/pinctrl-msm8916.c | 556 ++++--- > drivers/pinctrl/qcom/pinctrl-msm8953.c | 424 +++--- > drivers/pinctrl/qcom/pinctrl-msm8960.c | 464 +++--- > drivers/pinctrl/qcom/pinctrl-msm8976.c | 212 ++- > drivers/pinctrl/qcom/pinctrl-msm8994.c | 564 ++++--- > drivers/pinctrl/qcom/pinctrl-msm8996.c | 508 +++---- > drivers/pinctrl/qcom/pinctrl-msm8998.c | 380 +++-- > drivers/pinctrl/qcom/pinctrl-msm8x74.c | 474 +++--- > drivers/pinctrl/qcom/pinctrl-qcm2290.c | 230 ++- > drivers/pinctrl/qcom/pinctrl-qcs404.c | 388 +++-- > drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 6 +- > drivers/pinctrl/qcom/pinctrl-qdu1000.c | 249 ++- > drivers/pinctrl/qcom/pinctrl-sa8775p.c | 308 ++-- > drivers/pinctrl/qcom/pinctrl-sc7180.c | 254 ++-- > drivers/pinctrl/qcom/pinctrl-sc7280.c | 322 ++-- > drivers/pinctrl/qcom/pinctrl-sc8180x.c | 286 ++-- > drivers/pinctrl/qcom/pinctrl-sc8280xp.c | 358 +++-- > drivers/pinctrl/qcom/pinctrl-sdm660.c | 387 +++-- > drivers/pinctrl/qcom/pinctrl-sdm670.c | 284 ++-- > drivers/pinctrl/qcom/pinctrl-sdm845.c | 286 ++-- > drivers/pinctrl/qcom/pinctrl-sdx55.c | 190 ++- > drivers/pinctrl/qcom/pinctrl-sdx65.c | 194 ++- > drivers/pinctrl/qcom/pinctrl-sdx75.c | 1601 ++++++++++++++++++++ > drivers/pinctrl/qcom/pinctrl-sm6115.c | 162 +- > drivers/pinctrl/qcom/pinctrl-sm6125.c | 282 ++-- > drivers/pinctrl/qcom/pinctrl-sm6350.c | 296 ++-- > drivers/pinctrl/qcom/pinctrl-sm6375.c | 358 +++-- > drivers/pinctrl/qcom/pinctrl-sm8150.c | 286 ++-- > drivers/pinctrl/qcom/pinctrl-sm8250.c | 258 ++-- > drivers/pinctrl/qcom/pinctrl-sm8350.c | 298 ++-- > drivers/pinctrl/qcom/pinctrl-sm8450.c | 300 ++-- > drivers/pinctrl/qcom/pinctrl-sm8550.c | 320 ++-- > 49 files changed, 7763 insertions(+), 6313 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdx75-tlmm.yaml > create mode 100644 drivers/pinctrl/qcom/pinctrl-sdx75.c >
On Wed, May 10, 2023 at 3:16 PM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote: > On 5/10/2023 5:08 PM, Rohit Agarwal wrote: > Patch 2/4 didnt go through in the mailing list linux-arm-msm because of > char length. > BOUNCE linux-arm-msm@vger.kernel.org: Message too long (>100000 chars) > > Here is the link for it. > https://lore.kernel.org/all/1683718725-14869-3-git-send-email-quic_rohiagar@quicinc.com/ > Please suggest if this patch needs to be broken down. Since lore.kernel.org has it, I think nothing additional needs to be done. `b4` tool will take it from the archive.
On 10/05/2023 16:02, Andy Shevchenko wrote: > On Wed, May 10, 2023 at 3:16 PM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote: >> On 5/10/2023 5:08 PM, Rohit Agarwal wrote: > >> Patch 2/4 didnt go through in the mailing list linux-arm-msm because of >> char length. >> BOUNCE linux-arm-msm@vger.kernel.org: Message too long (>100000 chars) >> >> Here is the link for it. >> https://lore.kernel.org/all/1683718725-14869-3-git-send-email-quic_rohiagar@quicinc.com/ >> Please suggest if this patch needs to be broken down. > > Since lore.kernel.org has it, I think nothing additional needs to be done. > `b4` tool will take it from the archive. Patchwork does not take from b4, but msm list, so this won't be applied by Bjorn. I would suggest either pinging him to notice it or splitting the patch a bit. Best regards, Krzysztof
Wed, May 10, 2023 at 05:08:43PM +0530, Rohit Agarwal kirjoitti: > Remove the msm_function struct to reuse the generic pinfunction > struct. Also, define a generic PINFUNCTION macro that can be used across > qcom target specific pinctrl files to avoid code repetition. With ~330 LoCs removed! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Thank you! > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
On Wed, May 10, 2023 at 5:06 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 10/05/2023 16:02, Andy Shevchenko wrote: > > On Wed, May 10, 2023 at 3:16 PM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote: > >> On 5/10/2023 5:08 PM, Rohit Agarwal wrote: > > > >> Patch 2/4 didnt go through in the mailing list linux-arm-msm because of > >> char length. > >> BOUNCE linux-arm-msm@vger.kernel.org: Message too long (>100000 chars) > >> > >> Here is the link for it. > >> https://lore.kernel.org/all/1683718725-14869-3-git-send-email-quic_rohiagar@quicinc.com/ > >> Please suggest if this patch needs to be broken down. > > > > Since lore.kernel.org has it, I think nothing additional needs to be done. > > `b4` tool will take it from the archive. > > Patchwork does not take from b4, but msm list, so this won't be applied > by Bjorn. I would suggest either pinging him to notice it or splitting > the patch a bit. Oh, this is unfortunate. Thank you for the information.