| Message ID | 20230510195806.2902878-1-nphamcs@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cachestat: wire up cachestat for other architectures | expand |
Nhat Pham <nphamcs@gmail.com> writes: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > This patch wires cachestat in for all the other architectures. > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > --- > arch/alpha/kernel/syscalls/syscall.tbl | 1 + > arch/arm/tools/syscall.tbl | 1 + > arch/ia64/kernel/syscalls/syscall.tbl | 1 + > arch/m68k/kernel/syscalls/syscall.tbl | 1 + > arch/microblaze/kernel/syscalls/syscall.tbl | 1 + > arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + > arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + > arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + > arch/parisc/kernel/syscalls/syscall.tbl | 1 + > arch/powerpc/kernel/syscalls/syscall.tbl | 1 + With the change to the selftest (see my other mail), I tested this on powerpc and all tests pass. Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers
Hi Nat, On Wed, May 10, 2023 at 9:58 PM Nhat Pham <nphamcs@gmail.com> wrote: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > This patch wires cachestat in for all the other architectures. > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > --- > arch/alpha/kernel/syscalls/syscall.tbl | 1 + > arch/arm/tools/syscall.tbl | 1 + Looking at the last addition of a syscall (commit 21b084fdf2a49ca1 ("mm/mempolicy: wire up syscall set_mempolicy_home_node"), it looks like you forgot to update arm64 in compat mode? Or is that not needed? > arch/ia64/kernel/syscalls/syscall.tbl | 1 + > arch/m68k/kernel/syscalls/syscall.tbl | 1 + For m68k: Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > arch/microblaze/kernel/syscalls/syscall.tbl | 1 + > arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + > arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + > arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + > arch/parisc/kernel/syscalls/syscall.tbl | 1 + > arch/powerpc/kernel/syscalls/syscall.tbl | 1 + > arch/s390/kernel/syscalls/syscall.tbl | 1 + > arch/sh/kernel/syscalls/syscall.tbl | 1 + > arch/sparc/kernel/syscalls/syscall.tbl | 1 + > arch/xtensa/kernel/syscalls/syscall.tbl | 1 + > 14 files changed, 14 insertions(+) Gr{oetje,eeting}s, Geert
On Wed, May 10, 2023, at 21:58, Nhat Pham wrote: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > This patch wires cachestat in for all the other architectures. > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> The changes you did here look good, but you missed one file that has never been converted to the syscall.tbl format: arch/arm64/include/asm/unistd32.h along with the __NR_compat_syscalls definition in arch/arm64/include/asm/unistd.h, please add those as well, and then Reviewed-by: Arnd Bergmann <arnd@arndb.de>
On Wed, May 10, 2023 at 12:58:06PM -0700, Nhat Pham wrote: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > This patch wires cachestat in for all the other architectures. > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > --- ... > arch/s390/kernel/syscalls/syscall.tbl | 1 + Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
On Thu, May 11, 2023 at 12:01 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Nat, > > On Wed, May 10, 2023 at 9:58 PM Nhat Pham <nphamcs@gmail.com> wrote: > > cachestat is previously only wired in for x86 (and architectures using > > the generic unistd.h table): > > > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > > > This patch wires cachestat in for all the other architectures. > > > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > > --- > > arch/alpha/kernel/syscalls/syscall.tbl | 1 + > > arch/arm/tools/syscall.tbl | 1 + > > Looking at the last addition of a syscall (commit 21b084fdf2a49ca1 > ("mm/mempolicy: wire up syscall set_mempolicy_home_node"), it looks > like you forgot to update arm64 in compat mode? Or is that not needed? It does look like I missed that! Thanks for the reminder. I'll send a fixlet shortly... Best, Nhat > > > arch/ia64/kernel/syscalls/syscall.tbl | 1 + > > arch/m68k/kernel/syscalls/syscall.tbl | 1 + > > For m68k: > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > arch/microblaze/kernel/syscalls/syscall.tbl | 1 + > > arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + > > arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + > > arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + > > arch/parisc/kernel/syscalls/syscall.tbl | 1 + > > arch/powerpc/kernel/syscalls/syscall.tbl | 1 + > > arch/s390/kernel/syscalls/syscall.tbl | 1 + > > arch/sh/kernel/syscalls/syscall.tbl | 1 + > > arch/sparc/kernel/syscalls/syscall.tbl | 1 + > > arch/xtensa/kernel/syscalls/syscall.tbl | 1 + > > 14 files changed, 14 insertions(+) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
On Thu, May 11, 2023 at 12:05 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On Wed, May 10, 2023, at 21:58, Nhat Pham wrote: > > cachestat is previously only wired in for x86 (and architectures using > > the generic unistd.h table): > > > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > > > This patch wires cachestat in for all the other architectures. > > > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > > The changes you did here look good, but you missed one > file that has never been converted to the syscall.tbl format: > arch/arm64/include/asm/unistd32.h along with the __NR_compat_syscalls > definition in arch/arm64/include/asm/unistd.h, please add those > as well, and then > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> Just sent a follow-up fixlet for this: https://lore.kernel.org/linux-mm/20230511092843.3896327-1-nphamcs@gmail.com/T/#u Thanks for the suggestion!
On Wed, May 10, 2023 at 8:23 PM Michael Ellerman <mpe@ellerman.id.au> wrote: > > Nhat Pham <nphamcs@gmail.com> writes: > > cachestat is previously only wired in for x86 (and architectures using > > the generic unistd.h table): > > > > https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ > > > > This patch wires cachestat in for all the other architectures. > > > > Signed-off-by: Nhat Pham <nphamcs@gmail.com> > > --- > > arch/alpha/kernel/syscalls/syscall.tbl | 1 + > > arch/arm/tools/syscall.tbl | 1 + > > arch/ia64/kernel/syscalls/syscall.tbl | 1 + > > arch/m68k/kernel/syscalls/syscall.tbl | 1 + > > arch/microblaze/kernel/syscalls/syscall.tbl | 1 + > > arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + > > arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + > > arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + > > arch/parisc/kernel/syscalls/syscall.tbl | 1 + > > arch/powerpc/kernel/syscalls/syscall.tbl | 1 + > > With the change to the selftest (see my other mail), I tested this on > powerpc and all tests pass. Saw the change you proposed, Michael! It looks good to me. Thanks for helping me make the selftest suite more robust :) > > Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) > > > cheers
diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl index 8ebacf37a8cf..1f13995d00d7 100644 --- a/arch/alpha/kernel/syscalls/syscall.tbl +++ b/arch/alpha/kernel/syscalls/syscall.tbl @@ -490,3 +490,4 @@ 558 common process_mrelease sys_process_mrelease 559 common futex_waitv sys_futex_waitv 560 common set_mempolicy_home_node sys_ni_syscall +561 common cachestat sys_cachestat diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl index ac964612d8b0..8ebed8a13874 100644 --- a/arch/arm/tools/syscall.tbl +++ b/arch/arm/tools/syscall.tbl @@ -464,3 +464,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/ia64/kernel/syscalls/syscall.tbl b/arch/ia64/kernel/syscalls/syscall.tbl index 72c929d9902b..f8c74ffeeefb 100644 --- a/arch/ia64/kernel/syscalls/syscall.tbl +++ b/arch/ia64/kernel/syscalls/syscall.tbl @@ -371,3 +371,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/m68k/kernel/syscalls/syscall.tbl b/arch/m68k/kernel/syscalls/syscall.tbl index b1f3940bc298..4f504783371f 100644 --- a/arch/m68k/kernel/syscalls/syscall.tbl +++ b/arch/m68k/kernel/syscalls/syscall.tbl @@ -450,3 +450,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/microblaze/kernel/syscalls/syscall.tbl b/arch/microblaze/kernel/syscalls/syscall.tbl index 820145e47350..858d22bf275c 100644 --- a/arch/microblaze/kernel/syscalls/syscall.tbl +++ b/arch/microblaze/kernel/syscalls/syscall.tbl @@ -456,3 +456,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/mips/kernel/syscalls/syscall_n32.tbl b/arch/mips/kernel/syscalls/syscall_n32.tbl index 253ff994ed2e..1976317d4e8b 100644 --- a/arch/mips/kernel/syscalls/syscall_n32.tbl +++ b/arch/mips/kernel/syscalls/syscall_n32.tbl @@ -389,3 +389,4 @@ 448 n32 process_mrelease sys_process_mrelease 449 n32 futex_waitv sys_futex_waitv 450 n32 set_mempolicy_home_node sys_set_mempolicy_home_node +451 n32 cachestat sys_cachestat diff --git a/arch/mips/kernel/syscalls/syscall_n64.tbl b/arch/mips/kernel/syscalls/syscall_n64.tbl index 3f1886ad9d80..cfda2511badf 100644 --- a/arch/mips/kernel/syscalls/syscall_n64.tbl +++ b/arch/mips/kernel/syscalls/syscall_n64.tbl @@ -365,3 +365,4 @@ 448 n64 process_mrelease sys_process_mrelease 449 n64 futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 n64 cachestat sys_cachestat diff --git a/arch/mips/kernel/syscalls/syscall_o32.tbl b/arch/mips/kernel/syscalls/syscall_o32.tbl index 8f243e35a7b2..7692234c3768 100644 --- a/arch/mips/kernel/syscalls/syscall_o32.tbl +++ b/arch/mips/kernel/syscalls/syscall_o32.tbl @@ -438,3 +438,4 @@ 448 o32 process_mrelease sys_process_mrelease 449 o32 futex_waitv sys_futex_waitv 450 o32 set_mempolicy_home_node sys_set_mempolicy_home_node +451 o32 cachestat sys_cachestat diff --git a/arch/parisc/kernel/syscalls/syscall.tbl b/arch/parisc/kernel/syscalls/syscall.tbl index 0e42fceb2d5e..3c71fad78318 100644 --- a/arch/parisc/kernel/syscalls/syscall.tbl +++ b/arch/parisc/kernel/syscalls/syscall.tbl @@ -448,3 +448,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl index a0be127475b1..8c0b08b7a80e 100644 --- a/arch/powerpc/kernel/syscalls/syscall.tbl +++ b/arch/powerpc/kernel/syscalls/syscall.tbl @@ -537,3 +537,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 nospu set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/s390/kernel/syscalls/syscall.tbl b/arch/s390/kernel/syscalls/syscall.tbl index 799147658dee..7df0329d46cb 100644 --- a/arch/s390/kernel/syscalls/syscall.tbl +++ b/arch/s390/kernel/syscalls/syscall.tbl @@ -453,3 +453,4 @@ 448 common process_mrelease sys_process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat sys_cachestat diff --git a/arch/sh/kernel/syscalls/syscall.tbl b/arch/sh/kernel/syscalls/syscall.tbl index 2de85c977f54..97377e8c5025 100644 --- a/arch/sh/kernel/syscalls/syscall.tbl +++ b/arch/sh/kernel/syscalls/syscall.tbl @@ -453,3 +453,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/sparc/kernel/syscalls/syscall.tbl b/arch/sparc/kernel/syscalls/syscall.tbl index 4398cc6fb68d..faa835f3c54a 100644 --- a/arch/sparc/kernel/syscalls/syscall.tbl +++ b/arch/sparc/kernel/syscalls/syscall.tbl @@ -496,3 +496,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat diff --git a/arch/xtensa/kernel/syscalls/syscall.tbl b/arch/xtensa/kernel/syscalls/syscall.tbl index 52c94ab5c205..2b69c3c035b6 100644 --- a/arch/xtensa/kernel/syscalls/syscall.tbl +++ b/arch/xtensa/kernel/syscalls/syscall.tbl @@ -421,3 +421,4 @@ 448 common process_mrelease sys_process_mrelease 449 common futex_waitv sys_futex_waitv 450 common set_mempolicy_home_node sys_set_mempolicy_home_node +451 common cachestat sys_cachestat
cachestat is previously only wired in for x86 (and architectures using the generic unistd.h table): https://lore.kernel.org/lkml/20230503013608.2431726-1-nphamcs@gmail.com/ This patch wires cachestat in for all the other architectures. Signed-off-by: Nhat Pham <nphamcs@gmail.com> --- arch/alpha/kernel/syscalls/syscall.tbl | 1 + arch/arm/tools/syscall.tbl | 1 + arch/ia64/kernel/syscalls/syscall.tbl | 1 + arch/m68k/kernel/syscalls/syscall.tbl | 1 + arch/microblaze/kernel/syscalls/syscall.tbl | 1 + arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + arch/parisc/kernel/syscalls/syscall.tbl | 1 + arch/powerpc/kernel/syscalls/syscall.tbl | 1 + arch/s390/kernel/syscalls/syscall.tbl | 1 + arch/sh/kernel/syscalls/syscall.tbl | 1 + arch/sparc/kernel/syscalls/syscall.tbl | 1 + arch/xtensa/kernel/syscalls/syscall.tbl | 1 + 14 files changed, 14 insertions(+)