| Message ID | 20230511135503.198538-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | arm64: defconfig: enable TYPEC_QCOM_PMIC | expand |
On 11/05/2023 15:55, Krzysztof Kozlowski wrote: > Enable CONFIG_TYPEC_QCOM_PMIC necessary for full USB Type-C support on > Qualcomm QRD8550 and MT8550 boards. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index a24609e14d50..8b6407d2059d 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -991,6 +991,7 @@ CONFIG_TYPEC_TCPCI=m > CONFIG_TYPEC_FUSB302=m > CONFIG_TYPEC_TPS6598X=m > CONFIG_TYPEC_HD3SS3220=m > +CONFIG_TYPEC_QCOM_PMIC=m > CONFIG_TYPEC_UCSI=m > CONFIG_UCSI_CCG=m > CONFIG_TYPEC_MUX_GPIO_SBU=m This driver isn't used on SM8550, only CONFIG_TYPEC_UCSI is needed. Neil
On 11/05/2023 16:14, Neil Armstrong wrote: > On 11/05/2023 15:55, Krzysztof Kozlowski wrote: >> Enable CONFIG_TYPEC_QCOM_PMIC necessary for full USB Type-C support on >> Qualcomm QRD8550 and MT8550 boards. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/configs/defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index a24609e14d50..8b6407d2059d 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -991,6 +991,7 @@ CONFIG_TYPEC_TCPCI=m >> CONFIG_TYPEC_FUSB302=m >> CONFIG_TYPEC_TPS6598X=m >> CONFIG_TYPEC_HD3SS3220=m >> +CONFIG_TYPEC_QCOM_PMIC=m >> CONFIG_TYPEC_UCSI=m >> CONFIG_UCSI_CCG=m >> CONFIG_TYPEC_MUX_GPIO_SBU=m > > This driver isn't used on SM8550, only CONFIG_TYPEC_UCSI is needed. Indeed, apparently I messed something with config while looking for other options. Patch can be skipped, the driver has no users in upstream (and bindings are still missing :( ). Best regards, Krzysztof
On Thu, 11 May 2023 at 17:36, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 11/05/2023 16:14, Neil Armstrong wrote: > > On 11/05/2023 15:55, Krzysztof Kozlowski wrote: > >> Enable CONFIG_TYPEC_QCOM_PMIC necessary for full USB Type-C support on > >> Qualcomm QRD8550 and MT8550 boards. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> arch/arm64/configs/defconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > >> index a24609e14d50..8b6407d2059d 100644 > >> --- a/arch/arm64/configs/defconfig > >> +++ b/arch/arm64/configs/defconfig > >> @@ -991,6 +991,7 @@ CONFIG_TYPEC_TCPCI=m > >> CONFIG_TYPEC_FUSB302=m > >> CONFIG_TYPEC_TPS6598X=m > >> CONFIG_TYPEC_HD3SS3220=m > >> +CONFIG_TYPEC_QCOM_PMIC=m > >> CONFIG_TYPEC_UCSI=m > >> CONFIG_UCSI_CCG=m > >> CONFIG_TYPEC_MUX_GPIO_SBU=m > > > > This driver isn't used on SM8550, only CONFIG_TYPEC_UCSI is needed. > > Indeed, apparently I messed something with config while looking for > other options. Patch can be skipped, the driver has no users in upstream > (and bindings are still missing :( ). ... And it will be hopefully removed by landing Bryan's patches.
On 11/05/2023 15:52, Dmitry Baryshkov wrote: > On Thu, 11 May 2023 at 17:36, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 11/05/2023 16:14, Neil Armstrong wrote: >>> On 11/05/2023 15:55, Krzysztof Kozlowski wrote: >>>> Enable CONFIG_TYPEC_QCOM_PMIC necessary for full USB Type-C support on >>>> Qualcomm QRD8550 and MT8550 boards. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> arch/arm64/configs/defconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>> index a24609e14d50..8b6407d2059d 100644 >>>> --- a/arch/arm64/configs/defconfig >>>> +++ b/arch/arm64/configs/defconfig >>>> @@ -991,6 +991,7 @@ CONFIG_TYPEC_TCPCI=m >>>> CONFIG_TYPEC_FUSB302=m >>>> CONFIG_TYPEC_TPS6598X=m >>>> CONFIG_TYPEC_HD3SS3220=m >>>> +CONFIG_TYPEC_QCOM_PMIC=m >>>> CONFIG_TYPEC_UCSI=m >>>> CONFIG_UCSI_CCG=m >>>> CONFIG_TYPEC_MUX_GPIO_SBU=m >>> >>> This driver isn't used on SM8550, only CONFIG_TYPEC_UCSI is needed. >> >> Indeed, apparently I messed something with config while looking for >> other options. Patch can be skipped, the driver has no users in upstream >> (and bindings are still missing :( ). > > ... And it will be hopefully removed by landing Bryan's patches. > I actually reuse this CONFIG option so I can stack this commit last in the series - it will just switch on the new driver instead. --- bod
On Thu, May 11, 2023 at 05:26:20PM +0100, Bryan O'Donoghue wrote: > On 11/05/2023 15:52, Dmitry Baryshkov wrote: > > On Thu, 11 May 2023 at 17:36, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > > > > On 11/05/2023 16:14, Neil Armstrong wrote: > > > > On 11/05/2023 15:55, Krzysztof Kozlowski wrote: > > > > > Enable CONFIG_TYPEC_QCOM_PMIC necessary for full USB Type-C support on > > > > > Qualcomm QRD8550 and MT8550 boards. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > --- > > > > > arch/arm64/configs/defconfig | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > > > index a24609e14d50..8b6407d2059d 100644 > > > > > --- a/arch/arm64/configs/defconfig > > > > > +++ b/arch/arm64/configs/defconfig > > > > > @@ -991,6 +991,7 @@ CONFIG_TYPEC_TCPCI=m > > > > > CONFIG_TYPEC_FUSB302=m > > > > > CONFIG_TYPEC_TPS6598X=m > > > > > CONFIG_TYPEC_HD3SS3220=m > > > > > +CONFIG_TYPEC_QCOM_PMIC=m > > > > > CONFIG_TYPEC_UCSI=m > > > > > CONFIG_UCSI_CCG=m > > > > > CONFIG_TYPEC_MUX_GPIO_SBU=m > > > > > > > > This driver isn't used on SM8550, only CONFIG_TYPEC_UCSI is needed. > > > > > > Indeed, apparently I messed something with config while looking for > > > other options. Patch can be skipped, the driver has no users in upstream > > > (and bindings are still missing :( ). > > > > ... And it will be hopefully removed by landing Bryan's patches. > > > > I actually reuse this CONFIG option so I can stack this commit last in the > series - it will just switch on the new driver instead. > Please do so, I will ignore this change for now. Thanks, Bjorn
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a24609e14d50..8b6407d2059d 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -991,6 +991,7 @@ CONFIG_TYPEC_TCPCI=m CONFIG_TYPEC_FUSB302=m CONFIG_TYPEC_TPS6598X=m CONFIG_TYPEC_HD3SS3220=m +CONFIG_TYPEC_QCOM_PMIC=m CONFIG_TYPEC_UCSI=m CONFIG_UCSI_CCG=m CONFIG_TYPEC_MUX_GPIO_SBU=m
Enable CONFIG_TYPEC_QCOM_PMIC necessary for full USB Type-C support on Qualcomm QRD8550 and MT8550 boards. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)