| Message ID | 20230511130218.22606-2-michal.orzel@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/arm: domain_build: map_{dt_}irq_to_domain() fixes | expand |
On 11/05/2023 14:02, Michal Orzel wrote: > From map_dt_irq_to_domain() we are assigning a return code of > map_irq_to_domain() to a variable without checking it for an error. > Fix it by propagating the return code directly since this is the last > call. > > Fixes: 467e5cbb2ffc ("xen: arm: consolidate mmio and irq mapping to dom0") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Reviewed-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com> > --- > Changes in v2: > - split the patch so that a fix alone can be backported > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index f80fdd1af206..9dee1bb8f21c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2320,7 +2320,7 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, > > res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev)); > > - return 0; > + return res; > } > > int __init map_range_to_domain(const struct dt_device_node *dev,
Hi Michal, > -----Original Message----- > Subject: [PATCH v2 1/2] xen/arm: domain_build: Propagate return code of > map_irq_to_domain() > > From map_dt_irq_to_domain() we are assigning a return code of > map_irq_to_domain() to a variable without checking it for an error. > Fix it by propagating the return code directly since this is the last > call. > > Fixes: 467e5cbb2ffc ("xen: arm: consolidate mmio and irq mapping to dom0") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Reviewed-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry
Hi Michal, On 11/05/2023 14:02, Michal Orzel wrote: > From map_dt_irq_to_domain() we are assigning a return code of > map_irq_to_domain() to a variable without checking it for an error. > Fix it by propagating the return code directly since this is the last > call. > > Fixes: 467e5cbb2ffc ("xen: arm: consolidate mmio and irq mapping to dom0") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Reviewed-by: Julien Grall <jgrall@amazon.com> Cheers, > --- > Changes in v2: > - split the patch so that a fix alone can be backported > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index f80fdd1af206..9dee1bb8f21c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2320,7 +2320,7 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, > > res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev)); > > - return 0; > + return res; > } > > int __init map_range_to_domain(const struct dt_device_node *dev,
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f80fdd1af206..9dee1bb8f21c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2320,7 +2320,7 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev)); - return 0; + return res; } int __init map_range_to_domain(const struct dt_device_node *dev,
From map_dt_irq_to_domain() we are assigning a return code of map_irq_to_domain() to a variable without checking it for an error. Fix it by propagating the return code directly since this is the last call. Fixes: 467e5cbb2ffc ("xen: arm: consolidate mmio and irq mapping to dom0") Signed-off-by: Michal Orzel <michal.orzel@amd.com> --- Changes in v2: - split the patch so that a fix alone can be backported --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)