| Message ID | ZERQiub7tuTxHCUy@p100 (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | fbdev: modedb: Add a 1920x1080 at 60 Hz video mode | expand |
Hi Helge, On Sat, Apr 22, 2023 at 11:27 PM Helge Deller <deller@gmx.de> wrote: > Add typical resolution for Full-HD monitors. > > Signed-off-by: Helge Deller <deller@gmx.de> > --- a/drivers/video/fbdev/core/modedb.c > +++ b/drivers/video/fbdev/core/modedb.c > @@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = { > { NULL, 72, 480, 300, 33386, 40, 24, 11, 19, 80, 3, 0, > FB_VMODE_DOUBLE }, > > + /* 1920x1080 @ 60 Hz, 67.3 kHz hsync */ > + { NULL, 60, 1920, 1080, 6734, 148, 88, 63, 4, 44, 5, 0, > + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT }, This matches [1], except for the "63", which looks like a typo for "36" (total number of lines should be 1125, not 1152). > + > /* 1920x1200 @ 60 Hz, 74.5 Khz hsync */ > { NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3, > FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, [1] https://projectf.io/posts/video-timings-vga-720p-1080p/#hd-1920x1080-60-hz Gr{oetje,eeting}s, Geert
On 5/12/23 09:44, Geert Uytterhoeven wrote: > Hi Helge, > > On Sat, Apr 22, 2023 at 11:27 PM Helge Deller <deller@gmx.de> wrote: >> Add typical resolution for Full-HD monitors. >> >> Signed-off-by: Helge Deller <deller@gmx.de> > >> --- a/drivers/video/fbdev/core/modedb.c >> +++ b/drivers/video/fbdev/core/modedb.c >> @@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = { >> { NULL, 72, 480, 300, 33386, 40, 24, 11, 19, 80, 3, 0, >> FB_VMODE_DOUBLE }, >> >> + /* 1920x1080 @ 60 Hz, 67.3 kHz hsync */ >> + { NULL, 60, 1920, 1080, 6734, 148, 88, 63, 4, 44, 5, 0, >> + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT }, > > This matches [1], except for the "63", which looks like a typo for "36" > (total number of lines should be 1125, not 1152). Thanks Geert! I fixed it in the git tree. Helge > >> + >> /* 1920x1200 @ 60 Hz, 74.5 Khz hsync */ >> { NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3, >> FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, > > [1] https://projectf.io/posts/video-timings-vga-720p-1080p/#hd-1920x1080-60-hz > > Gr{oetje,eeting}s, > > Geert >
diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/modedb.c index 6473e0dfe146..90915a4caac6 100644 --- a/drivers/video/fbdev/core/modedb.c +++ b/drivers/video/fbdev/core/modedb.c @@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = { { NULL, 72, 480, 300, 33386, 40, 24, 11, 19, 80, 3, 0, FB_VMODE_DOUBLE }, + /* 1920x1080 @ 60 Hz, 67.3 kHz hsync */ + { NULL, 60, 1920, 1080, 6734, 148, 88, 63, 4, 44, 5, 0, + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT }, + /* 1920x1200 @ 60 Hz, 74.5 Khz hsync */ { NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3, FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
Add typical resolution for Full-HD monitors. Signed-off-by: Helge Deller <deller@gmx.de>