Message ID | 20230512102844.51084-1-jack.zhu@starfivetech.com (mailing list archive) |
---|---|
Headers | show |
Series | Add StarFive Camera Subsystem driver | expand |
On 12/05/2023 11:28, Jack Zhu wrote: > hi, > > This series is the v5 of the series, the CSI driver is moved to another separate > series. You should run your series through checkpatch.pl --strict 0001-media-dt-bindings-Add-JH7110-Camera-Subsystem.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 87 lines checked 0002-media-admin-guide-Add-starfive_camss.rst-for-Starfiv.patch has no obvious style problems and is ready for submission. CHECK: Lines should not end with a '(' #263: FILE: drivers/media/platform/starfive/stf_camss.c:157: + ret = media_create_pad_link( total: 0 errors, 0 warnings, 1 checks, 592 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0003-media-starfive-Add-basic-driver.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 967 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0004-media-starfive-Add-video-driver.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #188: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 1625 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0005-media-starfive-Add-ISP-driver.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #138: new file mode 100644 CHECK: Macro argument reuse 'ptr_line' - possible side-effects? #155: FILE: drivers/media/platform/starfive/stf_vin.c:13: +#define vin_line_array(ptr_line) \ + ((const struct vin_line (*)[]) &(ptr_line)[-((ptr_line)->id)]) CHECK: Alignment should match open parenthesis #597: FILE: drivers/media/platform/starfive/stf_vin.c:455: + vin_set_dummy_buffer(line, + stf_vin_map_isp_pad(line->id, STF_ISP_PAD_SINK)); CHECK: Lines should not end with a '(' #1222: FILE: drivers/media/platform/starfive/stf_vin.c:1080: + ret = media_create_pad_link( CHECK: Lines should not end with a '(' #1513: FILE: drivers/media/platform/starfive/stf_vin_hw_ops.c:45: + vin_dev->isr_ops->isr_buffer_done( CHECK: Lines should not end with a '(' #1543: FILE: drivers/media/platform/starfive/stf_vin_hw_ops.c:75: + vin_dev->isr_ops->isr_change_buffer( total: 0 errors, 1 warnings, 5 checks, 1654 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0006-media-starfive-Add-VIN-driver.patch has style problems, please review. --- bod