| Message ID | 20230502053534.1240553-1-bhupesh.sharma@linaro.org |
|---|---|
| Headers | show |
| Series | Enable USB SS qmp phy for Qualcomm SM6115 SoC | expand |
On 02-05-23, 11:05, Bhupesh Sharma wrote: > > This patchset adds the support for USB SS qmp phy for Qualcomm SM6115 > SoC. For the previous versions of this patch there were conversations > on irc as to whether this was a 'qcom,usb-ssphy-qmp-usb3-or-dp' or a > 'qcom,usb-ssphy-qmp-dp-combo' as per downstream code and hardware > documentation. > > But after a careful look at downstream dtsi (see [1]) it appears that > this indeed is a 'qcom,usb-ssphy-qmp-usb3-or-dp' phy and not a > 'dp-combo' phy. Fails to apply for me, pls rebase
On Tue, 16 May 2023 at 19:53, Vinod Koul <vkoul@kernel.org> wrote: > > On 02-05-23, 11:05, Bhupesh Sharma wrote: > > > > > This patchset adds the support for USB SS qmp phy for Qualcomm SM6115 > > SoC. For the previous versions of this patch there were conversations > > on irc as to whether this was a 'qcom,usb-ssphy-qmp-usb3-or-dp' or a > > 'qcom,usb-ssphy-qmp-dp-combo' as per downstream code and hardware > > documentation. > > > > But after a careful look at downstream dtsi (see [1]) it appears that > > this indeed is a 'qcom,usb-ssphy-qmp-usb3-or-dp' phy and not a > > 'dp-combo' phy. > > Fails to apply for me, pls rebase Sent v11 which is rebased on phy/next (see [1]). [1]. https://lore.kernel.org/linux-arm-msm/20230516150511.2346357-1-bhupesh.sharma@linaro.org/ Thanks, Bhupesh
Changes since v9: ----------------- - v9 can be seen here: https://lore.kernel.org/linux-arm-msm/20230501192432.1220727-1-bhupesh.sharma@linaro.org/ - Addressed review comments from Dmitry on v9, regarding register size and pcs_misc offset handling. Also collected his R-Bs. Changes since v8: ----------------- - v8 can be seen here: https://lore.kernel.org/linux-arm-msm/20230410171010.2561393-1-bhupesh.sharma@linaro.org/ - Added driver change for new bindings used for sm6115 / qcm2290 devices. Changes since v7: ----------------- - v7 can be seen here: https://lore.kernel.org/linux-arm-msm/20230409200934.2329297-1-bhupesh.sharma@linaro.org/ - Addressed review comments from Dmitry and added "pipe clk". Changes since v6: ----------------- - v6 can be seen here: https://lore.kernel.org/linux-arm-msm/20230407061122.2036838-1-bhupesh.sharma@linaro.org/ - Addressed review comments from Bjorn and Dmitry and dropped old bindings in this version. Changes since v5: ----------------- - v5 can be seen here: https://lore.kernel.org/linux-arm-msm/20230405191633.1864671-1-bhupesh.sharma@linaro.org/ - Addressed review comments from Dmitry and made [PATCH 1/2] compatible with his 'split away legacy USB+DP code' series: <https://patchwork.kernel.org/project/linux-phy/cover/20230324215550.1966809-1-dmitry.baryshkov@linaro.org> Changes since v4: ----------------- - v4 can be seen here: https://lore.kernel.org/linux-arm-msm/20230401154725.1059563-1-bhupesh.sharma@linaro.org/ - Collected Krzysztof's Ack for [PATCH 1/2]. - Added more descriptive commit logs as per Dmitry's comments on v4. Changes since v3: ----------------- - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20221215094532.589291-4-bhupesh.sharma@linaro.org/ - Fixed v4 as per the downstream driver code: https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-usb.dtsi#296 This patchset adds the support for USB SS qmp phy for Qualcomm SM6115 SoC. For the previous versions of this patch there were conversations on irc as to whether this was a 'qcom,usb-ssphy-qmp-usb3-or-dp' or a 'qcom,usb-ssphy-qmp-dp-combo' as per downstream code and hardware documentation. But after a careful look at downstream dtsi (see [1]) it appears that this indeed is a 'qcom,usb-ssphy-qmp-usb3-or-dp' phy and not a 'dp-combo' phy. [1]. https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-usb.dtsi#296 Bhupesh Sharma (4): dt-bindings: phy: qcom,qmp-usb: Drop legacy bindings and move to newer one (SM6115 & QCM2290) phy: qcom-qmp-usb: add support for updated qcm2290 / sm6115 binding arm64: dts: qcom: sm6115: Add USB SS qmp phy node arm64: dts: qcom: qrb4210-rb2: Enable USB node .../phy/qcom,msm8996-qmp-usb3-phy.yaml | 27 ------------ .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 44 ++++++++++++++++--- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 24 ++++++++++ .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++ arch/arm64/boot/dts/qcom/sm6115.dtsi | 29 +++++++++++- .../boot/dts/qcom/sm6115p-lenovo-j606f.dts | 3 ++ drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 22 ++++++++++ 7 files changed, 118 insertions(+), 34 deletions(-)