diff mbox series

[13/16] ARM: vfp: add vfp_entry prototype

Message ID 20230516154605.517690-14-arnd@kernel.org (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series ARM: address -Wmissing-prototype warnings | expand

Commit Message

Arnd Bergmann May 16, 2023, 3:46 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

vfp_entry is only called from assembler code, so it does not
need a declaration. Since gcc complains when extra warnings
are enabled, add one anyway to avoid:

arch/arm/vfp/vfpmodule.c:657:17: warning: no previous prototype for function 'vfp_entry' [-Wmissing-prototypes]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/vfp/vfp.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ard Biesheuvel May 17, 2023, 11:13 a.m. UTC | #1 
On Tue, 16 May 2023 at 17:47, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> vfp_entry is only called from assembler code, so it does not
> need a declaration. Since gcc complains when extra warnings
> are enabled, add one anyway to avoid:
>
> arch/arm/vfp/vfpmodule.c:657:17: warning: no previous prototype for function 'vfp_entry' [-Wmissing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This one will conflict with my VFP asm to C conversion series.

> ---
>  arch/arm/vfp/vfp.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/vfp/vfp.h b/arch/arm/vfp/vfp.h
> index 5cd6d5053271..10d9c0da0fd4 100644
> --- a/arch/arm/vfp/vfp.h
> +++ b/arch/arm/vfp/vfp.h
> @@ -375,3 +375,6 @@ struct op {
>  };
>
>  asmlinkage void vfp_save_state(void *location, u32 fpexc);
> +struct thread_info;
> +asmlinkage void vfp_entry(u32 trigger, struct thread_info *ti, u32 resume_pc,
> +                         u32 resume_return_address);
> --
> 2.39.2
>
diff mbox series

Patch

diff --git a/arch/arm/vfp/vfp.h b/arch/arm/vfp/vfp.h
index 5cd6d5053271..10d9c0da0fd4 100644
--- a/arch/arm/vfp/vfp.h
+++ b/arch/arm/vfp/vfp.h
@@ -375,3 +375,6 @@  struct op {
 };
 
 asmlinkage void vfp_save_state(void *location, u32 fpexc);
+struct thread_info;
+asmlinkage void vfp_entry(u32 trigger, struct thread_info *ti, u32 resume_pc,
+			  u32 resume_return_address);