| Message ID | 20230517022705.112448-1-yunchuan@nfschina.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: bna: bnad: Remove unnecessary (void*) conversions | expand |
On Wed, 17 May 2023 10:27:05 +0800 wuych wrote:
> Pointer variables of void * type do not require type cast.
What tool are you using to find these.
How many of such patches will it take to clean up the entire tree?
在 2023/5/17 11:17, Jakub Kicinski 写道: > On Wed, 17 May 2023 10:27:05 +0800 wuych wrote: >> Pointer variables of void * type do not require type cast. > What tool are you using to find these. > How many of such patches will it take to clean up the entire tree? I use the scripts I found on the kernel Newbies to find these. website: https://kernelnewbies.org/KernelJanitors/Todo/VoidPointerConvs
On Wed, 17 May 2023 13:14:11 +0800 yunchuan wrote: > 在 2023/5/17 11:17, Jakub Kicinski 写道: > > On Wed, 17 May 2023 10:27:05 +0800 wuych wrote: > >> Pointer variables of void * type do not require type cast. > > What tool are you using to find these. > > How many of such patches will it take to clean up the entire tree? > > I use the scripts I found on the kernel Newbies to find these. > > website: https://kernelnewbies.org/KernelJanitors/Todo/VoidPointerConvs How many of such patches will it take to clean up all of net/ and drivers/net ?
在 2023/5/17 23:18, Jakub Kicinski 写道: > On Wed, 17 May 2023 13:14:11 +0800 yunchuan wrote: >> 在 2023/5/17 11:17, Jakub Kicinski 写道: >>> On Wed, 17 May 2023 10:27:05 +0800 wuych wrote: >>>> Pointer variables of void * type do not require type cast. >>> What tool are you using to find these. >>> How many of such patches will it take to clean up the entire tree? >> I use the scripts I found on the kernel Newbies to find these. >> >> website: https://kernelnewbies.org/KernelJanitors/Todo/VoidPointerConvs > How many of such patches will it take to clean up all of net/ and drivers/net ? I have identified 48 areas that need to be modified using the script, and have not yet confirmed whether all of them need to be modified.
On Fri, 19 May 2023 09:38:49 +0800 yunchuan wrote: > >> website: https://kernelnewbies.org/KernelJanitors/Todo/VoidPointerConvs > > How many of such patches will it take to clean up all of net/ and drivers/net ? > > I have identified 48 areas that need to be modified using the script, > and have not yet confirmed whether all of them need to be modified. Once you have worked thru all - please send the changes in series of 10 patches at a time.
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index d6d90f9722a7..31191b520b58 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -1037,8 +1037,7 @@ bnad_cb_ccb_destroy(struct bnad *bnad, struct bna_ccb *ccb) static void bnad_cb_tx_stall(struct bnad *bnad, struct bna_tx *tx) { - struct bnad_tx_info *tx_info = - (struct bnad_tx_info *)tx->priv; + struct bnad_tx_info *tx_info = tx->priv; struct bna_tcb *tcb; u32 txq_id; int i; @@ -1056,7 +1055,7 @@ bnad_cb_tx_stall(struct bnad *bnad, struct bna_tx *tx) static void bnad_cb_tx_resume(struct bnad *bnad, struct bna_tx *tx) { - struct bnad_tx_info *tx_info = (struct bnad_tx_info *)tx->priv; + struct bnad_tx_info *tx_info = tx->priv; struct bna_tcb *tcb; u32 txq_id; int i; @@ -1133,7 +1132,7 @@ bnad_tx_cleanup(struct delayed_work *work) static void bnad_cb_tx_cleanup(struct bnad *bnad, struct bna_tx *tx) { - struct bnad_tx_info *tx_info = (struct bnad_tx_info *)tx->priv; + struct bnad_tx_info *tx_info = tx->priv; struct bna_tcb *tcb; int i; @@ -1149,7 +1148,7 @@ bnad_cb_tx_cleanup(struct bnad *bnad, struct bna_tx *tx) static void bnad_cb_rx_stall(struct bnad *bnad, struct bna_rx *rx) { - struct bnad_rx_info *rx_info = (struct bnad_rx_info *)rx->priv; + struct bnad_rx_info *rx_info = rx->priv; struct bna_ccb *ccb; struct bnad_rx_ctrl *rx_ctrl; int i; @@ -1208,7 +1207,7 @@ bnad_rx_cleanup(void *work) static void bnad_cb_rx_cleanup(struct bnad *bnad, struct bna_rx *rx) { - struct bnad_rx_info *rx_info = (struct bnad_rx_info *)rx->priv; + struct bnad_rx_info *rx_info = rx->priv; struct bna_ccb *ccb; struct bnad_rx_ctrl *rx_ctrl; int i; @@ -1231,7 +1230,7 @@ bnad_cb_rx_cleanup(struct bnad *bnad, struct bna_rx *rx) static void bnad_cb_rx_post(struct bnad *bnad, struct bna_rx *rx) { - struct bnad_rx_info *rx_info = (struct bnad_rx_info *)rx->priv; + struct bnad_rx_info *rx_info = rx->priv; struct bna_ccb *ccb; struct bna_rcb *rcb; struct bnad_rx_ctrl *rx_ctrl;
Pointer variables of void * type do not require type cast. Signed-off-by: wuych <yunchuan@nfschina.com> --- drivers/net/ethernet/brocade/bna/bnad.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)