mbox series

[v2,0/2] C20 Computed HDMI TMDS pixel clocks

Message ID 20230515231725.3815199-1-clinton.a.taylor@intel.com (mailing list archive)
Headers show
Series C20 Computed HDMI TMDS pixel clocks | expand

Message

Clint Taylor May 15, 2023, 11:17 p.m. UTC
Use computed C20 HDMI TMDS pixel clocks to support 25.175MHz to 594000MHz modes. Add 16 Bit mask operators to support C20 phy programming.

v2: checkpatch fixes
BSPEC: 64568
Cc: Imre Deak <imre.deak@intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Clint Taylor <Clinton.A.Taylor@intel.com>

Clint Taylor (2):
  drm/i915: Add 16bit register/mask operators
  drm/i915/hdmi: C20 computed PLL frequencies

 drivers/gpu/drm/i915/display/intel_cx0_phy.c  | 89 +++++++++++++++++--
 .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 53 +++++++++++
 drivers/gpu/drm/i915/i915_reg_defs.h          | 48 ++++++++++
 3 files changed, 184 insertions(+), 6 deletions(-)

Comments

Clint Taylor May 18, 2023, 10:08 p.m. UTC | #1
On Thu, 2023-05-18 at 19:31 +0000, Patchwork wrote:
> Patch Details
> Series:	C20 Computed HDMI TMDS pixel clocks (rev3)
> URL:	https://patchwork.freedesktop.org/series/117399/
> State:	failure
> Details:	https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117399v3/index.html
> CI Bug Log - changes from CI_DRM_13164 -> Patchwork_117399v3
> Summary
> FAILURE
> 
> Serious unknown changes coming with Patchwork_117399v3 absolutely need to be
> verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_117399v3, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> 
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117399v3/index.html
> 
> Participating hosts (39 -> 36)
> Missing (3): fi-kbl-soraka fi-snb-2520m fi-bsw-n3050
> 
> Possible new issues
> Here are the unknown changes that may have been introduced in Patchwork_117399v3:
> 
> IGT changes
> Possible regressions
> igt@kms_pipe_crc_basic@read-crc@pipe-c-edp-1:
> bat-adlp-6: PASS -> ABORT

Changes in this patch series not relevant to ADLP (v3) or ADLS (v2) platforms. Series can
only cause regressions on MTL platform with C20 HDMI output. 

-Clint
  
> Suppressed
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
> 
> igt@i915_selftest@live@migrate:
> {bat-mtlp-8}: PASS -> DMESG-FAIL
> Known issues
> Here are the changes found in Patchwork_117399v3 that come from known issues:
> 
> IGT changes
> Issues hit
> igt@i915_selftest@live@gt_engines:
> 
> bat-atsm-1: PASS -> FAIL (i915#6268)
> igt@i915_selftest@live@gt_pm:
> 
> bat-rpls-2: NOTRUN -> DMESG-FAIL (i915#4258 / i915#7913)
> igt@i915_selftest@live@requests:
> 
> bat-rpls-2: NOTRUN -> ABORT (i915#7913 / i915#7982)
> Possible fixes
> igt@i915_selftest@live@gt_heartbeat:
> 
> fi-glk-j4005: DMESG-FAIL (i915#5334) -> PASS
> igt@i915_selftest@live@gt_lrc:
> 
> bat-rpls-2: INCOMPLETE (i915#4983 / i915#7913) -> PASS
> igt@i915_selftest@live@gt_mocs:
> 
> {bat-mtlp-8}: DMESG-FAIL -> PASS
> igt@i915_suspend@basic-s3-without-i915:
> 
> bat-adls-5: FAIL (fdo#103375) -> PASS +3 similar issues
> igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
> 
> bat-dg2-8: FAIL (i915#7932) -> PASS
> igt@kms_pipe_crc_basic@read-crc@pipe-b-edp-1:
> 
> bat-adlp-6: ABORT -> PASS
> Warnings
> igt@i915_selftest@live@requests:
> 
> bat-rpls-1: ABORT (i915#7911 / i915#7920 / i915#7982) -> ABORT (i915#7911 / i915#7920)
> igt@kms_setmode@basic-clone-single-crtc:
> 
> bat-rplp-1: SKIP (i915#3555 / i915#4579) -> ABORT (i915#4579 / i915#8260)
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> Build changes
> Linux: CI_DRM_13164 -> Patchwork_117399v3
> CI-20190529: 20190529
> CI_DRM_13164: 30793067f161dfcbaca1b0249d919c9fc306754e @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7296: f58eaf30c30c1cc9f00c8b5c596ee5c94d054198 @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_117399v3: 30793067f161dfcbaca1b0249d919c9fc306754e @
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> Linux commits
> e2b63090a956 drm/i915/hdmi: C20 computed PLL frequencies
> 273769d73c7b drm/i915: Add 16bit register/mask operators
Matt Roper May 19, 2023, 5:14 p.m. UTC | #2
On Thu, May 18, 2023 at 10:08:42PM +0000, Taylor, Clinton A wrote:
> On Thu, 2023-05-18 at 19:31 +0000, Patchwork wrote:
> > Patch Details
> > Series:	C20 Computed HDMI TMDS pixel clocks (rev3)
> > URL:	https://patchwork.freedesktop.org/series/117399/
> > State:	failure
> > Details:	https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117399v3/index.html
> > CI Bug Log - changes from CI_DRM_13164 -> Patchwork_117399v3
> > Summary
> > FAILURE
> > 
> > Serious unknown changes coming with Patchwork_117399v3 absolutely need to be
> > verified manually.
> > 
> > If you think the reported changes have nothing to do with the changes
> > introduced in Patchwork_117399v3, please notify your bug team to allow them
> > to document this new failure mode, which will reduce false positives in CI.
> > 
> > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117399v3/index.html
> > 
> > Participating hosts (39 -> 36)
> > Missing (3): fi-kbl-soraka fi-snb-2520m fi-bsw-n3050
> > 
> > Possible new issues
> > Here are the unknown changes that may have been introduced in Patchwork_117399v3:
> > 
> > IGT changes
> > Possible regressions
> > igt@kms_pipe_crc_basic@read-crc@pipe-c-edp-1:
> > bat-adlp-6: PASS -> ABORT
> 
> Changes in this patch series not relevant to ADLP (v3) or ADLS (v2) platforms. Series can
> only cause regressions on MTL platform with C20 HDMI output. 

And we have no MTL machines in the shards pool yet, so that means these
patches can't impact shard results and we don't need to worry about the
fact we never got them.

Applied to drm-intel-next (with a small tweak to wrap one overly long
line).  Thanks for the patches and reviews.


Matt

> 
> -Clint
>   
> > Suppressed
> > The following results come from untrusted machines, tests, or statuses.
> > They do not affect the overall result.
> > 
> > igt@i915_selftest@live@migrate:
> > {bat-mtlp-8}: PASS -> DMESG-FAIL
> > Known issues
> > Here are the changes found in Patchwork_117399v3 that come from known issues:
> > 
> > IGT changes
> > Issues hit
> > igt@i915_selftest@live@gt_engines:
> > 
> > bat-atsm-1: PASS -> FAIL (i915#6268)
> > igt@i915_selftest@live@gt_pm:
> > 
> > bat-rpls-2: NOTRUN -> DMESG-FAIL (i915#4258 / i915#7913)
> > igt@i915_selftest@live@requests:
> > 
> > bat-rpls-2: NOTRUN -> ABORT (i915#7913 / i915#7982)
> > Possible fixes
> > igt@i915_selftest@live@gt_heartbeat:
> > 
> > fi-glk-j4005: DMESG-FAIL (i915#5334) -> PASS
> > igt@i915_selftest@live@gt_lrc:
> > 
> > bat-rpls-2: INCOMPLETE (i915#4983 / i915#7913) -> PASS
> > igt@i915_selftest@live@gt_mocs:
> > 
> > {bat-mtlp-8}: DMESG-FAIL -> PASS
> > igt@i915_suspend@basic-s3-without-i915:
> > 
> > bat-adls-5: FAIL (fdo#103375) -> PASS +3 similar issues
> > igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
> > 
> > bat-dg2-8: FAIL (i915#7932) -> PASS
> > igt@kms_pipe_crc_basic@read-crc@pipe-b-edp-1:
> > 
> > bat-adlp-6: ABORT -> PASS
> > Warnings
> > igt@i915_selftest@live@requests:
> > 
> > bat-rpls-1: ABORT (i915#7911 / i915#7920 / i915#7982) -> ABORT (i915#7911 / i915#7920)
> > igt@kms_setmode@basic-clone-single-crtc:
> > 
> > bat-rplp-1: SKIP (i915#3555 / i915#4579) -> ABORT (i915#4579 / i915#8260)
> > {name}: This element is suppressed. This means it is ignored when computing
> > the status of the difference (SUCCESS, WARNING, or FAILURE).
> > 
> > Build changes
> > Linux: CI_DRM_13164 -> Patchwork_117399v3
> > CI-20190529: 20190529
> > CI_DRM_13164: 30793067f161dfcbaca1b0249d919c9fc306754e @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_7296: f58eaf30c30c1cc9f00c8b5c596ee5c94d054198 @ 
> > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> > Patchwork_117399v3: 30793067f161dfcbaca1b0249d919c9fc306754e @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > 
> > Linux commits
> > e2b63090a956 drm/i915/hdmi: C20 computed PLL frequencies
> > 273769d73c7b drm/i915: Add 16bit register/mask operators