mbox series

[v5,0/3] Support Honeywell mprls0025pa pressure sensor

Message ID ZGNpZM137jF5yzie@arbad (mailing list archive)
Headers show
Series Support Honeywell mprls0025pa pressure sensor | expand

Message

Andreas Klinger May 16, 2023, 11:30 a.m. UTC 
Support Honeywell mprls0025pa pressure sensor.

This patch series adds support for Honeywell mprls0025pa pressure sensor series.
There are a variety of sensors with different pressure ranges supported.

Changes in v5:
- Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
  - add Reviewd-by tag
  - preserve formating in description
- Patch 2: "iio: pressure: Honeywell mprls0025pa pressure sensor"
  - make use of div_s64_rem()
  - document calculation
  - reorder includes
  - use NANO from units.h
- Patch 3: "MAINTAINERS: Add Honeywell mprls0025pa sensor"
  - no changes

Changes in v4:
- Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
  - change line length to 80 characters
  - make vdd-supply mandatory
- Patch 2: "iio: pressure: Honeywell mprls0025pa pressure sensor"
  - change line length to 80 characters
  - change regulator vcc to devm_regulator_get_enable()
  - switch to probe_new
  - many changes from the review
- Patch 3: "MAINTAINERS: Add Honeywell mprls0025pa sensor"
  - no changes

Changes in v3:
- Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
  - fix errors while doing dt_binding_check
  - add vdd-supply
- Patch 2: "iio: pressure: Honeywell mpr pressure sensor"
  - change to _RAW interface
  - add transfer function
  - add regulator
  - move to device_property_xxx functions
  - many more changes from the feedbacks
- Patch 3: "MAINTAINERS: Add Honeywell mpr sensor"
  - change file names

Changes in v2:
- Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
  - change the global sensor decription of mpr to the specific sensor
    mprls0025pa
  - change compatible string
  - rename the file to honeywell,mprls0025pa.yaml
  - honeywell,pmin-pascal and honeywell,pmax-pascal: add unit pascal to property
    names 
  - add new property honeywell,transfer-function
- Patch 2: "iio: pressure: Honeywell mpr pressure sensor"
  - no change so far
  - will be changed and send out as new version when the dt definition is
    settled down
- Patch 3: "MAINTAINERS: Add Honeywell mpr sensor"
  - no change so far

Andreas Klinger (3):
  dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor
  iio: pressure: Honeywell mprls0025pa pressure sensor
  MAINTAINERS: Add Honeywell mprls0025pa sensor

 .../iio/pressure/honeywell,mprls0025pa.yaml   | 104 ++++
 MAINTAINERS                                   |   7 +
 drivers/iio/pressure/Kconfig                  |  13 +
 drivers/iio/pressure/Makefile                 |   1 +
 drivers/iio/pressure/mprls0025pa.c            | 450 ++++++++++++++++++
 5 files changed, 575 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
 create mode 100644 drivers/iio/pressure/mprls0025pa.c


base-commit: 457391b0380335d5e9a5babdec90ac53928b23b4

Comments

Jonathan Cameron May 20, 2023, 4:24 p.m. UTC | #1 
On Tue, 16 May 2023 13:30:44 +0200
Andreas Klinger <ak@it-klinger.de> wrote:

> Support Honeywell mprls0025pa pressure sensor.
Series applied to the togreg branch of iio.git and initially pushed out
as testing for 0-day to see if it can find anything we missed.

Thanks,

Jonathan

> 
> This patch series adds support for Honeywell mprls0025pa pressure sensor series.
> There are a variety of sensors with different pressure ranges supported.
> 
> Changes in v5:
> - Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
>   - add Reviewd-by tag
>   - preserve formating in description
> - Patch 2: "iio: pressure: Honeywell mprls0025pa pressure sensor"
>   - make use of div_s64_rem()
>   - document calculation
>   - reorder includes
>   - use NANO from units.h
> - Patch 3: "MAINTAINERS: Add Honeywell mprls0025pa sensor"
>   - no changes
> 
> Changes in v4:
> - Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
>   - change line length to 80 characters
>   - make vdd-supply mandatory
> - Patch 2: "iio: pressure: Honeywell mprls0025pa pressure sensor"
>   - change line length to 80 characters
>   - change regulator vcc to devm_regulator_get_enable()
>   - switch to probe_new
>   - many changes from the review
> - Patch 3: "MAINTAINERS: Add Honeywell mprls0025pa sensor"
>   - no changes
> 
> Changes in v3:
> - Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
>   - fix errors while doing dt_binding_check
>   - add vdd-supply
> - Patch 2: "iio: pressure: Honeywell mpr pressure sensor"
>   - change to _RAW interface
>   - add transfer function
>   - add regulator
>   - move to device_property_xxx functions
>   - many more changes from the feedbacks
> - Patch 3: "MAINTAINERS: Add Honeywell mpr sensor"
>   - change file names
> 
> Changes in v2:
> - Patch 1: "dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor"
>   - change the global sensor decription of mpr to the specific sensor
>     mprls0025pa
>   - change compatible string
>   - rename the file to honeywell,mprls0025pa.yaml
>   - honeywell,pmin-pascal and honeywell,pmax-pascal: add unit pascal to property
>     names 
>   - add new property honeywell,transfer-function
> - Patch 2: "iio: pressure: Honeywell mpr pressure sensor"
>   - no change so far
>   - will be changed and send out as new version when the dt definition is
>     settled down
> - Patch 3: "MAINTAINERS: Add Honeywell mpr sensor"
>   - no change so far
> 
> Andreas Klinger (3):
>   dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor
>   iio: pressure: Honeywell mprls0025pa pressure sensor
>   MAINTAINERS: Add Honeywell mprls0025pa sensor
> 
>  .../iio/pressure/honeywell,mprls0025pa.yaml   | 104 ++++
>  MAINTAINERS                                   |   7 +
>  drivers/iio/pressure/Kconfig                  |  13 +
>  drivers/iio/pressure/Makefile                 |   1 +
>  drivers/iio/pressure/mprls0025pa.c            | 450 ++++++++++++++++++
>  5 files changed, 575 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
>  create mode 100644 drivers/iio/pressure/mprls0025pa.c
> 
> 
> base-commit: 457391b0380335d5e9a5babdec90ac53928b23b4
Andy Shevchenko May 28, 2023, 10:09 p.m. UTC | #2 
Sat, May 20, 2023 at 05:24:05PM +0100, Jonathan Cameron kirjoitti:
> On Tue, 16 May 2023 13:30:44 +0200
> Andreas Klinger <ak@it-klinger.de> wrote:
> 
> > Support Honeywell mprls0025pa pressure sensor.
> Series applied to the togreg branch of iio.git and initially pushed out
> as testing for 0-day to see if it can find anything we missed.

Hmm... Should the comments I'm about to leave be addressed as followups?
Jonathan Cameron June 4, 2023, 1:07 p.m. UTC | #3 
On Mon, 29 May 2023 01:09:19 +0300
andy.shevchenko@gmail.com wrote:

> Sat, May 20, 2023 at 05:24:05PM +0100, Jonathan Cameron kirjoitti:
> > On Tue, 16 May 2023 13:30:44 +0200
> > Andreas Klinger <ak@it-klinger.de> wrote:
> >   
> > > Support Honeywell mprls0025pa pressure sensor.  
> > Series applied to the togreg branch of iio.git and initially pushed out
> > as testing for 0-day to see if it can find anything we missed.  
> 
> Hmm... Should the comments I'm about to leave be addressed as followups?
> 

Yes please.  As with previous, whilst good comments, nothing significant
enough that I'd want to rebase the tree.
Perhaps filter out the least important ones (one line vs two line on 81 char
lines) though.

Jonathan