| Message ID | 20230522073017.1782984-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/amdgpu: Fix unsigned comparison with zero in gmc_v9_0_process_interrupt() | expand |
Applied. Thanks! On Mon, May 22, 2023 at 3:30 AM Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > > Smatch warns: > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:579: > unsigned 'xcc_id' is never less than zero. > > gfx_v9_4_3_ih_to_xcc_inst() returns negative numbers as well. > Fix this by changing type of xcc_id to int. > > Fixes: faf96b9b602d ("drm/amdgpu: correct the vmhub index when page fault occurs") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > This is from static analysis, only compile tested. > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index f70e666cecf2..1e8b2aaa48c1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -557,8 +557,8 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev, > const char *hub_name; > u64 addr; > uint32_t cam_index = 0; > - int ret; > - uint32_t node_id, xcc_id = 0; > + int ret, xcc_id = 0; > + uint32_t node_id; > > node_id = entry->node_id; > > -- > 2.38.1 >
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index f70e666cecf2..1e8b2aaa48c1 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c @@ -557,8 +557,8 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev, const char *hub_name; u64 addr; uint32_t cam_index = 0; - int ret; - uint32_t node_id, xcc_id = 0; + int ret, xcc_id = 0; + uint32_t node_id; node_id = entry->node_id;
Smatch warns: drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:579: unsigned 'xcc_id' is never less than zero. gfx_v9_4_3_ih_to_xcc_inst() returns negative numbers as well. Fix this by changing type of xcc_id to int. Fixes: faf96b9b602d ("drm/amdgpu: correct the vmhub index when page fault occurs") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- This is from static analysis, only compile tested. --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)