| Message ID | 20230516081116.71370-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fcbc3aaccfd57c7e71eac36bf1a8f063f19ceefa |
| Headers | show |
| Series | [-next] ASoC: SOF: ipc4-topology: Fix an unsigned comparison which can never be negative | expand |
On Tue, 2023-05-16 at 16:11 +0800, Yang Li wrote: > The return value from the call to sof_ipc4_get_valid_bits() is int. > However, the return value is being assigned to an unsigned > int variable 'out_ref_valid_bits', so making it an int. > > Eliminate the following warning: > ./sound/soc/sof/ipc4-topology.c:1537:6-24: WARNING: Unsigned > expression compared with zero: out_ref_valid_bits < 0 > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4985 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> LGTM, thanks! Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
On Tue, 16 May 2023 16:11:16 +0800, Yang Li wrote: > The return value from the call to sof_ipc4_get_valid_bits() is int. > However, the return value is being assigned to an unsigned > int variable 'out_ref_valid_bits', so making it an int. > > Eliminate the following warning: > ./sound/soc/sof/ipc4-topology.c:1537:6-24: WARNING: Unsigned expression compared with zero: out_ref_valid_bits < 0 > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: ipc4-topology: Fix an unsigned comparison which can never be negative commit: fcbc3aaccfd57c7e71eac36bf1a8f063f19ceefa All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index dce2f8f7f518..d82ac5701eb2 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -1381,8 +1381,8 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget, void **ipc_config_data; int *ipc_config_size; u32 **data; - int ipc_size, ret; - u32 out_ref_rate, out_ref_channels, out_ref_valid_bits; + int ipc_size, ret, out_ref_valid_bits; + u32 out_ref_rate, out_ref_channels; u32 deep_buffer_dma_ms = 0; int output_fmt_index;
The return value from the call to sof_ipc4_get_valid_bits() is int. However, the return value is being assigned to an unsigned int variable 'out_ref_valid_bits', so making it an int. Eliminate the following warning: ./sound/soc/sof/ipc4-topology.c:1537:6-24: WARNING: Unsigned expression compared with zero: out_ref_valid_bits < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4985 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- sound/soc/sof/ipc4-topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)