| Message ID | 20230529074912.2070902-1-suijingfeng@loongson.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915_drm.h: fix a typo | expand |
On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote: > 'rbiter' -> 'arbite' Should be arbiter. > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > include/drm/i915_drm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h > index 7adce327c1c2..3dcb1db519ae 100644 > --- a/include/drm/i915_drm.h > +++ b/include/drm/i915_drm.h > @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res; > * The Bridge device's PCI config space has information about the > * fb aperture size and the amount of pre-reserved memory. > * This is all handled in the intel-gtt.ko module. i915.ko only > - * cares about the vga bit for the vga rbiter. > + * cares about the vga bit for the vga arbite. > */ > #define INTEL_GMCH_CTRL 0x52 > #define INTEL_GMCH_VGA_DISABLE (1 << 1)
Hi, On 2023/5/29 16:06, Jani Nikula wrote: > On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote: >> 'rbiter' -> 'arbite' > Should be arbiter. Yeah, should be arbiter. arbiter is a noun. Here, this arbiter may referrer to the drivers/pci/vgaarb.c. Can you help correct then apply it ? thanks. > >> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >> --- >> include/drm/i915_drm.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h >> index 7adce327c1c2..3dcb1db519ae 100644 >> --- a/include/drm/i915_drm.h >> +++ b/include/drm/i915_drm.h >> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res; >> * The Bridge device's PCI config space has information about the >> * fb aperture size and the amount of pre-reserved memory. >> * This is all handled in the intel-gtt.ko module. i915.ko only >> - * cares about the vga bit for the vga rbiter. >> + * cares about the vga bit for the vga arbite. >> */ >> #define INTEL_GMCH_CTRL 0x52 >> #define INTEL_GMCH_VGA_DISABLE (1 << 1)
On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote: > Hi, > > > On 2023/5/29 16:06, Jani Nikula wrote: >> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote: >>> 'rbiter' -> 'arbite' >> Should be arbiter. > > Yeah, should be arbiter. > > arbiter is a noun. Here, this arbiter may referrer to the > drivers/pci/vgaarb.c. > > Can you help correct then apply it ? thanks. Please send a fixed version and I'll apply it. I'm not fixing trivial patches for you. BR, Jani. > >> >>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >>> --- >>> include/drm/i915_drm.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h >>> index 7adce327c1c2..3dcb1db519ae 100644 >>> --- a/include/drm/i915_drm.h >>> +++ b/include/drm/i915_drm.h >>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res; >>> * The Bridge device's PCI config space has information about the >>> * fb aperture size and the amount of pre-reserved memory. >>> * This is all handled in the intel-gtt.ko module. i915.ko only >>> - * cares about the vga bit for the vga rbiter. >>> + * cares about the vga bit for the vga arbite. >>> */ >>> #define INTEL_GMCH_CTRL 0x52 >>> #define INTEL_GMCH_VGA_DISABLE (1 << 1)
Hi, I'm just hesitating to so, thank you. On 2023/5/29 18:06, Jani Nikula wrote: > On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote: >> Hi, >> >> >> On 2023/5/29 16:06, Jani Nikula wrote: >>> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote: >>>> 'rbiter' -> 'arbite' >>> Should be arbiter. >> Yeah, should be arbiter. >> >> arbiter is a noun. Here, this arbiter may referrer to the >> drivers/pci/vgaarb.c. >> >> Can you help correct then apply it ? thanks. > Please send a fixed version and I'll apply it. I'm not fixing trivial > patches for you. > > BR, > Jani. > > >>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >>>> --- >>>> include/drm/i915_drm.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h >>>> index 7adce327c1c2..3dcb1db519ae 100644 >>>> --- a/include/drm/i915_drm.h >>>> +++ b/include/drm/i915_drm.h >>>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res; >>>> * The Bridge device's PCI config space has information about the >>>> * fb aperture size and the amount of pre-reserved memory. >>>> * This is all handled in the intel-gtt.ko module. i915.ko only >>>> - * cares about the vga bit for the vga rbiter. >>>> + * cares about the vga bit for the vga arbite. >>>> */ >>>> #define INTEL_GMCH_CTRL 0x52 >>>> #define INTEL_GMCH_VGA_DISABLE (1 << 1)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 7adce327c1c2..3dcb1db519ae 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res; * The Bridge device's PCI config space has information about the * fb aperture size and the amount of pre-reserved memory. * This is all handled in the intel-gtt.ko module. i915.ko only - * cares about the vga bit for the vga rbiter. + * cares about the vga bit for the vga arbite. */ #define INTEL_GMCH_CTRL 0x52 #define INTEL_GMCH_VGA_DISABLE (1 << 1)
'rbiter' -> 'arbite' Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> --- include/drm/i915_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)