drm: rcar-du: Use dev_err_probe()

Commit Message

Laurent Pinchart May 30, 2023, 9:26 a.m. UTC

Replace manual handling of EPROBE_DEFER with dev_err_probe() to simplify
the code.

Signed-off-by: Laurent Pinchart <[e-mail]>
---
 drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


base-commit: 85d712f033d23bb56a373e29465470c036532d46
prerequisite-patch-id: 74c948ef7587221bcc859d7e0b38b54b7c404163
prerequisite-patch-id: 41d31c65b9895beb2f15c1dd2b89e435657a639c
prerequisite-patch-id: bd71c64e0d7f9a6a5212ef9ad499fb7cdc718425
prerequisite-patch-id: a01de55d9563b98ab2d86d78db436da198bc4649
prerequisite-patch-id: 2faeeea13f349cae2470b09926ed52e5743f1579
prerequisite-patch-id: 783a84269c3d66600ec31046bee76e2aabcb32ad

Comments

Geert Uytterhoeven May 30, 2023, 9:38 a.m. UTC | #1

Hi Laurent,

On Tue, May 30, 2023 at 11:34 AM Laurent Pinchart
<[e-mail]> wrote:
> Replace manual handling of EPROBE_DEFER with dev_err_probe() to simplify
> the code.
>
> Signed-off-by: Laurent Pinchart <[e-mail]>

Thanks for your patch!

I sent a similar patch before:
https://lore.kernel.org/linux-renesas-soc/62add[e-mail]
leading to your comment that the deeper paths should be fixed instead.

Gr{oetje,eeting}s,

                        Geert

Laurent Pinchart May 30, 2023, 9:46 a.m. UTC | #2

Hi Geert,

On Tue, May 30, 2023 at 11:38:44AM +0200, Geert Uytterhoeven wrote:
> On Tue, May 30, 2023 at 11:34 AM Laurent Pinchart wrote:
> > Replace manual handling of EPROBE_DEFER with dev_err_probe() to simplify
> > the code.
> >
> > Signed-off-by: Laurent Pinchart <[e-mail]>
> 
> Thanks for your patch!
> 
> I sent a similar patch before:
> https://lore.kernel.org/linux-renesas-soc/62add[e-mail]
> leading to your comment that the deeper paths should be fixed instead.

Thanks for your help dealing with my goldfish memory :-)

I'll try to fix the deeper paths.

Patch

diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
index 1ffde19cb87f..91095f9deb8b 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
@@ -701,9 +701,7 @@  static int rcar_du_probe(struct platform_device *pdev)
 	/* DRM/KMS objects */
 	ret = rcar_du_modeset_init(rcdu);
 	if (ret < 0) {
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev,
-				"failed to initialize DRM/KMS (%d)\n", ret);
+		dev_err_probe(&pdev->dev, ret, "failed to initialize DRM/KMS\n");
 		goto error;
 	}