Message ID | 20230524230459.120681-5-guptarud@gmail.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | [1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi | expand |
On 25.05.2023 01:04, Rudraksha Gupta wrote: > This adds a very basic device tree file for the Samsung Galaxy Express > SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and > USB. > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/qcom-msm8960-samsung-expressatt.dts | 334 ++++++++++++++++++ > 2 files changed, 335 insertions(+) > create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..12c90f263142 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1081,6 +1081,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-msm8916-samsung-grandmax.dtb \ > qcom-msm8916-samsung-serranove.dtb \ > qcom-msm8960-cdp.dtb \ > + qcom-msm8960-samsung-expressatt.dtb \ > qcom-msm8974-lge-nexus5-hammerhead.dtb \ > qcom-msm8974-sony-xperia-rhine-amami.dtb \ > qcom-msm8974-sony-xperia-rhine-honami.dtb \ > diff --git a/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts > new file mode 100644 > index 000000000000..2d6f0def0589 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts > @@ -0,0 +1,334 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include <dt-bindings/input/input.h> > + > +#include "qcom-msm8960.dtsi" > +#include <dt-bindings/reset/qcom,gcc-msm8960.h> > + > +/ { > + model = "Samsung Galaxy S3 SGH-I437"; Googling the model name, it seems to be officially sold as "Samsung Galaxy Express", without any mention of the S3 bit. Is that on purpose? > + compatible = "samsung,expressatt", "qcom,msm8960"; > + chassis-type = "handset"; > + > + aliases { > + serial0 = &gsbi5_serial; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&gsbi5 { > + status = "okay"; > + qcom,mode = <GSBI_PROT_I2C_UART>; Please ensure status is the last property within each node > +}; > + > +&gsbi5_serial { > + status = "okay"; > +}; > + > +/* eMMC */ > +&sdcc1 { You may want to add aliases for mmc hosts (check e.g. arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts) > + status = "okay"; > + vmmc-supply = <&pm8921_l5>; > +}; > + > +/* External micro SD card */ > +&sdcc3 { > + status = "okay"; > + vmmc-supply = <&pm8921_l6>; > + vqmmc-supply = <&pm8921_l7>; > +}; > + > +&gsbi1 { > + status = "okay"; > + qcom,mode = <GSBI_PROT_SPI>; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi1_default>; Please do pinctrl-n pinctrl-names > +}; > + > +&gsbi1_spi{ Add a space between 'i' and '{' Konrad > + status = "okay"; > +}; > + > +&msmgpio { > + spi1_default: spi1_default { > + mux { > + pins = "gpio6", "gpio7", "gpio9"; > + function = "gsbi1"; > + }; > + > + mosi { > + pins = "gpio6"; > + drive-strength = <12>; > + bias-disable; > + }; > + > + miso { > + pins = "gpio7"; > + drive-strength = <12>; > + bias-disable; > + }; > + > + cs { > + pins = "gpio8"; > + drive-strength = <12>; > + bias-disable; > + output-low; > + }; > + > + clk { > + pins = "gpio9"; > + drive-strength = <12>; > + bias-disable; > + }; > + }; > +}; > + > + > +&rpm { > + regulators { > + compatible = "qcom,rpm-pm8921-regulators"; > + vin_lvs1_3_6-supply = <&pm8921_s4>; > + vin_lvs2-supply = <&pm8921_s4>; > + vin_lvs4_5_7-supply = <&pm8921_s4>; > + vdd_ncp-supply = <&pm8921_l6>; > + vdd_l1_l2_l12_l18-supply = <&pm8921_s4>; > + vdd_l21_l23_l29-supply = <&pm8921_s8>; > + vdd_l24-supply = <&pm8921_s1>; > + vdd_l25-supply = <&pm8921_s1>; > + vdd_l27-supply = <&pm8921_s7>; > + vdd_l28-supply = <&pm8921_s7>; > + > + /* Buck SMPS */ > + pm8921_s1: s1 { > + regulator-always-on; > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + qcom,switch-mode-frequency = <3200000>; > + bias-pull-down; > + }; > + > + pm8921_s2: s2 { > + regulator-min-microvolt = <1300000>; > + regulator-max-microvolt = <1300000>; > + qcom,switch-mode-frequency = <1600000>; > + bias-pull-down; > + }; > + > + pm8921_s3: s3 { > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1150000>; > + qcom,switch-mode-frequency = <4800000>; > + bias-pull-down; > + }; > + > + pm8921_s4: s4 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + qcom,switch-mode-frequency = <1600000>; > + bias-pull-down; > + qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>; > + }; > + > + pm8921_s7: s7 { > + regulator-min-microvolt = <1150000>; > + regulator-max-microvolt = <1150000>; > + qcom,switch-mode-frequency = <3200000>; > + bias-pull-down; > + }; > + > + pm8921_s8: s8 { > + regulator-always-on; > + regulator-min-microvolt = <2050000>; > + regulator-max-microvolt = <2050000>; > + qcom,switch-mode-frequency = <1600000>; > + bias-pull-down; > + }; > + > + /* PMOS LDO */ > + pm8921_l1: l1 { > + regulator-always-on; > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1050000>; > + bias-pull-down; > + }; > + > + pm8921_l2: l2 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + bias-pull-down; > + }; > + > + pm8921_l3: l3 { > + regulator-min-microvolt = <3075000>; > + regulator-max-microvolt = <3300000>; > + bias-pull-down; > + }; > + > + pm8921_l4: l4 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + bias-pull-down; > + }; > + > + pm8921_l5: l5 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + bias-pull-down; > + }; > + > + pm8921_l6: l6 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + bias-pull-down; > + }; > + > + pm8921_l7: l7 { > + regulator-always-on; > + regulator-min-microvolt = <1850000>; > + regulator-max-microvolt = <2950000>; > + bias-pull-down; > + }; > + > + pm8921_l8: l8 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3100000>; > + bias-pull-down; > + }; > + > + pm8921_l9: l9 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + bias-pull-down; > + }; > + > + pm8921_l10: l10 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + bias-pull-down; > + }; > + > + pm8921_l11: l11 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3300000>; > + bias-pull-down; > + }; > + > + pm8921_l12: l12 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + bias-pull-down; > + }; > + > + pm8921_l14: l14 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + bias-pull-down; > + }; > + > + pm8921_l15: l15 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + bias-pull-down; > + }; > + > + pm8921_l16: l16 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3000000>; > + bias-pull-down; > + }; > + > + pm8921_l17: l17 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + bias-pull-down; > + }; > + > + pm8921_l18: l18 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1500000>; > + bias-pull-down; > + }; > + > + pm8921_l21: l21 { > + regulator-min-microvolt = <1900000>; > + regulator-max-microvolt = <1900000>; > + bias-pull-down; > + }; > + > + pm8921_l22: l22 { > + regulator-min-microvolt = <2750000>; > + regulator-max-microvolt = <2750000>; > + bias-pull-down; > + }; > + > + pm8921_l23: l23 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + bias-pull-down; > + }; > + > + pm8921_l24: l24 { > + regulator-min-microvolt = <750000>; > + regulator-max-microvolt = <1150000>; > + bias-pull-down; > + }; > + > + pm8921_l25: l25 { > + regulator-always-on; > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + bias-pull-down; > + }; > + > + /* Low Voltage Switch */ > + pm8921_lvs1: lvs1 { > + bias-pull-down; > + }; > + > + pm8921_lvs2: lvs2 { > + bias-pull-down; > + }; > + > + pm8921_lvs3: lvs3 { > + bias-pull-down; > + }; > + > + pm8921_lvs4: lvs4 { > + bias-pull-down; > + }; > + > + pm8921_lvs5: lvs5 { > + bias-pull-down; > + }; > + > + pm8921_lvs6: lvs6 { > + bias-pull-down; > + }; > + > + pm8921_lvs7: lvs7 { > + bias-pull-down; > + }; > + > + pm8921_ncp: ncp { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + qcom,switch-mode-frequency = <1600000>; > + }; > + }; > +}; > + > +&usb_hs1_phy { > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l4>; > +}; > + > +&usb1 { > + status = "okay"; > + dr_mode = "otg"; > +}; > +
On 25/05/2023 01:04, Rudraksha Gupta wrote: > This adds a very basic device tree file for the Samsung Galaxy Express > SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and > USB. > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > + > +&usb_hs1_phy { > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l4>; > +}; > + > +&usb1 { > + status = "okay"; > + dr_mode = "otg"; > +}; > + except what was said - drop stray blank line. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 59829fc90315..12c90f263142 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -1081,6 +1081,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ qcom-msm8916-samsung-grandmax.dtb \ qcom-msm8916-samsung-serranove.dtb \ qcom-msm8960-cdp.dtb \ + qcom-msm8960-samsung-expressatt.dtb \ qcom-msm8974-lge-nexus5-hammerhead.dtb \ qcom-msm8974-sony-xperia-rhine-amami.dtb \ qcom-msm8974-sony-xperia-rhine-honami.dtb \ diff --git a/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts new file mode 100644 index 000000000000..2d6f0def0589 --- /dev/null +++ b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts @@ -0,0 +1,334 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <dt-bindings/input/input.h> + +#include "qcom-msm8960.dtsi" +#include <dt-bindings/reset/qcom,gcc-msm8960.h> + +/ { + model = "Samsung Galaxy S3 SGH-I437"; + compatible = "samsung,expressatt", "qcom,msm8960"; + chassis-type = "handset"; + + aliases { + serial0 = &gsbi5_serial; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; +}; + +&gsbi5 { + status = "okay"; + qcom,mode = <GSBI_PROT_I2C_UART>; +}; + +&gsbi5_serial { + status = "okay"; +}; + +/* eMMC */ +&sdcc1 { + status = "okay"; + vmmc-supply = <&pm8921_l5>; +}; + +/* External micro SD card */ +&sdcc3 { + status = "okay"; + vmmc-supply = <&pm8921_l6>; + vqmmc-supply = <&pm8921_l7>; +}; + +&gsbi1 { + status = "okay"; + qcom,mode = <GSBI_PROT_SPI>; + pinctrl-names = "default"; + pinctrl-0 = <&spi1_default>; +}; + +&gsbi1_spi{ + status = "okay"; +}; + +&msmgpio { + spi1_default: spi1_default { + mux { + pins = "gpio6", "gpio7", "gpio9"; + function = "gsbi1"; + }; + + mosi { + pins = "gpio6"; + drive-strength = <12>; + bias-disable; + }; + + miso { + pins = "gpio7"; + drive-strength = <12>; + bias-disable; + }; + + cs { + pins = "gpio8"; + drive-strength = <12>; + bias-disable; + output-low; + }; + + clk { + pins = "gpio9"; + drive-strength = <12>; + bias-disable; + }; + }; +}; + + +&rpm { + regulators { + compatible = "qcom,rpm-pm8921-regulators"; + vin_lvs1_3_6-supply = <&pm8921_s4>; + vin_lvs2-supply = <&pm8921_s4>; + vin_lvs4_5_7-supply = <&pm8921_s4>; + vdd_ncp-supply = <&pm8921_l6>; + vdd_l1_l2_l12_l18-supply = <&pm8921_s4>; + vdd_l21_l23_l29-supply = <&pm8921_s8>; + vdd_l24-supply = <&pm8921_s1>; + vdd_l25-supply = <&pm8921_s1>; + vdd_l27-supply = <&pm8921_s7>; + vdd_l28-supply = <&pm8921_s7>; + + /* Buck SMPS */ + pm8921_s1: s1 { + regulator-always-on; + regulator-min-microvolt = <1225000>; + regulator-max-microvolt = <1225000>; + qcom,switch-mode-frequency = <3200000>; + bias-pull-down; + }; + + pm8921_s2: s2 { + regulator-min-microvolt = <1300000>; + regulator-max-microvolt = <1300000>; + qcom,switch-mode-frequency = <1600000>; + bias-pull-down; + }; + + pm8921_s3: s3 { + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <1150000>; + qcom,switch-mode-frequency = <4800000>; + bias-pull-down; + }; + + pm8921_s4: s4 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + qcom,switch-mode-frequency = <1600000>; + bias-pull-down; + qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>; + }; + + pm8921_s7: s7 { + regulator-min-microvolt = <1150000>; + regulator-max-microvolt = <1150000>; + qcom,switch-mode-frequency = <3200000>; + bias-pull-down; + }; + + pm8921_s8: s8 { + regulator-always-on; + regulator-min-microvolt = <2050000>; + regulator-max-microvolt = <2050000>; + qcom,switch-mode-frequency = <1600000>; + bias-pull-down; + }; + + /* PMOS LDO */ + pm8921_l1: l1 { + regulator-always-on; + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1050000>; + bias-pull-down; + }; + + pm8921_l2: l2 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + bias-pull-down; + }; + + pm8921_l3: l3 { + regulator-min-microvolt = <3075000>; + regulator-max-microvolt = <3300000>; + bias-pull-down; + }; + + pm8921_l4: l4 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + bias-pull-down; + }; + + pm8921_l5: l5 { + regulator-min-microvolt = <2950000>; + regulator-max-microvolt = <2950000>; + bias-pull-down; + }; + + pm8921_l6: l6 { + regulator-min-microvolt = <2950000>; + regulator-max-microvolt = <2950000>; + bias-pull-down; + }; + + pm8921_l7: l7 { + regulator-always-on; + regulator-min-microvolt = <1850000>; + regulator-max-microvolt = <2950000>; + bias-pull-down; + }; + + pm8921_l8: l8 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3100000>; + bias-pull-down; + }; + + pm8921_l9: l9 { + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <2850000>; + bias-pull-down; + }; + + pm8921_l10: l10 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + bias-pull-down; + }; + + pm8921_l11: l11 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <3300000>; + bias-pull-down; + }; + + pm8921_l12: l12 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + bias-pull-down; + }; + + pm8921_l14: l14 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + bias-pull-down; + }; + + pm8921_l15: l15 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + bias-pull-down; + }; + + pm8921_l16: l16 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <3000000>; + bias-pull-down; + }; + + pm8921_l17: l17 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + bias-pull-down; + }; + + pm8921_l18: l18 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1500000>; + bias-pull-down; + }; + + pm8921_l21: l21 { + regulator-min-microvolt = <1900000>; + regulator-max-microvolt = <1900000>; + bias-pull-down; + }; + + pm8921_l22: l22 { + regulator-min-microvolt = <2750000>; + regulator-max-microvolt = <2750000>; + bias-pull-down; + }; + + pm8921_l23: l23 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + bias-pull-down; + }; + + pm8921_l24: l24 { + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <1150000>; + bias-pull-down; + }; + + pm8921_l25: l25 { + regulator-always-on; + regulator-min-microvolt = <1225000>; + regulator-max-microvolt = <1225000>; + bias-pull-down; + }; + + /* Low Voltage Switch */ + pm8921_lvs1: lvs1 { + bias-pull-down; + }; + + pm8921_lvs2: lvs2 { + bias-pull-down; + }; + + pm8921_lvs3: lvs3 { + bias-pull-down; + }; + + pm8921_lvs4: lvs4 { + bias-pull-down; + }; + + pm8921_lvs5: lvs5 { + bias-pull-down; + }; + + pm8921_lvs6: lvs6 { + bias-pull-down; + }; + + pm8921_lvs7: lvs7 { + bias-pull-down; + }; + + pm8921_ncp: ncp { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + qcom,switch-mode-frequency = <1600000>; + }; + }; +}; + +&usb_hs1_phy { + v3p3-supply = <&pm8921_l3>; + v1p8-supply = <&pm8921_l4>; +}; + +&usb1 { + status = "okay"; + dr_mode = "otg"; +}; +
This adds a very basic device tree file for the Samsung Galaxy Express SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and USB. Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + .../dts/qcom-msm8960-samsung-expressatt.dts | 334 ++++++++++++++++++ 2 files changed, 335 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts