mbox series

[0/2] Bluetooth: fix debugfs registration

Message ID 20230424124852.12625-1-johan+linaro@kernel.org (mailing list archive)
Headers show
Series Bluetooth: fix debugfs registration | expand

Message

Johan Hovold April 24, 2023, 12:48 p.m. UTC 
The HCI controller debugfs interface is created during setup or when a
controller is configured, but there is nothing preventing a controller
from being configured multiple times (e.g. by setting the device
address), which results in a host of errors in the logs:

	debugfs: File 'features' in directory 'hci0' already present!
	debugfs: File 'manufacturer' in directory 'hci0' already present!
	debugfs: File 'hci_version' in directory 'hci0' already present!
	...
	debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present!

The Qualcomm driver suffers from a related problem for controllers with
non-persistent setup.

Johan


Johan Hovold (2):
  Bluetooth: fix debugfs registration
  Bluetooth: hci_qca: fix debugfs registration

 drivers/bluetooth/hci_qca.c | 6 +++++-
 include/net/bluetooth/hci.h | 1 +
 net/bluetooth/hci_sync.c    | 3 +++
 3 files changed, 9 insertions(+), 1 deletion(-)

Comments

Johan Hovold May 30, 2023, 2:22 p.m. UTC | #1 
On Mon, Apr 24, 2023 at 02:48:50PM +0200, Johan Hovold wrote:
> The HCI controller debugfs interface is created during setup or when a
> controller is configured, but there is nothing preventing a controller
> from being configured multiple times (e.g. by setting the device
> address), which results in a host of errors in the logs:
> 
> 	debugfs: File 'features' in directory 'hci0' already present!
> 	debugfs: File 'manufacturer' in directory 'hci0' already present!
> 	debugfs: File 'hci_version' in directory 'hci0' already present!
> 	...
> 	debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present!
> 
> The Qualcomm driver suffers from a related problem for controllers with
> non-persistent setup.
>
> 
> Johan Hovold (2):
>   Bluetooth: fix debugfs registration
>   Bluetooth: hci_qca: fix debugfs registration
> 
>  drivers/bluetooth/hci_qca.c | 6 +++++-
>  include/net/bluetooth/hci.h | 1 +
>  net/bluetooth/hci_sync.c    | 3 +++
>  3 files changed, 9 insertions(+), 1 deletion(-)

Are there any more comments to this series or can we can get this merged
for 6.5?

I hope this is not blocked on the bogus checkpatch warning the robot
posted?

Johan