| Message ID | 20230508075859.3326566-5-clg@kaod.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | aspeed: fixes and extensions | expand |
On 8/5/23 09:58, Cédric Le Goater wrote: > Boards will use this new property to identify the device CS line and > wire the SPI controllers accordingly. > > Cc: Alistair Francis <alistair@alistair23.me> > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > include/hw/ssi/ssi.h | 3 +++ > hw/ssi/ssi.c | 7 +++++++ > 2 files changed, 10 insertions(+) > > diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h > index 6950f86810..ffd3a34ba4 100644 > --- a/include/hw/ssi/ssi.h > +++ b/include/hw/ssi/ssi.h > @@ -64,6 +64,9 @@ struct SSIPeripheral { > > /* Chip select state */ > bool cs; > + > + /* Chip select address/index */ > + uint32_t addr; uint8_t is probably enough. Otherwise, Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > };
On 5/30/23 22:33, Philippe Mathieu-Daudé wrote: > On 8/5/23 09:58, Cédric Le Goater wrote: >> Boards will use this new property to identify the device CS line and >> wire the SPI controllers accordingly. >> >> Cc: Alistair Francis <alistair@alistair23.me> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> >> --- >> include/hw/ssi/ssi.h | 3 +++ >> hw/ssi/ssi.c | 7 +++++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h >> index 6950f86810..ffd3a34ba4 100644 >> --- a/include/hw/ssi/ssi.h >> +++ b/include/hw/ssi/ssi.h >> @@ -64,6 +64,9 @@ struct SSIPeripheral { >> /* Chip select state */ >> bool cs; >> + >> + /* Chip select address/index */ >> + uint32_t addr; > > uint8_t is probably enough. Yes. A uint8_t is more than enough. Thanks, C. > > Otherwise, > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > >> }; >
diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h index 6950f86810..ffd3a34ba4 100644 --- a/include/hw/ssi/ssi.h +++ b/include/hw/ssi/ssi.h @@ -64,6 +64,9 @@ struct SSIPeripheral { /* Chip select state */ bool cs; + + /* Chip select address/index */ + uint32_t addr; }; extern const VMStateDescription vmstate_ssi_peripheral; diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c index d54a109bee..9fffe4f27a 100644 --- a/hw/ssi/ssi.c +++ b/hw/ssi/ssi.c @@ -13,6 +13,7 @@ */ #include "qemu/osdep.h" +#include "hw/qdev-properties.h" #include "hw/ssi/ssi.h" #include "migration/vmstate.h" #include "qemu/module.h" @@ -71,6 +72,11 @@ static void ssi_peripheral_realize(DeviceState *dev, Error **errp) ssc->realize(s, errp); } +static Property ssi_peripheral_properties[] = { + DEFINE_PROP_UINT32("addr", SSIPeripheral, addr, 0), + DEFINE_PROP_END_OF_LIST(), +}; + static void ssi_peripheral_class_init(ObjectClass *klass, void *data) { SSIPeripheralClass *ssc = SSI_PERIPHERAL_CLASS(klass); @@ -81,6 +87,7 @@ static void ssi_peripheral_class_init(ObjectClass *klass, void *data) if (!ssc->transfer_raw) { ssc->transfer_raw = ssi_transfer_raw_default; } + device_class_set_props(dc, ssi_peripheral_properties); } static const TypeInfo ssi_peripheral_info = {
Boards will use this new property to identify the device CS line and wire the SPI controllers accordingly. Cc: Alistair Francis <alistair@alistair23.me> Signed-off-by: Cédric Le Goater <clg@kaod.org> --- include/hw/ssi/ssi.h | 3 +++ hw/ssi/ssi.c | 7 +++++++ 2 files changed, 10 insertions(+)