| Message ID | 20230530195132.2286163-3-bero@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add LVTS support for mt8192 | expand |
Il 30/05/23 21:51, Bernhard Rosenkränzer ha scritto: > From: Balsam CHIHI <bchihi@baylibre.com> > > Add suspend and resume support to LVTS driver. > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/thermal/mediatek/lvts_thermal.c | 34 +++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index d0a3f95b7884b..5ea8a9d569ea6 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -1169,6 +1169,38 @@ static int lvts_remove(struct platform_device *pdev) > return 0; > } > > +static int lvts_suspend(struct platform_device *pdev, pm_message_t state) > +{ > + struct lvts_domain *lvts_td; > + int i; > + > + lvts_td = platform_get_drvdata(pdev); > + > + for (i = 0; i < lvts_td->num_lvts_ctrl; i++) > + lvts_ctrl_set_enable(&lvts_td->lvts_ctrl[i], false); > + > + clk_disable_unprepare(lvts_td->clk); > + > + return 0; > +} > + > +static int lvts_resume(struct platform_device *pdev) > +{ > + struct lvts_domain *lvts_td; > + int i, ret; > + > + lvts_td = platform_get_drvdata(pdev); > + > + ret = clk_prepare_enable(lvts_td->clk); > + if (ret) > + return ret; > + > + for (i = 0; i < lvts_td->num_lvts_ctrl; i++) > + lvts_ctrl_set_enable(&lvts_td->lvts_ctrl[i], true); > + > + return 0; > +} > + > static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = { > { > .cal_offset = { 0x04, 0x07 }, > @@ -1268,6 +1300,8 @@ MODULE_DEVICE_TABLE(of, lvts_of_match); > static struct platform_driver lvts_driver = { > .probe = lvts_probe, > .remove = lvts_remove, > + .suspend = lvts_suspend, Should we do that in noirq handlers? We're risking to miss a thermal interrupt. Regards, Angelo > + .resume = lvts_resume, > .driver = { > .name = "mtk-lvts-thermal", > .of_match_table = lvts_of_match,
On 31/05/2023 10:05, AngeloGioacchino Del Regno wrote: [ ... ] >> static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = { >> { >> .cal_offset = { 0x04, 0x07 }, >> @@ -1268,6 +1300,8 @@ MODULE_DEVICE_TABLE(of, lvts_of_match); >> static struct platform_driver lvts_driver = { >> .probe = lvts_probe, >> .remove = lvts_remove, >> + .suspend = lvts_suspend, > > Should we do that in noirq handlers? > We're risking to miss a thermal interrupt. I'm not sure missing a thermal interrupt is a problem in this context but we may go in the irq routine with an undefined state sensor setup (eg. the internal clock stopped in the suspend and then read the sensor in the isr). IMO, using suspend_noirq and resume_noirq may be required here. Alexandre are you taking over the next iteration?
On 23/08/2023 09:48, Daniel Lezcano wrote: > On 31/05/2023 10:05, AngeloGioacchino Del Regno wrote: > > [ ... ] > >>> static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = { >>> { >>> .cal_offset = { 0x04, 0x07 }, >>> @@ -1268,6 +1300,8 @@ MODULE_DEVICE_TABLE(of, lvts_of_match); >>> static struct platform_driver lvts_driver = { >>> .probe = lvts_probe, >>> .remove = lvts_remove, >>> + .suspend = lvts_suspend, >> >> Should we do that in noirq handlers? >> We're risking to miss a thermal interrupt. > > I'm not sure missing a thermal interrupt is a problem in this context > but we may go in the irq routine with an undefined state sensor setup > (eg. the internal clock stopped in the suspend and then read the sensor > in the isr). > > IMO, using suspend_noirq and resume_noirq may be required here. > > Alexandre are you taking over the next iteration? > > Hi Daniel, Sorry I missed your message... I don't think taking over the next iteration, Bernhard should continue. Let me check internally to be sure. As I understood, the next change should be heavy.
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index d0a3f95b7884b..5ea8a9d569ea6 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -1169,6 +1169,38 @@ static int lvts_remove(struct platform_device *pdev) return 0; } +static int lvts_suspend(struct platform_device *pdev, pm_message_t state) +{ + struct lvts_domain *lvts_td; + int i; + + lvts_td = platform_get_drvdata(pdev); + + for (i = 0; i < lvts_td->num_lvts_ctrl; i++) + lvts_ctrl_set_enable(&lvts_td->lvts_ctrl[i], false); + + clk_disable_unprepare(lvts_td->clk); + + return 0; +} + +static int lvts_resume(struct platform_device *pdev) +{ + struct lvts_domain *lvts_td; + int i, ret; + + lvts_td = platform_get_drvdata(pdev); + + ret = clk_prepare_enable(lvts_td->clk); + if (ret) + return ret; + + for (i = 0; i < lvts_td->num_lvts_ctrl; i++) + lvts_ctrl_set_enable(&lvts_td->lvts_ctrl[i], true); + + return 0; +} + static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = { { .cal_offset = { 0x04, 0x07 }, @@ -1268,6 +1300,8 @@ MODULE_DEVICE_TABLE(of, lvts_of_match); static struct platform_driver lvts_driver = { .probe = lvts_probe, .remove = lvts_remove, + .suspend = lvts_suspend, + .resume = lvts_resume, .driver = { .name = "mtk-lvts-thermal", .of_match_table = lvts_of_match,