| Message ID | 20230531075451.47524-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | mlxbf_gige: Add missing check for platform_get_irq | expand |
On Wed, 31 May 2023 15:54:51 +0800 Jiasheng Jiang wrote: > Add the check for the return value of the platform_get_irq and > return error if it fails. > > Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver") You need to CC all the authors of the patch limings@nvidia.com seems to be missing.
diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c index 694de9513b9f..a38e1c68874f 100644 --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c @@ -427,6 +427,10 @@ static int mlxbf_gige_probe(struct platform_device *pdev) priv->error_irq = platform_get_irq(pdev, MLXBF_GIGE_ERROR_INTR_IDX); priv->rx_irq = platform_get_irq(pdev, MLXBF_GIGE_RECEIVE_PKT_INTR_IDX); priv->llu_plu_irq = platform_get_irq(pdev, MLXBF_GIGE_LLU_PLU_INTR_IDX); + if (priv->error_irq < 0 || priv->rx_irq < 0 || priv->llu_plu_irq < 0) { + err = -ENODEV; + goto out; + } phy_irq = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(&pdev->dev), "phy-gpios", 0); if (phy_irq < 0) {
Add the check for the return value of the platform_get_irq and return error if it fails. Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 4 ++++ 1 file changed, 4 insertions(+)