| Message ID | 20230601065805.18079-4-quic_kbajaj@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: qdu1000: add SDHCI | expand |
On 01/06/2023 08:58, Komal Bajaj wrote: > Add required pins for SDHCI, so that the interface can work reliably. > This is not a separate commit. The pin configuration by itself does not make sense and we don't need it. It's part of adding SDHCI, so squash it. Best regards, Krzysztof
On 1.06.2023 08:58, Komal Bajaj wrote: > Add required pins for SDHCI, so that the interface can work reliably. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/qdu1000.dtsi | 50 +++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi > index 6df07334f1d3..9f615f3368c2 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi > +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi > @@ -1147,6 +1147,56 @@ > pins = "gpio31"; > function = "gpio"; > }; > + > + sdc_on_state: sdc-on-state { > + clk-pins { > + pins = "sdc1_clk"; > + drive-strength = <16>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc1_cmd"; > + drive-strength = <10>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "sdc1_data"; > + drive-strength = <10>; > + bias-pull-up; > + }; > + > + rclk-pins { > + pins = "sdc1_rclk"; > + bias-pull-down; > + }; > + }; > + > + sdc_off_state: sdc-off-state { > + clk-pins { > + pins = "sdc1_clk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc1_cmd"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "sdc1_data"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + rclk-pins { > + pins = "sdc1_rclk"; > + bias-pull-down; > + }; > + }; > }; > > apps_smmu: iommu@15000000 { > -- > 2.17.1 >
On 1.06.2023 09:00, Krzysztof Kozlowski wrote: > On 01/06/2023 08:58, Komal Bajaj wrote: >> Add required pins for SDHCI, so that the interface can work reliably. >> > > This is not a separate commit. The pin configuration by itself does not > make sense and we don't need it. It's part of adding SDHCI, so squash it. keep my rb for the squashed patch Konrad > > Best regards, > Krzysztof >
On 6/1/2023 12:30 PM, Krzysztof Kozlowski wrote: > On 01/06/2023 08:58, Komal Bajaj wrote: >> Add required pins for SDHCI, so that the interface can work reliably. >> > This is not a separate commit. The pin configuration by itself does not > make sense and we don't need it. It's part of adding SDHCI, so squash it. Okay, will combine this patch with 2nd in the next patch series. Thanks Komal > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi index 6df07334f1d3..9f615f3368c2 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi @@ -1147,6 +1147,56 @@ pins = "gpio31"; function = "gpio"; }; + + sdc_on_state: sdc-on-state { + clk-pins { + pins = "sdc1_clk"; + drive-strength = <16>; + bias-disable; + }; + + cmd-pins { + pins = "sdc1_cmd"; + drive-strength = <10>; + bias-pull-up; + }; + + data-pins { + pins = "sdc1_data"; + drive-strength = <10>; + bias-pull-up; + }; + + rclk-pins { + pins = "sdc1_rclk"; + bias-pull-down; + }; + }; + + sdc_off_state: sdc-off-state { + clk-pins { + pins = "sdc1_clk"; + drive-strength = <2>; + bias-disable; + }; + + cmd-pins { + pins = "sdc1_cmd"; + drive-strength = <2>; + bias-pull-up; + }; + + data-pins { + pins = "sdc1_data"; + drive-strength = <2>; + bias-pull-up; + }; + + rclk-pins { + pins = "sdc1_rclk"; + bias-pull-down; + }; + }; }; apps_smmu: iommu@15000000 {
Add required pins for SDHCI, so that the interface can work reliably. Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> --- arch/arm64/boot/dts/qcom/qdu1000.dtsi | 50 +++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) -- 2.17.1