diff mbox series

[1/4] libsepol: drop message for uncommon error cases

Message ID 20230512101333.67196-1-cgzones@googlemail.com (mailing list archive)
State Superseded
Delegated to: Petr Lautrbach
Headers show
Series [1/4] libsepol: drop message for uncommon error cases | expand

Commit Message

Christian Göttsche May 12, 2023, 10:13 a.m. UTC 
Match surrounding code and the message were quite generic too.
---
 libsepol/src/kernel_to_conf.c | 2 --
 1 file changed, 2 deletions(-)

Comments

James Carter June 1, 2023, 3:10 p.m. UTC | #1 
These four patches need sign-off lines.
Thanks,
Jim


On Fri, May 12, 2023 at 6:17 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Match surrounding code and the message were quite generic too.
> ---
>  libsepol/src/kernel_to_conf.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/libsepol/src/kernel_to_conf.c b/libsepol/src/kernel_to_conf.c
> index c48a7114..cb7cb740 100644
> --- a/libsepol/src/kernel_to_conf.c
> +++ b/libsepol/src/kernel_to_conf.c
> @@ -2886,7 +2886,6 @@ static int write_xen_pirq_rules_to_conf(FILE *out, struct policydb *pdb)
>         for (pirq = pdb->ocontexts[1]; pirq != NULL; pirq = pirq->next) {
>                 rc = snprintf(pirq_str, 21, "%i", pirq->u.pirq);
>                 if (rc < 0 || rc >= 21) {
> -                       fprintf(stderr,"error1\n");
>                         rc = -1;
>                         goto exit;
>                 }
> @@ -2894,7 +2893,6 @@ static int write_xen_pirq_rules_to_conf(FILE *out, struct policydb *pdb)
>                 ctx = context_to_str(pdb, &pirq->context[0]);
>                 if (!ctx) {
>                         rc = -1;
> -                       fprintf(stderr,"error2\n");
>                         goto exit;
>                 }
>
> --
> 2.40.1
>
diff mbox series

Patch

diff --git a/libsepol/src/kernel_to_conf.c b/libsepol/src/kernel_to_conf.c
index c48a7114..cb7cb740 100644
--- a/libsepol/src/kernel_to_conf.c
+++ b/libsepol/src/kernel_to_conf.c
@@ -2886,7 +2886,6 @@  static int write_xen_pirq_rules_to_conf(FILE *out, struct policydb *pdb)
 	for (pirq = pdb->ocontexts[1]; pirq != NULL; pirq = pirq->next) {
 		rc = snprintf(pirq_str, 21, "%i", pirq->u.pirq);
 		if (rc < 0 || rc >= 21) {
-			fprintf(stderr,"error1\n");
 			rc = -1;
 			goto exit;
 		}
@@ -2894,7 +2893,6 @@  static int write_xen_pirq_rules_to_conf(FILE *out, struct policydb *pdb)
 		ctx = context_to_str(pdb, &pirq->context[0]);
 		if (!ctx) {
 			rc = -1;
-			fprintf(stderr,"error2\n");
 			goto exit;
 		}