| Message ID | 20230602102330.1230734-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] KVM: s390: selftests: Fix spelling mistake "initally" -> "initially" | expand |
On 6/2/23 12:23, Colin Ian King wrote: > There is a spelling mistake in literal string. Fix it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Hey Colin, I'm not a big fan of such fixes since they are most of the time more work for the maintainers than they are worth and accepting one can result in a flood of similar new patches. If this would have been your first ever patch I might have considered picking this but that's not the case. That being said, if one of the other maintainers choose to pick it I won't stand in their way. Cheers, Janosch
On 02/06/2023 12:07, Janosch Frank wrote: > On 6/2/23 12:23, Colin Ian King wrote: >> There is a spelling mistake in literal string. Fix it. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Hey Colin, > > I'm not a big fan of such fixes since they are most of the time more > work for the maintainers than they are worth and accepting one can > result in a flood of similar new patches. If this would have been your > first ever patch I might have considered picking this but that's not the > case. I understand. However, customer facing typos make the kernel look shabby, hence the fix. Colin > > That being said, if one of the other maintainers choose to pick it I > won't stand in their way. > > Cheers, > Janosch
On Fri, Jun 02, 2023 at 01:07:45PM +0200, Janosch Frank wrote: > On 6/2/23 12:23, Colin Ian King wrote: > > There is a spelling mistake in literal string. Fix it. > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Hey Colin, > > I'm not a big fan of such fixes since they are most of the time more work > for the maintainers than they are worth and accepting one can result in a > flood of similar new patches. If this would have been your first ever patch > I might have considered picking this but that's not the case. > > That being said, if one of the other maintainers choose to pick it I won't > stand in their way. I kind of get dread when people ask me to fix a typo in my commit message. The drudgery of Sort by thread, Up arrow to the patch, Hit e, Fix the typo, Add the v2 to the subject, The little note under the --- cut off, and Hit send. FML, right? So I sympathize about not caring about spelling. But this is a user visible string. Kind of. It's testing code... You should improve your process so it's easier to apply patches. For me, I type "i" to review this patch in context. Then "ESC:q" to leave vim. Then "ap" to apply the patch. It's six key strokes. Anything more than 10 key strokes to review and apply a patch is not Web Scale. regards, dan carpenter
diff --git a/tools/testing/selftests/kvm/s390x/cmma_test.c b/tools/testing/selftests/kvm/s390x/cmma_test.c index 6d0751ea224b..576fe8ee0aec 100644 --- a/tools/testing/selftests/kvm/s390x/cmma_test.c +++ b/tools/testing/selftests/kvm/s390x/cmma_test.c @@ -656,7 +656,7 @@ struct testdef { } testlist[] = { { "migration mode and dirty tracking", test_migration_mode }, { "GET_CMMA_BITS: basic calls", test_get_cmma_basic }, - { "GET_CMMA_BITS: all pages are dirty initally", test_get_inital_dirty }, + { "GET_CMMA_BITS: all pages are dirty initially", test_get_inital_dirty }, { "GET_CMMA_BITS: holes are skipped", test_get_skip_holes }, };
There is a spelling mistake in literal string. Fix it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- tools/testing/selftests/kvm/s390x/cmma_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)