| Message ID | 20230602013358.900637-2-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9a61100e686eaa2229343505f0183f8ea790d120 |
| Headers | show |
| Series | A minor flurry of selftest/mm fixes | expand |
On 02.06.23 03:33, John Hubbard wrote: > uffd_minor_feature() was unused. Remove it in order to fix the > associated clang build warning. > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> > --- > tools/testing/selftests/mm/uffd-stress.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c > index f1ad9eef1c3a..995ff13e74c7 100644 > --- a/tools/testing/selftests/mm/uffd-stress.c > +++ b/tools/testing/selftests/mm/uffd-stress.c > @@ -88,16 +88,6 @@ static void uffd_stats_reset(struct uffd_args *args, unsigned long n_cpus) > } > } > > -static inline uint64_t uffd_minor_feature(void) > -{ > - if (test_type == TEST_HUGETLB && map_shared) > - return UFFD_FEATURE_MINOR_HUGETLBFS; > - else if (test_type == TEST_SHMEM) > - return UFFD_FEATURE_MINOR_SHMEM; > - else > - return 0; > -} > - > static void *locking_thread(void *arg) > { > unsigned long cpu = (unsigned long) arg; Reviewed-by: David Hildenbrand <david@redhat.com>
On Thu, Jun 01, 2023 at 06:33:47PM -0700, John Hubbard wrote: > uffd_minor_feature() was unused. Remove it in order to fix the > associated clang build warning. > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: Peter Xu <peterx@redhat.com>
diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index f1ad9eef1c3a..995ff13e74c7 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -88,16 +88,6 @@ static void uffd_stats_reset(struct uffd_args *args, unsigned long n_cpus) } } -static inline uint64_t uffd_minor_feature(void) -{ - if (test_type == TEST_HUGETLB && map_shared) - return UFFD_FEATURE_MINOR_HUGETLBFS; - else if (test_type == TEST_SHMEM) - return UFFD_FEATURE_MINOR_SHMEM; - else - return 0; -} - static void *locking_thread(void *arg) { unsigned long cpu = (unsigned long) arg;
uffd_minor_feature() was unused. Remove it in order to fix the associated clang build warning. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- tools/testing/selftests/mm/uffd-stress.c | 10 ---------- 1 file changed, 10 deletions(-)