diff mbox series

[v2,3/5] dt-bindings: hwmon: hpe,gxp-fanctrl: remove fn2 and pl regs

Message ID 20230531151918.105223-4-nick.hawkins@hpe.com (mailing list archive)
State Superseded
Headers show
Series ARM: Add GPIO support | expand

Commit Message

Hawkins, Nick May 31, 2023, 3:19 p.m. UTC 
From: Nick Hawkins <nick.hawkins@hpe.com>

Remove the fn2 register and pl register references as these memory areas
are now consumed by the GXP GPIO driver. The fan driver now gathers fan
information from GPIO driver.

Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>

---

v2:
 *Added more detailed subject and patch description
---
 .../bindings/hwmon/hpe,gxp-fan-ctrl.yaml         | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

Comments

Krzysztof Kozlowski June 1, 2023, 6:53 a.m. UTC | #1 
On 31/05/2023 17:19, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> Remove the fn2 register and pl register references as these memory areas
> are now consumed by the GXP GPIO driver. The fan driver now gathers fan
> information from GPIO driver.

How is it expressed in bindings? I don't see it.

> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> 
> ---


Best regards,
Krzysztof
Hawkins, Nick June 5, 2023, 4:52 p.m. UTC | #2 
> > Remove the fn2 register and pl register references as these memory areas
> > are now consumed by the GXP GPIO driver. The fan driver now gathers fan
> > information from GPIO driver.

> How is it expressed in bindings? I don't see it.

Greetings Krzysztof,

Thanks for the feedback. Just to confirm: Is this comment referring to the
content of the patch description? For the third version I want to make sure
I address your concern.

In the third version I will be modifying the description once more as I will
no longer retrieve data from the GPIO driver. Here is the new attempt:

dt-bindings: hwmon: hpe,gxp-fan-ctrl: remove fn2 and pl register references

Reduce the hpe,gxp-fan-ctrl register references from 3 to 1. The function2
(fn2) and programmable logic (pl) references are removed. The purpose
of removal being their functionality will be consumed by a new GPIO
driver.

Thank you for the assistance,

-Nick Hawkins
Krzysztof Kozlowski June 6, 2023, 6:22 a.m. UTC | #3 
On 05/06/2023 18:52, Hawkins, Nick wrote:
>>> Remove the fn2 register and pl register references as these memory areas
>>> are now consumed by the GXP GPIO driver. The fan driver now gathers fan
>>> information from GPIO driver.
> 
>> How is it expressed in bindings? I don't see it.
> 
> Greetings Krzysztof,
> 
> Thanks for the feedback. Just to confirm: Is this comment referring to the
> content of the patch description? For the third version I want to make sure
> I address your concern.

The concern was that one of your drivers have clear dependency on other.
How do you solve probe ordering and dependency?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
index 4a52aac6be72..963aa640dc05 100644
--- a/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
+++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
@@ -18,21 +18,12 @@  properties:
     const: hpe,gxp-fan-ctrl
 
   reg:
-    items:
-      - description: Fan controller PWM
-      - description: Programmable logic
-      - description: Function 2
-
-  reg-names:
-    items:
-      - const: base
-      - const: pl
-      - const: fn2
+    description: Fan controller PWM
+    maxItems: 1
 
 required:
   - compatible
   - reg
-  - reg-names
 
 additionalProperties: false
 
@@ -40,6 +31,5 @@  examples:
   - |
     fan-controller@1000c00 {
       compatible = "hpe,gxp-fan-ctrl";
-      reg = <0x1000c00 0x200>, <0xd1000000 0xff>, <0x80200000 0x100000>;
-      reg-names = "base", "pl", "fn2";
+      reg = <0x1000c00 0x200>;
     };