| Message ID | 20230605144812.15241-19-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fbdev: Make userspace interfaces optional | expand |
On Mon, Jun 05, 2023 at 04:48:00PM +0200, Thomas Zimmermann wrote: > Use the hardware device in struct fb_info.device as parent of the > backlight device. Aligns the driver with the rest of the codebase > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Benjamin Herrenschmidt <benh@kernel.crashing.org> You left out the Cc: regards, dan carpenter
Hi Am 06.06.23 um 07:28 schrieb Dan Carpenter: > On Mon, Jun 05, 2023 at 04:48:00PM +0200, Thomas Zimmermann wrote: >> Use the hardware device in struct fb_info.device as parent of the >> backlight device. Aligns the driver with the rest of the codebase >> and prepares fbdev for making struct fb_info.dev optional. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Benjamin Herrenschmidt <benh@kernel.crashing.org> > > You left out the Cc: Indeed, thanks for reviewing. However I don't remember that checkpatch warned about it. It's my impression that it should have. :/ Best regards > > regards, > dan carpenter >
Thomas Zimmermann <tzimmermann@suse.de> writes: > Use the hardware device in struct fb_info.device as parent of the > backlight device. Aligns the driver with the rest of the codebase > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/drivers/video/fbdev/aty/radeon_backlight.c b/drivers/video/fbdev/aty/radeon_backlight.c index 427adc838f77..23a38c3f3977 100644 --- a/drivers/video/fbdev/aty/radeon_backlight.c +++ b/drivers/video/fbdev/aty/radeon_backlight.c @@ -147,7 +147,7 @@ void radeonfb_bl_init(struct radeonfb_info *rinfo) memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; props.max_brightness = FB_BACKLIGHT_LEVELS - 1; - bd = backlight_device_register(name, rinfo->info->dev, pdata, + bd = backlight_device_register(name, rinfo->info->device, pdata, &radeon_bl_data, &props); if (IS_ERR(bd)) { rinfo->info->bl_dev = NULL;
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Benjamin Herrenschmidt <benh@kernel.crashing.org> --- drivers/video/fbdev/aty/radeon_backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)