| Message ID | 20230606071637.267103-8-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 97deb66ed4f9390fd585210fe6d72088000d9110 |
| Headers | show |
| Series | A minor flurry of selftest/mm fixes | expand |
On 6/6/23 12:16 PM, John Hubbard wrote: > This fixes a real bug, too, because xstate_size() was assuming that > the stack variable xstate_size was initialized to zero. That's not > guaranteed nor even especially likely. > > Reviewed-by: David Hildenbrand <david@redhat.com> > Cc: Peter Xu <peterx@redhat.com> > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/mm/pkey-x86.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftests/mm/pkey-x86.h > index 72c14cd3ddc7..e32ae8a1cd99 100644 > --- a/tools/testing/selftests/mm/pkey-x86.h > +++ b/tools/testing/selftests/mm/pkey-x86.h > @@ -132,7 +132,7 @@ int pkey_reg_xstate_offset(void) > unsigned int ecx; > unsigned int edx; > int xstate_offset; > - int xstate_size; > + int xstate_size = 0; > unsigned long XSTATE_CPUID = 0xd; > int leaf; >
diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftests/mm/pkey-x86.h index 72c14cd3ddc7..e32ae8a1cd99 100644 --- a/tools/testing/selftests/mm/pkey-x86.h +++ b/tools/testing/selftests/mm/pkey-x86.h @@ -132,7 +132,7 @@ int pkey_reg_xstate_offset(void) unsigned int ecx; unsigned int edx; int xstate_offset; - int xstate_size; + int xstate_size = 0; unsigned long XSTATE_CPUID = 0xd; int leaf;