[v2,0/9] pktdvd: Clean up the driver

Message

Andy Shevchenko March 10, 2023, 4:45 p.m. UTC

Some cleanups to the recently resurrected driver.

v2:
- added tags (Greg)

Andy Shevchenko (9):
  pktcdvd: Get rid of custom printing macros
  pktcdvd: replace sscanf() by kstrtoul()
  pktcdvd: use sysfs_emit() to instead of scnprintf()
  pktcdvd: Get rid of pkt_seq_show() forward declaration
  pktcdvd: Drop redundant castings for sector_t
  pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code
  pktcdvd: Use put_unaligned_be16() and get_unaligned_be16()
  pktcdvd: Get rid of redundant 'else'
  pktcdvd: Sort headers

 drivers/block/pktcdvd.c      | 525 +++++++++++++++++------------------
 include/linux/pktcdvd.h      |   1 -
 include/uapi/linux/pktcdvd.h |   1 +
 3 files changed, 257 insertions(+), 270 deletions(-)

Comments

Andy Shevchenko June 6, 2023, 2:58 p.m. UTC | #1

On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote:
> Some cleanups to the recently resurrected driver.

Anybody to pick this up, please?

> v2:
> - added tags (Greg)
> 
> Andy Shevchenko (9):
>   pktcdvd: Get rid of custom printing macros
>   pktcdvd: replace sscanf() by kstrtoul()
>   pktcdvd: use sysfs_emit() to instead of scnprintf()
>   pktcdvd: Get rid of pkt_seq_show() forward declaration
>   pktcdvd: Drop redundant castings for sector_t
>   pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code
>   pktcdvd: Use put_unaligned_be16() and get_unaligned_be16()
>   pktcdvd: Get rid of redundant 'else'
>   pktcdvd: Sort headers
> 
>  drivers/block/pktcdvd.c      | 525 +++++++++++++++++------------------
>  include/linux/pktcdvd.h      |   1 -
>  include/uapi/linux/pktcdvd.h |   1 +
>  3 files changed, 257 insertions(+), 270 deletions(-)
> 
> -- 
> 2.39.1
>

Jens Axboe June 6, 2023, 8:23 p.m. UTC | #2

On 6/6/23 8:58 AM, Andy Shevchenko wrote:
> On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote:
>> Some cleanups to the recently resurrected driver.
> 
> Anybody to pick this up, please?

I can pick it up, I'm assuming this is all untested?

Andy Shevchenko June 7, 2023, 8:08 p.m. UTC | #3

On Tue, Jun 06, 2023 at 02:23:03PM -0600, Jens Axboe wrote:
> On 6/6/23 8:58 AM, Andy Shevchenko wrote:
> > On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote:
> >> Some cleanups to the recently resurrected driver.
> > 
> > Anybody to pick this up, please?
> 
> I can pick it up, I'm assuming this is all untested?

Compile tested only. So I assume the answer is yes, untested.

Jens Axboe June 7, 2023, 8:21 p.m. UTC | #4

On 6/7/23 2:08 PM, Andy Shevchenko wrote:
> On Tue, Jun 06, 2023 at 02:23:03PM -0600, Jens Axboe wrote:
>> On 6/6/23 8:58 AM, Andy Shevchenko wrote:
>>> On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote:
>>>> Some cleanups to the recently resurrected driver.
>>>
>>> Anybody to pick this up, please?
>>
>> I can pick it up, I'm assuming this is all untested?
> 
> Compile tested only. So I assume the answer is yes, untested.

I'd be surprised if you said you actually ran it. Series looks sane,
I'll get it applied. Thanks.

Jens Axboe June 7, 2023, 8:28 p.m. UTC | #5

On Fri, 10 Mar 2023 18:45:40 +0200, Andy Shevchenko wrote:
> Some cleanups to the recently resurrected driver.
> 
> v2:
> - added tags (Greg)
> 
> Andy Shevchenko (9):
>   pktcdvd: Get rid of custom printing macros
>   pktcdvd: replace sscanf() by kstrtoul()
>   pktcdvd: use sysfs_emit() to instead of scnprintf()
>   pktcdvd: Get rid of pkt_seq_show() forward declaration
>   pktcdvd: Drop redundant castings for sector_t
>   pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code
>   pktcdvd: Use put_unaligned_be16() and get_unaligned_be16()
>   pktcdvd: Get rid of redundant 'else'
>   pktcdvd: Sort headers
> 
> [...]

Applied, thanks!

[1/9] pktcdvd: Get rid of custom printing macros
      commit: 3a41db531e5124adaa3a9ab9ca0c724aee85b10c
[2/9] pktcdvd: replace sscanf() by kstrtoul()
      commit: 1a0ddd56e545b743af510b5a1b8dbdfe7d35cd3b
[3/9] pktcdvd: use sysfs_emit() to instead of scnprintf()
      commit: 3bb5746c26cdfcc354af4867c02f1e0ec1131a62
[4/9] pktcdvd: Get rid of pkt_seq_show() forward declaration
      commit: f023faaa988671f0f1d1a965dc5d7e61d0f5e65e
[5/9] pktcdvd: Drop redundant castings for sector_t
      commit: 93c8f6f38be67e30adf8d8eb5e7e9ccb89326119
[6/9] pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code
      commit: 80d994d2a71f88e0809dcaccef2259c791d2e3ef
[7/9] pktcdvd: Use put_unaligned_be16() and get_unaligned_be16()
      commit: 046636a4bac575aff78e44c7e1cff84c83a345a9
[8/9] pktcdvd: Get rid of redundant 'else'
      commit: 6a5945a8eb5a626afe6feb341824e7e1d007c8ff
[9/9] pktcdvd: Sort headers
      commit: 7da15fb0318f18398feea2848d099a8d0d7b5965

Best regards,