mbox series

[v4,00/20] Permission Indirection Extension

Message ID 20230606145859.697944-1-joey.gouly@arm.com (mailing list archive)
Headers show
Series Permission Indirection Extension | expand

Message

Joey Gouly June 6, 2023, 2:58 p.m. UTC 
Hi all,

This series implements the Permission Indirection Extension introduced in 2022
VMSA enhancements [1].

Changes since v3 [2]:
	- Rebased onto for-next/feat_mops
	- Enabled TCR2 in new HCRX_HOST_FLAGS/HCRX_GUEST_FLAGS
	- Use ARM64_CPUID_FIELDS in cpufeature.c
	- Add Marc Z's R-b tags

The Permission Indirection Extension is a new way to set memory permissions.
Instead of directly encoding the permission in the Page Table Entry (PTE),
fields in the PTEs are used to index into an array of permissions specified in
a register. This indirection provides greater flexibility, greater encoding
density and enables the representation of new permissions.

The PTEs bit that are repurposed for use with permission indirection are:
	54 PTE_UXN
	53 PTE_PXN
	51 PTE_DBM
	6 PTE_USER

The way that PIE is implemented in this patchset is that the encodings are
picked such that they match how Linux currently sets the bits in the PTEs, so
none of the page table handling has changed. This means this patchset keeps the
same functionality as currently implemented, but allows for future expansion.

Enabling PIE is also a prerequisite for implementing the Guarded Control Stack
Extension (GCS).

Another related extension is the Permission Overlay Extension, which is not
covered by this patch set, but is mentioned in patch 5 as half of PIE encoding
values apply an overlay. However, since overlays are not currently enabled, they
act as all the other permissions do.

This first few patches are adding the new system registers, and cpufeature
capabilities. Then KVM support for save/restore of the new registers is added.
Finally the new Permission Indirection registers are set and the new feature is
enabled.

Thanks,
Joey

[1] https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/arm-a-profile-architecture-2022
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2023-May/833014.html

Joey Gouly (20):
  arm64/sysreg: Add ID register ID_AA64MMFR3
  arm64/sysreg: add system registers TCR2_ELx
  arm64/sysreg: update HCRX_EL2 register
  arm64/sysreg: add PIR*_ELx registers
  arm64: cpufeature: add system register ID_AA64MMFR3
  arm64: cpufeature: add TCR2 cpucap
  arm64: cpufeature: add Permission Indirection Extension cpucap
  KVM: arm64: Save/restore TCR2_EL1
  KVM: arm64: Save/restore PIE registers
  KVM: arm64: expose ID_AA64MMFR3_EL1 to guests
  arm64: add PTE_UXN/PTE_WRITE to SWAPPER_*_FLAGS
  arm64: add PTE_WRITE to PROT_SECT_NORMAL
  arm64: reorganise PAGE_/PROT_ macros
  arm64: disable EL2 traps for PIE
  arm64: add encodings of PIRx_ELx registers
  arm64: enable Permission Indirection Extension (PIE)
  arm64: transfer permission indirection settings to EL2
  arm64: Document boot requirements for PIE
  KVM: selftests: get-reg-list: support ID register features
  KVM: selftests: get-reg-list: add Permission Indirection registers

 Documentation/arm64/booting.rst               |  26 +++
 arch/arm64/include/asm/cpu.h                  |   1 +
 arch/arm64/include/asm/el2_setup.h            |  11 +-
 arch/arm64/include/asm/kernel-pgtable.h       |   8 +-
 arch/arm64/include/asm/kvm_arm.h              |   4 +-
 arch/arm64/include/asm/kvm_host.h             |   5 +
 arch/arm64/include/asm/pgtable-hwdef.h        |   8 +
 arch/arm64/include/asm/pgtable-prot.h         | 122 ++++++++++---
 arch/arm64/include/asm/sysreg.h               |  19 ++
 arch/arm64/kernel/cpufeature.c                |  24 +++
 arch/arm64/kernel/cpuinfo.c                   |   1 +
 arch/arm64/kernel/head.S                      |   8 +-
 arch/arm64/kernel/hyp-stub.S                  |  18 ++
 arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h    |  12 ++
 arch/arm64/kvm/sys_regs.c                     |   5 +-
 arch/arm64/mm/proc.S                          |  19 +-
 arch/arm64/tools/cpucaps                      |   2 +
 arch/arm64/tools/sysreg                       | 165 +++++++++++++++++-
 .../selftests/kvm/aarch64/get-reg-list.c      |  53 +++++-
 19 files changed, 467 insertions(+), 44 deletions(-)

Comments

Catalin Marinas June 6, 2023, 5:29 p.m. UTC | #1 
On Tue, 06 Jun 2023 15:58:39 +0100, Joey Gouly wrote:
> This series implements the Permission Indirection Extension introduced in 2022
> VMSA enhancements [1].
> 
> Changes since v3 [2]:
> 	- Rebased onto for-next/feat_mops
> 	- Enabled TCR2 in new HCRX_HOST_FLAGS/HCRX_GUEST_FLAGS
> 	- Use ARM64_CPUID_FIELDS in cpufeature.c
> 	- Add Marc Z's R-b tags
> 
> [...]

Applied to arm64 (for-next/feat_s1pie), thanks!

[01/20] arm64/sysreg: Add ID register ID_AA64MMFR3
        https://git.kernel.org/arm64/c/00ac84677d87
[02/20] arm64/sysreg: add system registers TCR2_ELx
        https://git.kernel.org/arm64/c/89b6c3ee4988
[03/20] arm64/sysreg: update HCRX_EL2 register
        https://git.kernel.org/arm64/c/25bc6f32cd71
[04/20] arm64/sysreg: add PIR*_ELx registers
        https://git.kernel.org/arm64/c/c36ad1943f94
[05/20] arm64: cpufeature: add system register ID_AA64MMFR3
        https://git.kernel.org/arm64/c/edc25898f0b6
[06/20] arm64: cpufeature: add TCR2 cpucap
        https://git.kernel.org/arm64/c/2b760046a2d3
[07/20] arm64: cpufeature: add Permission Indirection Extension cpucap
        https://git.kernel.org/arm64/c/e43454c44232
[08/20] KVM: arm64: Save/restore TCR2_EL1
        https://git.kernel.org/arm64/c/fbff56068232
[09/20] KVM: arm64: Save/restore PIE registers
        https://git.kernel.org/arm64/c/86f9de9db178
[10/20] KVM: arm64: expose ID_AA64MMFR3_EL1 to guests
        https://git.kernel.org/arm64/c/8ef67c67e637
[11/20] arm64: add PTE_UXN/PTE_WRITE to SWAPPER_*_FLAGS
        https://git.kernel.org/arm64/c/f0af339fc408
[12/20] arm64: add PTE_WRITE to PROT_SECT_NORMAL
        https://git.kernel.org/arm64/c/7c302cfbee1f
[13/20] arm64: reorganise PAGE_/PROT_ macros
        https://git.kernel.org/arm64/c/fa4cdccaa582
[14/20] arm64: disable EL2 traps for PIE
        https://git.kernel.org/arm64/c/7df7170965a2
[15/20] arm64: add encodings of PIRx_ELx registers
        https://git.kernel.org/arm64/c/eeda243dfeb9
[16/20] arm64: enable Permission Indirection Extension (PIE)
        https://git.kernel.org/arm64/c/9e9bb6ede00a
[17/20] arm64: transfer permission indirection settings to EL2
        https://git.kernel.org/arm64/c/6b776d385562
[18/20] arm64: Document boot requirements for PIE
        https://git.kernel.org/arm64/c/6c792b7d3c2c
[19/20] KVM: selftests: get-reg-list: support ID register features
        https://git.kernel.org/arm64/c/ee053e03b08e
[20/20] KVM: selftests: get-reg-list: add Permission Indirection registers
        https://git.kernel.org/arm64/c/5f0419a0083b