diff mbox series

[XEN,v7,05/19] xen/arm: Add CONFIG_OVERLAY_DTB

Message ID 20230602004824.20731-6-vikram.garhwal@amd.com (mailing list archive)
State New, archived
Headers show
Series dynamic node programming using overlay dtbo | expand

Commit Message

Vikram Garhwal June 2, 2023, 12:48 a.m. UTC
Introduce a config option where the user can enable support for adding/removing
device tree nodes using a device tree binary overlay.

Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for
Arm.

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

---
Changes from v6:
    Add CHANGELOG and SUPPORT.md entries.
---
 CHANGELOG.md         | 2 ++
 SUPPORT.md           | 6 ++++++
 xen/arch/arm/Kconfig | 5 +++++
 3 files changed, 13 insertions(+)

Comments

Henry Wang June 2, 2023, 1:43 a.m. UTC | #1
Hi Vikram,

> -----Original Message-----
> Subject: [XEN][PATCH v7 05/19] xen/arm: Add CONFIG_OVERLAY_DTB
> 
> Introduce a config option where the user can enable support for
> adding/removing
> device tree nodes using a device tree binary overlay.
> 
> Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays
> support for
> Arm.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Acked-by: Henry Wang <Henry.Wang@arm.com> # CHANGELOG

Kind regards,
Henry
Michal Orzel June 2, 2023, 7:16 a.m. UTC | #2
On 02/06/2023 02:48, Vikram Garhwal wrote:
> Introduce a config option where the user can enable support for adding/removing
> device tree nodes using a device tree binary overlay.
> 
> Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for
> Arm.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal
Jan Beulich June 2, 2023, 9:06 a.m. UTC | #3
On 02.06.2023 02:48, Vikram Garhwal wrote:
> Introduce a config option where the user can enable support for adding/removing
> device tree nodes using a device tree binary overlay.
> 
> Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for
> Arm.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> 
> ---
> Changes from v6:
>     Add CHANGELOG and SUPPORT.md entries.
> ---
>  CHANGELOG.md         | 2 ++
>  SUPPORT.md           | 6 ++++++
>  xen/arch/arm/Kconfig | 5 +++++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 5bfd3aa5c0..a137fce576 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -20,6 +20,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>     - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system
>       wide impact of a guest misusing atomic instructions.
>   - xl/libxl can customize SMBIOS strings for HVM guests.
> + - On Arm, support for dynamic addition/removal of Xen device tree nodes using
> +   a device tree overlay binary(.dtbo).

May I suggest "..., experimental support ..." here?

Jan
Henry Wang June 2, 2023, 9:22 a.m. UTC | #4
Hi Jan and Vikram,

> -----Original Message-----
> Subject: Re: [XEN][PATCH v7 05/19] xen/arm: Add CONFIG_OVERLAY_DTB
> 
> > diff --git a/CHANGELOG.md b/CHANGELOG.md
> > index 5bfd3aa5c0..a137fce576 100644
> > --- a/CHANGELOG.md
> > +++ b/CHANGELOG.md
> > @@ -20,6 +20,8 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> >     - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system
> >       wide impact of a guest misusing atomic instructions.
> >   - xl/libxl can customize SMBIOS strings for HVM guests.
> > + - On Arm, support for dynamic addition/removal of Xen device tree nodes
> using
> > +   a device tree overlay binary(.dtbo).
> 
> May I suggest "..., experimental support ..." here?

Great point! I agree using "experimental support" is better here.

@Vikram: Just to be clear, if you agree and change the wording following Jan's
suggestion, you can keep my acked-by tag for the changelog :))

Kind regards,
Henry

> 
> Jan
Vikram Garhwal June 6, 2023, 7:11 p.m. UTC | #5
Thanks, will update the Changelog.md with Jan's suggestions.

On 6/2/23 2:22 AM, Henry Wang wrote:
> Hi Jan and Vikram,
>
>> -----Original Message-----
>> Subject: Re: [XEN][PATCH v7 05/19] xen/arm: Add CONFIG_OVERLAY_DTB
>>
>>> diff --git a/CHANGELOG.md b/CHANGELOG.md
>>> index 5bfd3aa5c0..a137fce576 100644
>>> --- a/CHANGELOG.md
>>> +++ b/CHANGELOG.md
>>> @@ -20,6 +20,8 @@ The format is based on [Keep a
>> Changelog](https://keepachangelog.com/en/1.0.0/)
>>>      - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system
>>>        wide impact of a guest misusing atomic instructions.
>>>    - xl/libxl can customize SMBIOS strings for HVM guests.
>>> + - On Arm, support for dynamic addition/removal of Xen device tree nodes
>> using
>>> +   a device tree overlay binary(.dtbo).
>> May I suggest "..., experimental support ..." here?
> Great point! I agree using "experimental support" is better here.
>
> @Vikram: Just to be clear, if you agree and change the wording following Jan's
> suggestion, you can keep my acked-by tag for the changelog :))
>
> Kind regards,
> Henry
>
>> Jan
diff mbox series

Patch

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5bfd3aa5c0..a137fce576 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,8 @@  The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
    - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the system
      wide impact of a guest misusing atomic instructions.
  - xl/libxl can customize SMBIOS strings for HVM guests.
+ - On Arm, support for dynamic addition/removal of Xen device tree nodes using
+   a device tree overlay binary(.dtbo).
 
 ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-12
 
diff --git a/SUPPORT.md b/SUPPORT.md
index 6dbed9d5d0..6b27d43cc6 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -832,6 +832,12 @@  No support for QEMU backends in a 16K or 64K domain.
 
     Status: Supported
 
+### Device Tree Overlays
+
+Add/Remove device tree nodes using a device tree overlay binary(.dtbo).
+
+    Status, ARM: Experimental
+
 ### ARM: Guest ACPI support
 
     Status: Supported
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 239d3aed3c..1fe3d698a5 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -53,6 +53,11 @@  config HAS_ITS
         bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
         depends on GICV3 && !NEW_VGIC && !ARM_32
 
+config OVERLAY_DTB
+	bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED
+	help
+	  Dynamic addition/removal of Xen device tree nodes using a dtbo.
+
 config HVM
         def_bool y