| Message ID | 20230606120824.4705-1-nitin.jadhav@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Code handling for VOCS service | expand |
Hi Nitin, On Tue, Jun 6, 2023 at 5:09 AM NJNXP <nitin.jadhav@nxp.com> wrote: > > Hello Maintainers > > This patch series handles code implementation for mandatory features of > Volume Offset Control Service. > > Implementation of following features have been handled in this patch > series > - Volume Offset Control Service > - Volume Offset State Characteristic (Read, Notify) > - Audio Location Characteristic (Read) > - Volume Offset Control Point Characteristic (Write) > - Audio Output Description Characteristic (Read) > - Set Volume Offset > > All the code implementation has been tested using PTS testing the > verdict is PASS for all mandatory test cases. Great, though at this stage I think it would be even more important to have a unit tester for the bt_vcp instance, just as we do have for bt_bap and bt_bass in unit/test-bap.c and unit/test-bass.c respectively, this would help us making sure there are no memory issues and avoid introducing regressions going forward. > Thank you in advance for your review. > > Warm Regards > Nitin Jadhav > > NJNXP (2): > Added initial code for handling VOCS > Fixed the following issue observed during PTS testing for mandatory > test cases - Specified Upper and Lower Limit for Volume offset - > Corrected the number of handles for VOCS - VOCS is made as included > service of VCS because VOCS is secondary service and VSC is primary > service > > lib/uuid.h | 5 + > src/shared/vcp.c | 547 ++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 550 insertions(+), 2 deletions(-) > > -- > 2.34.1 >
Hello Luiz, Thanks for the message. As per your suggestion we will check on implementing of unit tester for the bt_vcp and raise a separate patch for it. Right now we are able to fix the other review comments for VOCS mentioned in v1*.patch. Please help to review process ahead. Thanks, Warm Regards, Nitin Jadhav > -----Original Message----- > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > Sent: Wednesday, June 7, 2023 4:44 AM > To: Nitin Jadhav <nitin.jadhav@nxp.com> > Cc: linux-bluetooth@vger.kernel.org; Devyani Godbole > <devyani.godbole@nxp.com>; Mihai-Octavian Urzica <mihai- > octavian.urzica@nxp.com>; Silviu Florian Barbulescu > <silviu.barbulescu@nxp.com> > Subject: [EXT] Re: [PATCH BlueZ v1 0/2] Code handling for VOCS service > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > Hi Nitin, > > On Tue, Jun 6, 2023 at 5:09 AM NJNXP <nitin.jadhav@nxp.com> wrote: > > > > Hello Maintainers > > > > This patch series handles code implementation for mandatory features > > of Volume Offset Control Service. > > > > Implementation of following features have been handled in this patch > > series > > - Volume Offset Control Service > > - Volume Offset State Characteristic (Read, Notify) > > - Audio Location Characteristic (Read) > > - Volume Offset Control Point Characteristic (Write) > > - Audio Output Description Characteristic (Read) > > - Set Volume Offset > > > > All the code implementation has been tested using PTS testing the > > verdict is PASS for all mandatory test cases. > > Great, though at this stage I think it would be even more important to have a > unit tester for the bt_vcp instance, just as we do have for bt_bap and bt_bass > in unit/test-bap.c and unit/test-bass.c respectively, this would help us > making sure there are no memory issues and avoid introducing regressions > going forward. > > > Thank you in advance for your review. > > > > Warm Regards > > Nitin Jadhav > > > > NJNXP (2): > > Added initial code for handling VOCS > > Fixed the following issue observed during PTS testing for mandatory > > test cases - Specified Upper and Lower Limit for Volume offset - > > Corrected the number of handles for VOCS - VOCS is made as included > > service of VCS because VOCS is secondary service and VSC is primary > > service > > > > lib/uuid.h | 5 + > > src/shared/vcp.c | 547 > > ++++++++++++++++++++++++++++++++++++++++++++++- > > 2 files changed, 550 insertions(+), 2 deletions(-) > > > > -- > > 2.34.1 > > > > > -- > Luiz Augusto von Dentz
Hello Maintainers This patch series handles code implementation for mandatory features of Volume Offset Control Service. Implementation of following features have been handled in this patch series - Volume Offset Control Service - Volume Offset State Characteristic (Read, Notify) - Audio Location Characteristic (Read) - Volume Offset Control Point Characteristic (Write) - Audio Output Description Characteristic (Read) - Set Volume Offset All the code implementation has been tested using PTS testing the verdict is PASS for all mandatory test cases. Thank you in advance for your review. Warm Regards Nitin Jadhav NJNXP (2): Added initial code for handling VOCS Fixed the following issue observed during PTS testing for mandatory test cases - Specified Upper and Lower Limit for Volume offset - Corrected the number of handles for VOCS - VOCS is made as included service of VCS because VOCS is secondary service and VSC is primary service lib/uuid.h | 5 + src/shared/vcp.c | 547 ++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 550 insertions(+), 2 deletions(-)