mbox series

[v3,0/4] tracing/user_events: Add empty arguments events

Message ID 20230606062027.1008398-1-sunliming@kylinos.cn (mailing list archive)
Headers show
Series tracing/user_events: Add empty arguments events | expand

Message

sunliming June 6, 2023, 6:20 a.m. UTC
This series patches fix the incorrect trace record for empty arguments
events and add correspondent selftests.

V3:
  Improve modification descriptions to maintain consistent formatting

v2:
  Change "i->count" to "i->count !=0 " to prevent compiler optimization
  Add correspondent selftests

sunliming (4):
  tracing/user_events: Fix the incorrect trace record for empty
    arguments events
  selftests/user_events: Add ftrace self-test for empty arguments events
  selftests/user_events: Clear the events after perf self-test
  selftests/user_events: Add perf self-test for empty arguments events

 kernel/trace/trace_events_user.c              |  4 +-
 .../selftests/user_events/ftrace_test.c       | 33 ++++++++
 .../testing/selftests/user_events/perf_test.c | 82 +++++++++++++++++++
 3 files changed, 117 insertions(+), 2 deletions(-)

Comments

Beau Belgrave June 6, 2023, 6:53 p.m. UTC | #1
On Tue, Jun 06, 2023 at 02:20:23PM +0800, sunliming wrote:
> This series patches fix the incorrect trace record for empty arguments
> events and add correspondent selftests.
> 
> V3:
>   Improve modification descriptions to maintain consistent formatting
> 
> v2:
>   Change "i->count" to "i->count !=0 " to prevent compiler optimization
>   Add correspondent selftests
> 
> sunliming (4):
>   tracing/user_events: Fix the incorrect trace record for empty
>     arguments events
>   selftests/user_events: Add ftrace self-test for empty arguments events
>   selftests/user_events: Clear the events after perf self-test
>   selftests/user_events: Add perf self-test for empty arguments events
> 
>  kernel/trace/trace_events_user.c              |  4 +-
>  .../selftests/user_events/ftrace_test.c       | 33 ++++++++
>  .../testing/selftests/user_events/perf_test.c | 82 +++++++++++++++++++
>  3 files changed, 117 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1

Thank you, this series looks good to me.

Acked-by: Beau Belgrave <beaub@linux.microsoft.com>

Thanks,
-Beau
Masami Hiramatsu (Google) June 7, 2023, 2:10 p.m. UTC | #2
On Tue,  6 Jun 2023 14:20:23 +0800
sunliming <sunliming@kylinos.cn> wrote:

> This series patches fix the incorrect trace record for empty arguments
> events and add correspondent selftests.

Looks good for me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

for the series.

> 
> V3:
>   Improve modification descriptions to maintain consistent formatting
> 
> v2:
>   Change "i->count" to "i->count !=0 " to prevent compiler optimization
>   Add correspondent selftests
> 
> sunliming (4):
>   tracing/user_events: Fix the incorrect trace record for empty
>     arguments events
>   selftests/user_events: Add ftrace self-test for empty arguments events
>   selftests/user_events: Clear the events after perf self-test
>   selftests/user_events: Add perf self-test for empty arguments events
> 
>  kernel/trace/trace_events_user.c              |  4 +-
>  .../selftests/user_events/ftrace_test.c       | 33 ++++++++
>  .../testing/selftests/user_events/perf_test.c | 82 +++++++++++++++++++
>  3 files changed, 117 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1
>