mbox series

[v4,0/2] migration: Update error description whenever migration fails

Message ID 20230523124638.16270-1-tejus.gk@nutanix.com (mailing list archive)
Headers show
Series migration: Update error description whenever migration fails | expand

Message

Tejus GK May 23, 2023, 12:46 p.m. UTC 
Hi everyone, 

Thank you for the reviews, this is the v4 patchset based on the reviews
received on the previous ones.

Links to the previous patchsets:
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00868.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg01943.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html

I've broken down this patchset into two	parts, the first, which updates
the error description in migration.c, and the second which refactors a
repeated call of yank_unregister_instance(). I've also added the 
reviewed-by as asked. 

A thing	to note	here, in the patchset previously sent, the second patch	
which handled the updation of error descriptions outside of migration.c,
was breaking a unit-test and hence breaking the build. I've removed that 
patch here and will  be sending that out as part of a different 
patchset.

Regards, 
Tejus


Tejus GK (2):
  migration: Update error description whenever migration fails
  migration: Refactor repeated call of yank_unregister_instance

 migration/migration.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

Comments

Tejus GK June 12, 2023, 4:50 a.m. UTC | #1 
On 23/05/23 6:16 pm, Tejus GK wrote:
> Hi everyone, 
> 
> Thank you for the reviews, this is the v4 patchset based on the reviews
> received on the previous ones.
> 
> Links to the previous patchsets:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00868.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg01943.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html
> 
> I've broken down this patchset into two	parts, the first, which updates
> the error description in migration.c, and the second which refactors a
> repeated call of yank_unregister_instance(). I've also added the 
> reviewed-by as asked. 
> 
> A thing	to note	here, in the patchset previously sent, the second patch	
> which handled the updation of error descriptions outside of migration.c,
> was breaking a unit-test and hence breaking the build. I've removed that 
> patch here and will  be sending that out as part of a different 
> patchset.
> 
> Regards, 
> Tejus
> 
> 
> Tejus GK (2):
>   migration: Update error description whenever migration fails
>   migration: Refactor repeated call of yank_unregister_instance
> 
>  migration/migration.c | 23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
> 
Hi Juan, 

Can this be queued for merge, as the patches have already been reviewed? If they require any further changes, please do let me know. 

Regards,
Tejus