[RFC,0/2] migration: Update error description outside migration.c

Message

Tejus GK May 26, 2023, 11:50 a.m. UTC

Hi everyone,

This patchset aims to cover code paths in the source code where a 
migration is marked as failed via MIGRATION_STATUS_FAILED, however the 
failure exists outside of migration.c, and without a call for 
migrate_set_error at this place. 

This patchset has been split out from the patchset sent before which 
covered cases of such gaps in migration.c aswell.

Previous patchset: 
https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html 

Regards, 
Tejus

Tejus GK (2):
  migration/vmstate: Introduce vmstate_save_state_with_err
  migration: Update error description outside migration.c

 include/migration/vmstate.h |  4 +++-
 migration/savevm.c          | 19 +++++++++++++++----
 migration/vmstate.c         | 19 +++++++++++++------
 3 files changed, 31 insertions(+), 11 deletions(-)

Comments

Tejus GK June 12, 2023, 5 a.m. UTC | #1

On 26/05/23 5:20 pm, Tejus GK wrote:
> Hi everyone,
> 
> This patchset aims to cover code paths in the source code where a 
> migration is marked as failed via MIGRATION_STATUS_FAILED, however the 
> failure exists outside of migration.c, and without a call for 
> migrate_set_error at this place. 
> 
> This patchset has been split out from the patchset sent before which 
> covered cases of such gaps in migration.c aswell.
> 
> Previous patchset: 
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html 
> 
> Regards, 
> Tejus
> 
> Tejus GK (2):
>   migration/vmstate: Introduce vmstate_save_state_with_err
>   migration: Update error description outside migration.c
> 
>  include/migration/vmstate.h |  4 +++-
>  migration/savevm.c          | 19 +++++++++++++++----
>  migration/vmstate.c         | 19 +++++++++++++------
>  3 files changed, 31 insertions(+), 11 deletions(-)
> 

Hi everyone, 

Apologies for the delayed ping. Can someone please review this patchset?

Regards,
Tejus

Peter Xu June 12, 2023, 1:14 p.m. UTC | #2

On Fri, May 26, 2023 at 11:50:01AM +0000, Tejus GK wrote:
> Hi everyone,
> 
> This patchset aims to cover code paths in the source code where a 
> migration is marked as failed via MIGRATION_STATUS_FAILED, however the 
> failure exists outside of migration.c, and without a call for 
> migrate_set_error at this place. 
> 
> This patchset has been split out from the patchset sent before which 
> covered cases of such gaps in migration.c aswell.
> 
> Previous patchset: 
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html 

Acked-by: Peter Xu <[e-mail]>