| Message ID | 0d6051ad217f91c7de0883c4ca1516bdacc343ce.1686651032.git.mehdi.djait.k@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer | expand |
On Tue, 13 Jun 2023 12:22:34 +0200, Mehdi Djait wrote: > Extend the kionix,kx022a.yaml file to support the kx132-1211 device > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Matti Vaittinen <mazziesaccount@gmail.com> > Signed-off-by: Mehdi Djait <mehdi.djait.k@gmail.com> > --- > v6: > v5: > v4: > v3: > - no changes > > v2: > - made the device name more specific from "kx132" to "kx132-1211" > - removed the output data-rates mentioned and replaced them with "variable > output data-rates" > > .../devicetree/bindings/iio/accel/kionix,kx022a.yaml | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml: $defs:qcom-pmic-mpp-state:properties:qcom,paired: [{'description': 'Indicates that the pin should be operating in paired mode.'}] is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/core.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/0d6051ad217f91c7de0883c4ca1516bdacc343ce.1686651032.git.mehdi.djait.k@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Jun 13, 2023 at 05:19:14AM -0600, Rob Herring wrote: > > On Tue, 13 Jun 2023 12:22:34 +0200, Mehdi Djait wrote: > > Extend the kionix,kx022a.yaml file to support the kx132-1211 device > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Acked-by: Matti Vaittinen <mazziesaccount@gmail.com> > > Signed-off-by: Mehdi Djait <mehdi.djait.k@gmail.com> > > --- > > v6: > > v5: > > v4: > > v3: > > - no changes > > > > v2: > > - made the device name more specific from "kx132" to "kx132-1211" > > - removed the output data-rates mentioned and replaced them with "variable > > output data-rates" > > > > .../devicetree/bindings/iio/accel/kionix,kx022a.yaml | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml: $defs:qcom-pmic-mpp-state:properties:qcom,paired: [{'description': 'Indicates that the pin should be operating in paired mode.'}] is not of type 'object', 'boolean' > from schema $id: http://devicetree.org/meta-schemas/core.yaml# Unrelated. This can be ignored. Rob
diff --git a/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml b/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml index 986df1a6ff0a..034b69614416 100644 --- a/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml +++ b/Documentation/devicetree/bindings/iio/accel/kionix,kx022a.yaml @@ -4,19 +4,21 @@ $id: http://devicetree.org/schemas/iio/accel/kionix,kx022a.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: ROHM/Kionix KX022A Accelerometer +title: ROHM/Kionix KX022A and KX132-1211 Accelerometers maintainers: - Matti Vaittinen <mazziesaccount@gmail.com> description: | - KX022A is a 3-axis accelerometer supporting +/- 2G, 4G, 8G and 16G ranges, - output data-rates from 0.78Hz to 1600Hz and a hardware-fifo buffering. - KX022A can be accessed either via I2C or SPI. + KX022A and KX132-1211 are 3-axis accelerometers supporting +/- 2G, 4G, 8G and + 16G ranges, variable output data-rates and a hardware-fifo buffering. + KX022A and KX132-1211 can be accessed either via I2C or SPI. properties: compatible: - const: kionix,kx022a + enum: + - kionix,kx022a + - kionix,kx132-1211 reg: maxItems: 1