| Message ID | 20230614130952.253349-1-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand |
Sorry, please ignore this mail. On Wed, 14 Jun 2023 at 16:10, Tomer Maimon <tmaimon77@gmail.com> wrote: > > This patchset adds clock support for the Nuvoton > Arbel NPCM8XX Board Management controller (BMC) SoC family. > > This patchset cover letter is based from the initial support for NPCM8xx BMC to > keep tracking the version history. > > all the other initial support patches had been applied to Linux kernel 6.0. > > This patchset was tested on the Arbel NPCM8XX evaluation board. > > Addressed comments from: > > - Stephen Boyd: https://www.spinics.net/lists/kernel/msg4729384.html > > Changes since version 15: > - NPCM8XX clock driver > - Remove unused regs parameter from npcm8xx_pll_data structure. > - Using index and clk_hw parameters to set the clock parent in the clock structures. > > Changes since version 14: > - NPCM8XX clock driver > - Remove unnecessary register definitions. > - Remove the internal reference clock, instead use the external DT reference clock. > - rearrange the driver. > - using .names parameter in DT to define clock (refclk). > > Changes since version 13: > - NPCM8XX clock driver > - Remove unnecessary definitions and add module.h define > - Use in clk_parent_data struct.fw_name and .name. > - Add module_exit function. > - Add const to divider clock names. > - Add MODULE_DESCRIPTION and MODULE_LICENSE > > Changes since version 12: > - NPCM8XX clock driver > - Use clk_parent_data in mux and div clock structure. > - Add const to mux tables. > - Using devm_clk_hw_register_fixed_rate function. > - use only .name clk_parent_data instead .name and .fw_name. > - Modify mask values in mux clocks. > > Changes since version 11: > - NPCM8XX clock driver > - Modify Kconfig help. > - Modify loop variable to unsigned int. > > Changes since version 11: > - NPCM8XX clock driver > - Modify Kconfig help. > - Modify loop variable to unsigned int. > > Changes since version 10: > - NPCM8XX clock driver > - Fix const warning. > > Changes since version 9: > - NPCM8XX clock driver > - Move configuration place. > - Using clk_parent_data instead of parent_name > - using devm_ioremap instead of ioremap. deeply sorry, I know we had > a long discussion on what should the driver use, from other examples > (also in other clock drivers) I see the combination of > platform_get_resource and devm_ioremap are commonly used and it answer > the reset and clock needs. > > Changes since version 8: > - NPCM8XX clock driver > - Move configuration place. > - Add space before and aftre '{' '}'. > - Handle devm_of_clk_add_hw_provider function error. > > Changes since version 7: > - NPCM8XX clock driver > - The clock and reset registers using the same memory region, > due to it the clock driver should claim the ioremap directly > without checking the memory region. > > Changes since version 6: > - NPCM reset driver > - Modify warning message. > - dt-bindings: serial: 8250: Add npcm845 compatible string patch accepted, due > to it the patch removed from the patchset. > > Changes since version 5: > - NPCM8XX clock driver > - Remove refclk if devm_of_clk_add_hw_provider function failed. > - NPCM8XX clock source driver > - Remove NPCM8XX TIMER_OF_DECLARE support, using the same as NPCM7XX. > > Changes since version 4: > - NPCM8XX clock driver > - Use the same quote in the dt-binding file. > > Changes since version 3: > - NPCM8XX clock driver > - Rename NPCM8xx clock dt-binding header file. > - Remove unused structures. > - Improve Handling the clocks registration. > - NPCM reset driver > - Add ref phandle to dt-binding. > > Changes since version 2: > - Remove NPCM8xx WDT compatible patch. > - Remove NPCM8xx UART compatible patch. > - NPCM8XX clock driver > - Add debug new line. > - Add 25M fixed rate clock. > - Remove unused clocks and clock name from dt-binding. > - NPCM reset driver > - Revert to npcm7xx dt-binding. > - Skip dt binding quotes. > - Adding DTS backward compatibility. > - Remove NPCM8xx binding include file. > - Warp commit message. > - NPCM8XX device tree: > - Remove unused clock nodes (used in the clock driver) > - Modify gcr and rst node names. > > Changes since version 1: > - NPCM8XX clock driver > - Modify dt-binding. > - Remove unsed definition and include. > - Include alphabetically. > - Use clock devm. > - NPCM reset driver > - Modify dt-binding. > - Modify syscon name. > - Add syscon support to NPCM7XX dts reset node. > - use data structure. > - NPCM8XX device tree: > - Modify evb compatible name. > - Add NPCM7xx compatible. > - Remove disable nodes from the EVB DTS. > > Tomer Maimon (1): > clk: npcm8xx: add clock controller > > drivers/clk/Kconfig | 8 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-npcm8xx.c | 566 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 575 insertions(+) > create mode 100644 drivers/clk/clk-npcm8xx.c > > -- > 2.33.0 >
This patchset adds clock support for the Nuvoton Arbel NPCM8XX Board Management controller (BMC) SoC family. This patchset cover letter is based from the initial support for NPCM8xx BMC to keep tracking the version history. all the other initial support patches had been applied to Linux kernel 6.0. This patchset was tested on the Arbel NPCM8XX evaluation board. Addressed comments from: - Stephen Boyd: https://www.spinics.net/lists/kernel/msg4729384.html Changes since version 15: - NPCM8XX clock driver - Remove unused regs parameter from npcm8xx_pll_data structure. - Using index and clk_hw parameters to set the clock parent in the clock structures. Changes since version 14: - NPCM8XX clock driver - Remove unnecessary register definitions. - Remove the internal reference clock, instead use the external DT reference clock. - rearrange the driver. - using .names parameter in DT to define clock (refclk). Changes since version 13: - NPCM8XX clock driver - Remove unnecessary definitions and add module.h define - Use in clk_parent_data struct.fw_name and .name. - Add module_exit function. - Add const to divider clock names. - Add MODULE_DESCRIPTION and MODULE_LICENSE Changes since version 12: - NPCM8XX clock driver - Use clk_parent_data in mux and div clock structure. - Add const to mux tables. - Using devm_clk_hw_register_fixed_rate function. - use only .name clk_parent_data instead .name and .fw_name. - Modify mask values in mux clocks. Changes since version 11: - NPCM8XX clock driver - Modify Kconfig help. - Modify loop variable to unsigned int. Changes since version 11: - NPCM8XX clock driver - Modify Kconfig help. - Modify loop variable to unsigned int. Changes since version 10: - NPCM8XX clock driver - Fix const warning. Changes since version 9: - NPCM8XX clock driver - Move configuration place. - Using clk_parent_data instead of parent_name - using devm_ioremap instead of ioremap. deeply sorry, I know we had a long discussion on what should the driver use, from other examples (also in other clock drivers) I see the combination of platform_get_resource and devm_ioremap are commonly used and it answer the reset and clock needs. Changes since version 8: - NPCM8XX clock driver - Move configuration place. - Add space before and aftre '{' '}'. - Handle devm_of_clk_add_hw_provider function error. Changes since version 7: - NPCM8XX clock driver - The clock and reset registers using the same memory region, due to it the clock driver should claim the ioremap directly without checking the memory region. Changes since version 6: - NPCM reset driver - Modify warning message. - dt-bindings: serial: 8250: Add npcm845 compatible string patch accepted, due to it the patch removed from the patchset. Changes since version 5: - NPCM8XX clock driver - Remove refclk if devm_of_clk_add_hw_provider function failed. - NPCM8XX clock source driver - Remove NPCM8XX TIMER_OF_DECLARE support, using the same as NPCM7XX. Changes since version 4: - NPCM8XX clock driver - Use the same quote in the dt-binding file. Changes since version 3: - NPCM8XX clock driver - Rename NPCM8xx clock dt-binding header file. - Remove unused structures. - Improve Handling the clocks registration. - NPCM reset driver - Add ref phandle to dt-binding. Changes since version 2: - Remove NPCM8xx WDT compatible patch. - Remove NPCM8xx UART compatible patch. - NPCM8XX clock driver - Add debug new line. - Add 25M fixed rate clock. - Remove unused clocks and clock name from dt-binding. - NPCM reset driver - Revert to npcm7xx dt-binding. - Skip dt binding quotes. - Adding DTS backward compatibility. - Remove NPCM8xx binding include file. - Warp commit message. - NPCM8XX device tree: - Remove unused clock nodes (used in the clock driver) - Modify gcr and rst node names. Changes since version 1: - NPCM8XX clock driver - Modify dt-binding. - Remove unsed definition and include. - Include alphabetically. - Use clock devm. - NPCM reset driver - Modify dt-binding. - Modify syscon name. - Add syscon support to NPCM7XX dts reset node. - use data structure. - NPCM8XX device tree: - Modify evb compatible name. - Add NPCM7xx compatible. - Remove disable nodes from the EVB DTS. Tomer Maimon (1): clk: npcm8xx: add clock controller drivers/clk/Kconfig | 8 + drivers/clk/Makefile | 1 + drivers/clk/clk-npcm8xx.c | 566 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 575 insertions(+) create mode 100644 drivers/clk/clk-npcm8xx.c