| Message ID | 20230612095903.2113464-1-Vijendar.Mukunda@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: amd: ps: add SoundWire support | expand |
On 12/06/23 15:28, Vijendar Mukunda wrote: > This patch series add support for > - Platform device creation for SoundWire Manager instances and > PDM controller. > - SoundWire DMA driver. > - Interrupt handling for SoundWire manager related interrupts, > SoundWire DMA interrupts and ACP error interrupts. > - ACP PCI driver PM ops modification with respect to SoundWire > Power modes. > > Changes since v3: > - use pdev_config instead of pdev_mask in the code. > - define platform device configuration macros rather than enums > - add comments for MIPI DisCo version > - refactor SoundWire DMA start/stop sequence using single > function > - refactor "acp_reset" flag related functionality. > > Changes since v2: > - add comments in irq handler. > - remove workqueue for SoundWire DMA interrupts and use thread > implementation for DMA interrupt handling. > - add error checks in sdw_amd_scan_controller() > - remove passing "acp_lock" as platform resource for SoundWire DMA driver > and PDM driver. > - retrieve "acp_lock" reference from parent driver directly and > use the reference in SoundWire DMA driver. > - add handling for acp pci driver probe even when no ACP PDM or > SoundWire manager platform devices created. > - Fix indentation for acp_sdw_dma_count structure variables. > - Use macro instead of hard coded values for FIFO offset and PTE offset. > - Change pm_runtime enable sequence in SoundWire DMA driver > probe function. > - Refactor system level resume callback in SoundWire DMA > > Changes since v1: > - update "soundwire" as "SoundWire" in code. > - add comments for platform device mask and platform device > count > - remove unused variables in acp pci driver private data > structure > - refactor dma enable register structures in SoundWire DMA driver > - add TODO comments in IRQ handler > - update IRQ mask values using bit macros > - Fix build error reported in Makefile > - rename "sdw_dma_stream_instance" structure name as "acp_sdw_dma_stream" @Mark: We have provided replies for upstream review comments for V4 patch set. We are going to push as supplement patches for minor fixes. Should I resend the patch series? > > Vijendar Mukunda (9): > ASoC: amd: ps: create platform devices based on acp config > ASoC: amd: ps: handle SoundWire interrupts in acp pci driver > ASoC: amd: ps: add SoundWire dma driver > ASoC: amd: ps: add SoundWire dma driver dma ops > ASoC: amd: ps: add support for SoundWire DMA interrupts > ASoC: amd: ps: add pm ops support for SoundWire dma driver > ASoC: amd: ps: enable SoundWire dma driver build > ASoC: amd: update comments in Kconfig file > ASoC: amd: ps: add acp_reset flag check in acp pci driver pm ops. > > sound/soc/amd/Kconfig | 3 +- > sound/soc/amd/ps/Makefile | 2 + > sound/soc/amd/ps/acp63.h | 172 ++++++++++- > sound/soc/amd/ps/pci-ps.c | 419 +++++++++++++++++++++++-- > sound/soc/amd/ps/ps-sdw-dma.c | 555 ++++++++++++++++++++++++++++++++++ > 5 files changed, 1115 insertions(+), 36 deletions(-) > create mode 100644 sound/soc/amd/ps/ps-sdw-dma.c >
On 19/06/23 11:02, Mukunda,Vijendar wrote: > On 12/06/23 15:28, Vijendar Mukunda wrote: >> This patch series add support for >> - Platform device creation for SoundWire Manager instances and >> PDM controller. >> - SoundWire DMA driver. >> - Interrupt handling for SoundWire manager related interrupts, >> SoundWire DMA interrupts and ACP error interrupts. >> - ACP PCI driver PM ops modification with respect to SoundWire >> Power modes. >> >> Changes since v3: >> - use pdev_config instead of pdev_mask in the code. >> - define platform device configuration macros rather than enums >> - add comments for MIPI DisCo version >> - refactor SoundWire DMA start/stop sequence using single >> function >> - refactor "acp_reset" flag related functionality. >> >> Changes since v2: >> - add comments in irq handler. >> - remove workqueue for SoundWire DMA interrupts and use thread >> implementation for DMA interrupt handling. >> - add error checks in sdw_amd_scan_controller() >> - remove passing "acp_lock" as platform resource for SoundWire DMA driver >> and PDM driver. >> - retrieve "acp_lock" reference from parent driver directly and >> use the reference in SoundWire DMA driver. >> - add handling for acp pci driver probe even when no ACP PDM or >> SoundWire manager platform devices created. >> - Fix indentation for acp_sdw_dma_count structure variables. >> - Use macro instead of hard coded values for FIFO offset and PTE offset. >> - Change pm_runtime enable sequence in SoundWire DMA driver >> probe function. >> - Refactor system level resume callback in SoundWire DMA >> >> Changes since v1: >> - update "soundwire" as "SoundWire" in code. >> - add comments for platform device mask and platform device >> count >> - remove unused variables in acp pci driver private data >> structure >> - refactor dma enable register structures in SoundWire DMA driver >> - add TODO comments in IRQ handler >> - update IRQ mask values using bit macros >> - Fix build error reported in Makefile >> - rename "sdw_dma_stream_instance" structure name as "acp_sdw_dma_stream" > @Mark: We have provided replies for upstream review comments for V4 patch set. > We are going to push as supplement patches for minor fixes. > Should I resend the patch series? @Bossart: If you don't have further comments, could you please provide reviewed-by tag for this patch series? >> >> Vijendar Mukunda (9): >> ASoC: amd: ps: create platform devices based on acp config >> ASoC: amd: ps: handle SoundWire interrupts in acp pci driver >> ASoC: amd: ps: add SoundWire dma driver >> ASoC: amd: ps: add SoundWire dma driver dma ops >> ASoC: amd: ps: add support for SoundWire DMA interrupts >> ASoC: amd: ps: add pm ops support for SoundWire dma driver >> ASoC: amd: ps: enable SoundWire dma driver build >> ASoC: amd: update comments in Kconfig file >> ASoC: amd: ps: add acp_reset flag check in acp pci driver pm ops. >> >> sound/soc/amd/Kconfig | 3 +- >> sound/soc/amd/ps/Makefile | 2 + >> sound/soc/amd/ps/acp63.h | 172 ++++++++++- >> sound/soc/amd/ps/pci-ps.c | 419 +++++++++++++++++++++++-- >> sound/soc/amd/ps/ps-sdw-dma.c | 555 ++++++++++++++++++++++++++++++++++ >> 5 files changed, 1115 insertions(+), 36 deletions(-) >> create mode 100644 sound/soc/amd/ps/ps-sdw-dma.c >>
On Mon, Jun 19, 2023 at 11:02:52AM +0530, Mukunda,Vijendar wrote: > On 12/06/23 15:28, Vijendar Mukunda wrote: > > - Fix build error reported in Makefile > > - rename "sdw_dma_stream_instance" structure name as "acp_sdw_dma_stream" > @Mark: We have provided replies for upstream review comments for V4 patch set. > We are going to push as supplement patches for minor fixes. > Should I resend the patch series? My name doesn't have an @ in it, please don't add one. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
On Mon, 12 Jun 2023 15:28:54 +0530, Vijendar Mukunda wrote: > This patch series add support for > - Platform device creation for SoundWire Manager instances and > PDM controller. > - SoundWire DMA driver. > - Interrupt handling for SoundWire manager related interrupts, > SoundWire DMA interrupts and ACP error interrupts. > - ACP PCI driver PM ops modification with respect to SoundWire > Power modes. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/9] ASoC: amd: ps: create platform devices based on acp config commit: d1351c30ac8a6cf61b0bbe9fcbc8d2851cd44f3c [2/9] ASoC: amd: ps: handle SoundWire interrupts in acp pci driver commit: e1cb350610ce88d9995b8b287930d3ba821d9f2b [3/9] ASoC: amd: ps: add SoundWire dma driver commit: 665dd181a97ff9588060f76887c3b61fd4ccb8b0 [4/9] ASoC: amd: ps: add SoundWire dma driver dma ops commit: f722917350ee0b802a62d888f4e8b23bd5f1f641 [5/9] ASoC: amd: ps: add support for SoundWire DMA interrupts commit: 298d4f7b176538d41356d145c044442b8456a14e [6/9] ASoC: amd: ps: add pm ops support for SoundWire dma driver commit: 5a06c3ac4cf9a8ca5edf99a07a1129ae25ab581e [7/9] ASoC: amd: ps: enable SoundWire dma driver build commit: 7b33594130405cbcfdef2a4c582f9c67aef8d292 [8/9] ASoC: amd: update comments in Kconfig file commit: 6e8f7cb4cbae8e2b03190d26674a14be22d7df53 [9/9] ASoC: amd: ps: add acp_reset flag check in acp pci driver pm ops. commit: 198c93e2fc0b74ae520393118d7cb02762c04bf3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark