| Message ID | 20230602084925.215411-2-william.qiu@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add initialization of clock for StarFive JH7110 SoC | expand |
On Fri, Jun 02, 2023 at 04:49:23PM +0800, William Qiu wrote: > The QSPI controller needs three clock items to work properly on StarFive > JH7110 SoC, so there is need to change the maxItems's value to 3. Other > platforms do not have this constraint. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > Reviewed-by: Hal Feng <hal.feng@starfivetech.com> > --- > .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index b310069762dd..b6a27171d965 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -26,6 +26,15 @@ allOf: > const: starfive,jh7110-qspi > then: > properties: > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: ref_clk Aww, I liked Mark's suggestions better. If you are respinning to fix the LKP reported issue w/ ignoring the result of enabling the clocks, could you chop the _clk off of this one? Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On 2023/6/3 2:02, Conor Dooley wrote: > On Fri, Jun 02, 2023 at 04:49:23PM +0800, William Qiu wrote: >> The QSPI controller needs three clock items to work properly on StarFive >> JH7110 SoC, so there is need to change the maxItems's value to 3. Other >> platforms do not have this constraint. >> >> Signed-off-by: William Qiu <william.qiu@starfivetech.com> >> Reviewed-by: Hal Feng <hal.feng@starfivetech.com> >> --- >> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> index b310069762dd..b6a27171d965 100644 >> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> @@ -26,6 +26,15 @@ allOf: >> const: starfive,jh7110-qspi >> then: >> properties: >> + clocks: >> + maxItems: 3 >> + >> + clock-names: >> + items: >> + - const: ref_clk > > Aww, I liked Mark's suggestions better. > If you are respinning to fix the LKP reported issue w/ ignoring the result > of enabling the clocks, could you chop the _clk off of this one? > > Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. Hi Conor, Thanks for taking time to review this patch series. About the clock name, I would take Mark's suggestions, and will update it in next version. Best regards, William
On 02/06/2023 10:49, William Qiu wrote: > The QSPI controller needs three clock items to work properly on StarFive > JH7110 SoC, so there is need to change the maxItems's value to 3. Other > platforms do not have this constraint. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > Reviewed-by: Hal Feng <hal.feng@starfivetech.com> > > @@ -69,9 +81,6 @@ properties: > interrupts: > maxItems: 1 > > - clocks: > - maxItems: 1 Properties should be defined in top-level properties. Don't remove them from here. Best regards, Krzysztof
On 2023/6/6 20:43, Krzysztof Kozlowski wrote: > On 02/06/2023 10:49, William Qiu wrote: >> The QSPI controller needs three clock items to work properly on StarFive >> JH7110 SoC, so there is need to change the maxItems's value to 3. Other >> platforms do not have this constraint. >> >> Signed-off-by: William Qiu <william.qiu@starfivetech.com> >> Reviewed-by: Hal Feng <hal.feng@starfivetech.com> > > > >> >> @@ -69,9 +81,6 @@ properties: >> interrupts: >> maxItems: 1 >> >> - clocks: >> - maxItems: 1 > > Properties should be defined in top-level properties. Don't remove them > from here. > > Best regards, > Krzysztof > Hi Krzysztof, Sorry for the late reply. I'll fix it in next version. Best regards, William
diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml index b310069762dd..b6a27171d965 100644 --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml @@ -26,6 +26,15 @@ allOf: const: starfive,jh7110-qspi then: properties: + clocks: + maxItems: 3 + + clock-names: + items: + - const: ref_clk + - const: hclk + - const: pclk + resets: minItems: 2 maxItems: 3 @@ -38,6 +47,9 @@ allOf: else: properties: + clocks: + maxItems: 1 + resets: maxItems: 2 @@ -69,9 +81,6 @@ properties: interrupts: maxItems: 1 - clocks: - maxItems: 1 - cdns,fifo-depth: description: Size of the data FIFO in words.