mbox series

[v13,0/3] Amiga RDB partition support fixes

Message ID 20230620201725.7020-1-schmitzmic@gmail.com (mailing list archive)
Headers show
Series Amiga RDB partition support fixes | expand

Message

Michael Schmitz June 20, 2023, 8:17 p.m. UTC
Hi Jens,

another last version of this patch series, only change
in this version is in the patch 2 subject (to better
reflect what it's about), and adding Geert's review
tag to said patch. 

I hope I've crossed all i's and dotted all t's now...

Cheers,

    Michael

Michael Schmitz (3):
  block: fix signed int overflow in Amiga partition support
  block: change all __u32 annotations to __be32 in affs_hardblocks.h
  block: add overflow checks for Amiga partition support

 block/partitions/amiga.c             | 102 ++++++++++++++++++++++-----
 include/uapi/linux/affs_hardblocks.h |  68 +++++++++---------
 2 files changed, 119 insertions(+), 51 deletions(-)

Comments

Jens Axboe June 20, 2023, 8:28 p.m. UTC | #1
On Wed, 21 Jun 2023 08:17:22 +1200, Michael Schmitz wrote:
> another last version of this patch series, only change
> in this version is in the patch 2 subject (to better
> reflect what it's about), and adding Geert's review
> tag to said patch.
> 
> I hope I've crossed all i's and dotted all t's now...
> 
> [...]

Applied, thanks!

[1/3] block: fix signed int overflow in Amiga partition support
      commit: fc3d092c6bb48d5865fec15ed5b333c12f36288c
[2/3] block: change all __u32 annotations to __be32 in affs_hardblocks.h
      commit: 95a55437dc49fb3342c82e61f5472a71c63d9ed0
[3/3] block: add overflow checks for Amiga partition support
      commit: b6f3f28f604ba3de4724ad82bea6adb1300c0b5f

Best regards,
Martin Steigerwald June 20, 2023, 9:16 p.m. UTC | #2
Jens Axboe - 20.06.23, 22:28:34 CEST:
> On Wed, 21 Jun 2023 08:17:22 +1200, Michael Schmitz wrote:
> > another last version of this patch series, only change
> > in this version is in the patch 2 subject (to better
> > reflect what it's about), and adding Geert's review
> > tag to said patch.
> > 
> > I hope I've crossed all i's and dotted all t's now...
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/3] block: fix signed int overflow in Amiga partition support
>       commit: fc3d092c6bb48d5865fec15ed5b333c12f36288c
> [2/3] block: change all __u32 annotations to __be32 in
> affs_hardblocks.h commit: 95a55437dc49fb3342c82e61f5472a71c63d9ed0
> [3/3] block: add overflow checks for Amiga partition support
>       commit: b6f3f28f604ba3de4724ad82bea6adb1300c0b5f

Wonderful! Thanks to everyone involved! Thanks to Jens for applying it! 
And special thanks to Michael for going through 13 iterations!

Best,
Michael Schmitz June 20, 2023, 9:17 p.m. UTC | #3
Thanks Jens!

And a big 'Thank You' to all who helped with suggestions and comments.

Cheers,

     Michael


On 21/06/23 08:28, Jens Axboe wrote:
> On Wed, 21 Jun 2023 08:17:22 +1200, Michael Schmitz wrote:
>> another last version of this patch series, only change
>> in this version is in the patch 2 subject (to better
>> reflect what it's about), and adding Geert's review
>> tag to said patch.
>>
>> I hope I've crossed all i's and dotted all t's now...
>>
>> [...]
> Applied, thanks!
>
> [1/3] block: fix signed int overflow in Amiga partition support
>        commit: fc3d092c6bb48d5865fec15ed5b333c12f36288c
> [2/3] block: change all __u32 annotations to __be32 in affs_hardblocks.h
>        commit: 95a55437dc49fb3342c82e61f5472a71c63d9ed0
> [3/3] block: add overflow checks for Amiga partition support
>        commit: b6f3f28f604ba3de4724ad82bea6adb1300c0b5f
>
> Best regards,
John Paul Adrian Glaubitz June 21, 2023, 5:54 a.m. UTC | #4
On Tue, 2023-06-20 at 23:16 +0200, Martin Steigerwald wrote:
> Jens Axboe - 20.06.23, 22:28:34 CEST:
> > On Wed, 21 Jun 2023 08:17:22 +1200, Michael Schmitz wrote:
> > > another last version of this patch series, only change
> > > in this version is in the patch 2 subject (to better
> > > reflect what it's about), and adding Geert's review
> > > tag to said patch.
> > > 
> > > I hope I've crossed all i's and dotted all t's now...
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/3] block: fix signed int overflow in Amiga partition support
> >       commit: fc3d092c6bb48d5865fec15ed5b333c12f36288c
> > [2/3] block: change all __u32 annotations to __be32 in
> > affs_hardblocks.h commit: 95a55437dc49fb3342c82e61f5472a71c63d9ed0
> > [3/3] block: add overflow checks for Amiga partition support
> >       commit: b6f3f28f604ba3de4724ad82bea6adb1300c0b5f
> 
> Wonderful! Thanks to everyone involved! Thanks to Jens for applying it! 
> And special thanks to Michael for going through 13 iterations!

Amazing. Thanks to everyone who worked hard to get these fixes in!

Serious motivation booster for me to do more work on retro Linux ;-).

Adrian