| Message ID | 20230616062101.601837-23-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add perf support to the rockchip-dfi driver | expand |
On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote: > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier > SoCs the rk3588 has four interrupts (one for each channel) instead of > only one, so increase the number of allowed interrupts to four. > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de It's unclear what the point of this link is. My comment still stands about whether only the new compatible should be permitted to have more than one interrupt. I don't recall a response to that question on the last version. Cheers, Conor. > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > > Notes: > Changes since v4: > - new patch > > Changes since v5: > - drop interrupt-names property > > Changes since v4: > - new patch > > .../devicetree/bindings/devfreq/event/rockchip,dfi.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > index e8b64494ee8bd..50d3fabe958d5 100644 > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - rockchip,rk3399-dfi > - rockchip,rk3568-dfi > + - rockchip,rk3588-dfi > > clocks: > maxItems: 1 > @@ -23,7 +24,8 @@ properties: > - const: pclk_ddr_mon > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 4 > > reg: > maxItems: 1 > -- > 2.39.2 >
On Fri, Jun 16, 2023 at 08:05:33PM +0100, Conor Dooley wrote: > On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote: > > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier > > SoCs the rk3588 has four interrupts (one for each channel) instead of > > only one, so increase the number of allowed interrupts to four. > > > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de > > It's unclear what the point of this link is. The link was added automatically by b4. I re-applied the series from the last one I sent just to be sure that I base my work for the new series on the one I sent last time. I didn't remember that b4 adds these links, I should have disabled that option. > My comment still stands about whether only the new compatible should be > permitted to have more than one interrupt. I don't recall a response to > that question on the last version. My personal take on this is that such additions make the bindings more readable by machines, but less by humans. That's why I don't have enough intrinsic motivation to make this change. Anyway, if you insist then I'll make it for the next round. Sascha
On Wed, Jun 21, 2023 at 09:41:59AM +0200, Sascha Hauer wrote: > On Fri, Jun 16, 2023 at 08:05:33PM +0100, Conor Dooley wrote: > > On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote: > > > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier > > > SoCs the rk3588 has four interrupts (one for each channel) instead of > > > only one, so increase the number of allowed interrupts to four. > > > > > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de > > > > It's unclear what the point of this link is. > > The link was added automatically by b4. I re-applied the series from the > last one I sent just to be sure that I base my work for the new series > on the one I sent last time. I didn't remember that b4 adds these links, > I should have disabled that option. Ah, I see. > > My comment still stands about whether only the new compatible should be > > permitted to have more than one interrupt. I don't recall a response to > > that question on the last version. > > My personal take on this is that such additions make the bindings more > readable by machines, but less by humans. That's why I don't have enough > intrinsic motivation to make this change. > Anyway, if you insist then I'll make it for the next round. No, I don't insist. I just wanted to not be ignored. Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml index e8b64494ee8bd..50d3fabe958d5 100644 --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml @@ -14,6 +14,7 @@ properties: enum: - rockchip,rk3399-dfi - rockchip,rk3568-dfi + - rockchip,rk3588-dfi clocks: maxItems: 1 @@ -23,7 +24,8 @@ properties: - const: pclk_ddr_mon interrupts: - maxItems: 1 + minItems: 1 + maxItems: 4 reg: maxItems: 1
This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier SoCs the rk3588 has four interrupts (one for each channel) instead of only one, so increase the number of allowed interrupts to four. Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v4: - new patch Changes since v5: - drop interrupt-names property Changes since v4: - new patch .../devicetree/bindings/devfreq/event/rockchip,dfi.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)