diff mbox series

mfd: twl6040: Use maple tree register cache

Message ID 20230609-mfd-twl6040-maple-v1-1-3493d051cd6f@kernel.org (mailing list archive)
State New, archived
Headers show
Series mfd: twl6040: Use maple tree register cache | expand

Commit Message

Mark Brown June 10, 2023, 2:05 p.m. UTC 
The twl6040 is only capable of performing single register read and write
operations which means it gains no advantage from using a rbtree register
cache, convert it to using the more modern maple tree register cache
instead. This should be more efficient.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/mfd/twl6040.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
change-id: 20230609-mfd-twl6040-maple-0904598891f2

Best regards,

Comments

Lee Jones June 21, 2023, 3:08 p.m. UTC | #1 
On Sat, 10 Jun 2023, Mark Brown wrote:

> The twl6040 is only capable of performing single register read and write
> operations which means it gains no advantage from using a rbtree register
> cache, convert it to using the more modern maple tree register cache
> instead. This should be more efficient.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/mfd/twl6040.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This has been applied for a while.

> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index e982119bbefa..523439a16b7c 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -608,7 +608,7 @@ static const struct regmap_config twl6040_regmap_config = {
>  	.volatile_reg = twl6040_volatile_reg,
>  	.writeable_reg = twl6040_writeable_reg,
>  
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>  	.use_single_read = true,
>  	.use_single_write = true,
>  };
> 
> ---
> base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
> change-id: 20230609-mfd-twl6040-maple-0904598891f2
> 
> Best regards,
> -- 
> Mark Brown <broonie@kernel.org>
>
diff mbox series

Patch

diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
index e982119bbefa..523439a16b7c 100644
--- a/drivers/mfd/twl6040.c
+++ b/drivers/mfd/twl6040.c
@@ -608,7 +608,7 @@  static const struct regmap_config twl6040_regmap_config = {
 	.volatile_reg = twl6040_volatile_reg,
 	.writeable_reg = twl6040_writeable_reg,
 
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.use_single_read = true,
 	.use_single_write = true,
 };