diff mbox series

[PATCHv4,1/2] dt-bindings: arm: rockchip: Add Firefly Station P2

Message ID 20230620184746.55391-2-f.kardame@manjaro.org (mailing list archive)
State New, archived
Headers show
Series Add support for Firefly Station P2 aka rk3568-roc-pc | expand

Commit Message

Furkan Kardame June 20, 2023, 6:47 p.m. UTC
Station P2 is a single board computer by firefly based
on rk3568 soc

Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski June 21, 2023, 6:22 a.m. UTC | #1
On 20/06/2023 20:47, Furkan Kardame wrote:
> Station P2 is a single board computer by firefly based
> on rk3568 soc
> 
> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>
> ---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof
Furkan Kardame June 21, 2023, 1 p.m. UTC | #2
On Wednesday 21 June 2023 09:22:31 (+03:00), Krzysztof Kozlowski wrote:

 > On 20/06/2023 20:47, Furkan Kardame wrote:
 > > Station P2 is a single board computer by firefly based
 > > on rk3568 soc
 > > 
 > > Signed-off-by: Furkan Kardame 
 > > ---
 > 
 > This is a friendly reminder during the review process.
 > 
 > It looks like you received a tag and forgot to add it.
 > 
 > If you do not know the process, here is a short explanation:
 > Please add Acked-by/Reviewed-by/Tested-by tags when posting new
 > versions. However, there's no need to repost patches *only* to add the
 > tags. The upstream maintainer will do that for acks received on the
 > version they apply.
 > 
Noted, will take care of this in the future. 

 > 
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
 
> 
 > If a tag was not added on purpose, please state why and what changed.
 > 
 > Best regards,
 > Krzysztof
 > 
 >
Conor Dooley June 21, 2023, 8:22 p.m. UTC | #3
On Wed, Jun 21, 2023 at 01:00:05PM +0000, Furkan Kardame wrote:
> On Wednesday 21 June 2023 09:22:31 (+03:00), Krzysztof Kozlowski wrote:
> 
> > On 20/06/2023 20:47, Furkan Kardame wrote:
> > > Station P2 is a single board computer by firefly based
> > > on rk3568 soc
> > > > > Signed-off-by: Furkan Kardame > > ---
> > > This is a friendly reminder during the review process.
> > > It looks like you received a tag and forgot to add it.
> > > If you do not know the process, here is a short explanation:
> > Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> > versions. However, there's no need to repost patches *only* to add the
> > tags. The upstream maintainer will do that for acks received on the
> > version they apply.

> Noted, will take care of this in the future.

Since it was missed,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index ec141c937..fa21640bc 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -185,6 +185,11 @@  properties:
           - const: firefly,rk3566-roc-pc
           - const: rockchip,rk3566
 
+      - description: Firefly Station P2
+        items:
+          - const: firefly,rk3568-roc-pc
+          - const: rockchip,rk3568
+
       - description: FriendlyElec NanoPi R2 series boards
         items:
           - enum: