diff mbox series

[2/6] btrfs-progs: tests: misc/057-btrfstune-free-space-tree check for btrfs acl support

Message ID 4884e218dfb91cd1290d42ec030bd8c1af54bdcb.1687242517.git.anand.jain@oracle.com (mailing list archive)
State New, archived
Headers show
Series btrfs-progs: tests: fix no acl support | expand

Commit Message

Anand Jain June 20, 2023, 8:49 a.m. UTC
Fix failure due to no acl support in btrfs.

  $ make test
    ::
    [TEST/misc]   057-btrfstune-free-space-tree
    failed: setfacl -m u:root:x /Volumes/ws/btrfs-progs/tests/mnt/acls/acls.1
    test failed for case 057-btrfstune-free-space-tree
    make: *** [Makefile:493: test-misc] Error 1

Instead, use check_prereq_btrfsacl() to call _not_run().

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 tests/misc-tests/057-btrfstune-free-space-tree/test.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

David Sterba June 21, 2023, 2:58 p.m. UTC | #1
On Tue, Jun 20, 2023 at 04:49:58PM +0800, Anand Jain wrote:
> Fix failure due to no acl support in btrfs.
> 
>   $ make test
>     ::
>     [TEST/misc]   057-btrfstune-free-space-tree
>     failed: setfacl -m u:root:x /Volumes/ws/btrfs-progs/tests/mnt/acls/acls.1
>     test failed for case 057-btrfstune-free-space-tree
>     make: *** [Makefile:493: test-misc] Error 1
> 
> Instead, use check_prereq_btrfsacl() to call _not_run().
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  tests/misc-tests/057-btrfstune-free-space-tree/test.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/misc-tests/057-btrfstune-free-space-tree/test.sh b/tests/misc-tests/057-btrfstune-free-space-tree/test.sh
> index 93ff4307fca9..d91fe2588c93 100755
> --- a/tests/misc-tests/057-btrfstune-free-space-tree/test.sh
> +++ b/tests/misc-tests/057-btrfstune-free-space-tree/test.sh
> @@ -10,6 +10,7 @@ check_prereq btrfs
>  
>  setup_root_helper
>  prepare_test_dev
> +check_prereq_btrfsacl

You can do all the test case changes in one patch, the error messages
are basically the same.
Anand Jain June 22, 2023, 8:12 a.m. UTC | #2
> 
> You can do all the test case changes in one patch, the error messages
> are basically the same.

Yeah, will merge them into one patch.

Thanks, Anand
diff mbox series

Patch

diff --git a/tests/misc-tests/057-btrfstune-free-space-tree/test.sh b/tests/misc-tests/057-btrfstune-free-space-tree/test.sh
index 93ff4307fca9..d91fe2588c93 100755
--- a/tests/misc-tests/057-btrfstune-free-space-tree/test.sh
+++ b/tests/misc-tests/057-btrfstune-free-space-tree/test.sh
@@ -10,6 +10,7 @@  check_prereq btrfs
 
 setup_root_helper
 prepare_test_dev
+check_prereq_btrfsacl
 
 run_check_mkfs_test_dev -O ^free-space-tree
 run_check_mount_test_dev