| Message ID | 20230622180405.133298-1-damian.muszynski@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | crypto: qat - add heartbeat feature | expand |
On Thu, Jun 22, 2023 at 08:04:01PM +0200, Damian Muszynski wrote: > This set introduces support for the QAT heartbeat feature. It allows > detection whenever device firmware or acceleration unit will hang. > We're adding this feature to allow our clients having a tool with > they could verify if all of the Quick Assist hardware resources are > healthy and operational. > > QAT device firmware periodically writes counters to a specified physical > memory location. A pair of counters per thread is incremented at > the start and end of the main processing loop within the firmware. > Checking for Heartbeat consists of checking the validity of the pair > of counter values for each thread. Stagnant counters indicate > a firmware hang. > > The first patch adds timestamp synchronization to the firmware. > The second patch removes historical and never used HB definitions. > Patch no. 3 is implementing the hardware clock frequency measuring > interface. > The fourth introduces the main heartbeat implementation with the debugfs > interface. > The last patch implements an algorithm that allows the code to detect > which version of heartbeat API is used at the currently loaded firmware. > > Signed-off-by: Damian Muszynski <damian.muszynski@intel.com> > Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> These tags are not for cover letter.
On Thu, Jun 22, 2023 at 08:04:01PM +0200, Damian Muszynski wrote: > This set introduces support for the QAT heartbeat feature. It allows > detection whenever device firmware or acceleration unit will hang. > We're adding this feature to allow our clients having a tool with > they could verify if all of the Quick Assist hardware resources are > healthy and operational. > > QAT device firmware periodically writes counters to a specified physical > memory location. A pair of counters per thread is incremented at > the start and end of the main processing loop within the firmware. > Checking for Heartbeat consists of checking the validity of the pair > of counter values for each thread. Stagnant counters indicate > a firmware hang. > > The first patch adds timestamp synchronization to the firmware. > The second patch removes historical and never used HB definitions. > Patch no. 3 is implementing the hardware clock frequency measuring > interface. > The fourth introduces the main heartbeat implementation with the debugfs > interface. > The last patch implements an algorithm that allows the code to detect > which version of heartbeat API is used at the currently loaded firmware. I made a few last minute nit-picks, feel free to ignore them if it's okay with the maintainers.
On 2023-06-22 at 21:27:36 +0300, Andy Shevchenko wrote: > On Thu, Jun 22, 2023 at 08:04:01PM +0200, Damian Muszynski wrote: > > This set introduces support for the QAT heartbeat feature. It allows > > detection whenever device firmware or acceleration unit will hang. > > We're adding this feature to allow our clients having a tool with > > they could verify if all of the Quick Assist hardware resources are > > healthy and operational. > > > > QAT device firmware periodically writes counters to a specified physical > > memory location. A pair of counters per thread is incremented at > > the start and end of the main processing loop within the firmware. > > Checking for Heartbeat consists of checking the validity of the pair > > of counter values for each thread. Stagnant counters indicate > > a firmware hang. > > > > The first patch adds timestamp synchronization to the firmware. > > The second patch removes historical and never used HB definitions. > > Patch no. 3 is implementing the hardware clock frequency measuring > > interface. > > The fourth introduces the main heartbeat implementation with the debugfs > > interface. > > The last patch implements an algorithm that allows the code to detect > > which version of heartbeat API is used at the currently loaded firmware. > > I made a few last minute nit-picks, feel free to ignore them if it's okay > with the maintainers. Thanks, I will implement those. --- Best Regards, Damian Muszynski
On Thu, Jun 22, 2023 at 09:27:36PM +0300, Andy Shevchenko wrote: > On Thu, Jun 22, 2023 at 08:04:01PM +0200, Damian Muszynski wrote: > > This set introduces support for the QAT heartbeat feature. It allows > > detection whenever device firmware or acceleration unit will hang. > > We're adding this feature to allow our clients having a tool with > > they could verify if all of the Quick Assist hardware resources are > > healthy and operational. > > > > QAT device firmware periodically writes counters to a specified physical > > memory location. A pair of counters per thread is incremented at > > the start and end of the main processing loop within the firmware. > > Checking for Heartbeat consists of checking the validity of the pair > > of counter values for each thread. Stagnant counters indicate > > a firmware hang. > > > > The first patch adds timestamp synchronization to the firmware. > > The second patch removes historical and never used HB definitions. > > Patch no. 3 is implementing the hardware clock frequency measuring > > interface. > > The fourth introduces the main heartbeat implementation with the debugfs > > interface. > > The last patch implements an algorithm that allows the code to detect > > which version of heartbeat API is used at the currently loaded firmware. > > I made a few last minute nit-picks, feel free to ignore them if it's okay > with the maintainers. Thanks. Herbert, If you decide to include this in the PR for 6.5 we will send a patch on top to clarify the comment. Otherwise, we will resend the set including also a version update (6.5->6.6) in the Documentation. Regards,