| Message ID | e1cb94f4f82f4eca4a444feec4488a1323396357.1687466906.git.sd@queasysnail.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5f789f103671fec3733ebe756e56adf15c90c21d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: rtnetlink: remove netdevsim device after ipsec offload test | expand |
On Thu, Jun 22, 2023 at 11:03:34PM +0200, Sabrina Dubroca wrote: > On systems where netdevsim is built-in or loaded before the test > starts, kci_test_ipsec_offload doesn't remove the netdevsim device it > created during the test. > > Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe") > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Thu, Jun 22, 2023 at 11:03:34PM CEST, sd@queasysnail.net wrote: >On systems where netdevsim is built-in or loaded before the test >starts, kci_test_ipsec_offload doesn't remove the netdevsim device it >created during the test. > >Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe") >Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Thanks!
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 22 Jun 2023 23:03:34 +0200 you wrote: > On systems where netdevsim is built-in or loaded before the test > starts, kci_test_ipsec_offload doesn't remove the netdevsim device it > created during the test. > > Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe") > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> > > [...] Here is the summary with links: - [net] selftests: rtnetlink: remove netdevsim device after ipsec offload test https://git.kernel.org/netdev/net/c/5f789f103671 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh index 383ac6fc037d..ba286d680fd9 100755 --- a/tools/testing/selftests/net/rtnetlink.sh +++ b/tools/testing/selftests/net/rtnetlink.sh @@ -860,6 +860,7 @@ EOF fi # clean up any leftovers + echo 0 > /sys/bus/netdevsim/del_device $probed && rmmod netdevsim if [ $ret -ne 0 ]; then
On systems where netdevsim is built-in or loaded before the test starts, kci_test_ipsec_offload doesn't remove the netdevsim device it created during the test. Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe") Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> --- tools/testing/selftests/net/rtnetlink.sh | 1 + 1 file changed, 1 insertion(+)