diff mbox series

[isar-cip-core,1/3] .reproducible-check-ci.yml: Add swupdate targets in reproducible check

Message ID 20230623140555.11428-2-venkata.pyla@toshiba-tsip.com (mailing list archive)
State Superseded
Headers show
Series Enable swupdate targets in reproducible check | expand

Commit Message

Venkata Pyla June 23, 2023, 2:05 p.m. UTC 
From: venkata pyla <venkata.pyla@toshiba-tsip.com>

Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
---
 .reproducible-check-ci.yml | 49 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

Comments

Jan Kiszka June 25, 2023, 8:32 a.m. UTC | #1 
On 23.06.23 16:05, venkata.pyla@toshiba-tsip.com wrote:
> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
> 
> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
> ---
>  .reproducible-check-ci.yml | 49 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/.reproducible-check-ci.yml b/.reproducible-check-ci.yml
> index d8bfb40..5ea7857 100644
> --- a/.reproducible-check-ci.yml
> +++ b/.reproducible-check-ci.yml
> @@ -82,6 +82,30 @@ build:qemu-arm-base-repro-build:
>    variables:
>      target: qemu-arm
>  
> +build:qemu-amd64-swupdate-repro-build:
> +  extends:
> +    - .repro-build
> +  variables:
> +    target: qemu-amd64
> +    extension: ebg-swu
> +    wic_targz: enable
> +
> +build:qemu-arm64-swupdate-repro-build:
> +  extends:
> +    - .repro-build
> +  variables:
> +    target: qemu-arm64
> +    extension: ebg-swu
> +    wic_targz: enable
> +
> +build:qemu-arm-swupdate-repro-build:
> +  extends:
> +    - .repro-build
> +  variables:
> +    target: qemu-arm
> +    extension: ebg-swu
> +    wic_targz: enable
> +
>  # repro build test
>  test:qemu-amd64-base-repro-test:
>    extends:
> @@ -106,3 +130,28 @@ test:qemu-arm-base-repro-test:
>      target: qemu-arm
>    dependencies:
>      - build:qemu-arm-base-repro-build
> +
> +test:qemu-amd64-swupdate-repro-test:
> +  extends:
> +    - .repro-test
> +  variables:
> +    target: qemu-amd64
> +  dependencies:
> +    - build:qemu-amd64-swupdate-repro-build
> +
> +test:qemu-arm64-swupdate-repro-test:
> +  extends:
> +    - .repro-test
> +  variables:
> +    target: qemu-arm64
> +  dependencies:
> +    - build:qemu-arm64-swupdate-repro-build
> +
> +test:qemu-arm-swupdate-repro-test:
> +  extends:
> +    - .repro-test
> +  variables:
> +    target: qemu-arm
> +  dependencies:
> +    - build:qemu-arm-swupdate-repro-build
> +

To keep an eye on our number of builds: Do these new targets happen to
include aspect of existing ones and could therefore supersede them?

Jan
Venkata Pyla June 26, 2023, 5:12 a.m. UTC | #2 
>-----Original Message-----
>From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of
>Jan Kiszka via lists.cip-project.org
>Sent: Sunday, June 25, 2023 2:02 PM
>To: pyla venkata(ＴＳＩＰ TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>tsip.com>; cip-dev@lists.cip-project.org
>Cc: dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <dinesh.kumar@toshiba-
>tsip.com>; hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４)
><kazuhiro3.hayashi@toshiba.co.jp>
>Subject: Re: [cip-dev] [isar-cip-core 1/3] .reproducible-check-ci.yml: Add
>swupdate targets in reproducible check
>
>On 23.06.23 16:05, venkata.pyla@toshiba-tsip.com wrote:
>> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
>>
>> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
>> ---
>>  .reproducible-check-ci.yml | 49
>> ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 49 insertions(+)
>>
>> diff --git a/.reproducible-check-ci.yml b/.reproducible-check-ci.yml
>> index d8bfb40..5ea7857 100644
>> --- a/.reproducible-check-ci.yml
>> +++ b/.reproducible-check-ci.yml
>> @@ -82,6 +82,30 @@ build:qemu-arm-base-repro-build:
>>    variables:
>>      target: qemu-arm
>>
>> +build:qemu-amd64-swupdate-repro-build:
>> +  extends:
>> +    - .repro-build
>> +  variables:
>> +    target: qemu-amd64
>> +    extension: ebg-swu
>> +    wic_targz: enable
>> +
>> +build:qemu-arm64-swupdate-repro-build:
>> +  extends:
>> +    - .repro-build
>> +  variables:
>> +    target: qemu-arm64
>> +    extension: ebg-swu
>> +    wic_targz: enable
>> +
>> +build:qemu-arm-swupdate-repro-build:
>> +  extends:
>> +    - .repro-build
>> +  variables:
>> +    target: qemu-arm
>> +    extension: ebg-swu
>> +    wic_targz: enable
>> +
>>  # repro build test
>>  test:qemu-amd64-base-repro-test:
>>    extends:
>> @@ -106,3 +130,28 @@ test:qemu-arm-base-repro-test:
>>      target: qemu-arm
>>    dependencies:
>>      - build:qemu-arm-base-repro-build
>> +
>> +test:qemu-amd64-swupdate-repro-test:
>> +  extends:
>> +    - .repro-test
>> +  variables:
>> +    target: qemu-amd64
>> +  dependencies:
>> +    - build:qemu-amd64-swupdate-repro-build
>> +
>> +test:qemu-arm64-swupdate-repro-test:
>> +  extends:
>> +    - .repro-test
>> +  variables:
>> +    target: qemu-arm64
>> +  dependencies:
>> +    - build:qemu-arm64-swupdate-repro-build
>> +
>> +test:qemu-arm-swupdate-repro-test:
>> +  extends:
>> +    - .repro-test
>> +  variables:
>> +    target: qemu-arm
>> +  dependencies:
>> +    - build:qemu-arm-swupdate-repro-build
>> +
>
>To keep an eye on our number of builds: Do these new targets happen to
>include aspect of existing ones and could therefore supersede them?

Yes, you rightly pointed out, the base image contents are also verified as part of the most feature rich image (e.g., 4 in below image targets)
maybe we can drop the base targets now, if no objections I will update them in v2 patch.

1. Base
2. Base + swupdate
3. Base + swupdate + secureboot
4. Base + swupdate + secureboot + security extensions.

>
>Jan
>
>--
>Siemens AG, Technology
>Competence Center Embedded Linux
diff mbox series

Patch

diff --git a/.reproducible-check-ci.yml b/.reproducible-check-ci.yml
index d8bfb40..5ea7857 100644
--- a/.reproducible-check-ci.yml
+++ b/.reproducible-check-ci.yml
@@ -82,6 +82,30 @@  build:qemu-arm-base-repro-build:
   variables:
     target: qemu-arm
 
+build:qemu-amd64-swupdate-repro-build:
+  extends:
+    - .repro-build
+  variables:
+    target: qemu-amd64
+    extension: ebg-swu
+    wic_targz: enable
+
+build:qemu-arm64-swupdate-repro-build:
+  extends:
+    - .repro-build
+  variables:
+    target: qemu-arm64
+    extension: ebg-swu
+    wic_targz: enable
+
+build:qemu-arm-swupdate-repro-build:
+  extends:
+    - .repro-build
+  variables:
+    target: qemu-arm
+    extension: ebg-swu
+    wic_targz: enable
+
 # repro build test
 test:qemu-amd64-base-repro-test:
   extends:
@@ -106,3 +130,28 @@  test:qemu-arm-base-repro-test:
     target: qemu-arm
   dependencies:
     - build:qemu-arm-base-repro-build
+
+test:qemu-amd64-swupdate-repro-test:
+  extends:
+    - .repro-test
+  variables:
+    target: qemu-amd64
+  dependencies:
+    - build:qemu-amd64-swupdate-repro-build
+
+test:qemu-arm64-swupdate-repro-test:
+  extends:
+    - .repro-test
+  variables:
+    target: qemu-arm64
+  dependencies:
+    - build:qemu-arm64-swupdate-repro-build
+
+test:qemu-arm-swupdate-repro-test:
+  extends:
+    - .repro-test
+  variables:
+    target: qemu-arm
+  dependencies:
+    - build:qemu-arm-swupdate-repro-build
+