| Message ID | cover.1687522138.git.aclaudi@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: fix mptcp_join test | expand |
Hi Andrea, On 23/06/2023 14:19, Andrea Claudi wrote: > This series fixes two mptcp_join testcases. > - '001 implicit EP' fails because of: > - missing iproute support for mptcp 'implicit' flag, fixed with > iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit > flag") > - pm_nl_check_endpoint expecting two ip addresses, while only one is > present in the iproute output; > - '002 delete and re-add' fails because the endpoint delete command > provide both id and ip address, while address should be provided only > if id is 0. > > Andrea Claudi (2): > selftests: mptcp: join: fix 'delete and re-add' test > selftests: mptcp: join: fix 'implicit EP' test Thank you for these patches! I have some comments, please see my replies on the individual patches. Do you mind sending a v2 only to MPTCP ML -- not to Netdev and its maintainers -- if you don't mind? When these patches will be ready, we will apply them in MPTCP tree and send them later to netdev. (Maybe we should modify the MAINTAINERS file to exclude Netdev maintainers and list when someone sends a patch.) Cheers, Matt
This series fixes two mptcp_join testcases. - '001 implicit EP' fails because of: - missing iproute support for mptcp 'implicit' flag, fixed with iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit flag") - pm_nl_check_endpoint expecting two ip addresses, while only one is present in the iproute output; - '002 delete and re-add' fails because the endpoint delete command provide both id and ip address, while address should be provided only if id is 0. Andrea Claudi (2): selftests: mptcp: join: fix 'delete and re-add' test selftests: mptcp: join: fix 'implicit EP' test tools/testing/selftests/net/mptcp/mptcp_join.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)