| Message ID | 20230627071707.77659-13-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [01/15] genirq/devres: Add error information printing for devm_request_threaded_irq() | expand |
On 27/06/2023 09:17, Yangtao Li wrote: > The upper-layer devm_request_threaded_irq() function can directly > print error information. I don't understand. "Can print"? It does not matter if it can, if it does not. Currently it doesn't, therefore change is not correct. Otherwise explain a bit better why this is redundant. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- Best regards, Krzysztof
On 27/06/2023 09:40, Krzysztof Kozlowski wrote: > On 27/06/2023 09:17, Yangtao Li wrote: >> The upper-layer devm_request_threaded_irq() function can directly >> print error information. > > I don't understand. "Can print"? It does not matter if it can, if it > does not. Currently it doesn't, therefore change is not correct. > Otherwise explain a bit better why this is redundant. All your patches ended up in spam, so now I found your patch one. Anyway, if this stays, please replace "can" with statement - "prints". Best regards, Krzysztof
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index 77231a9d28ff..e741f5539389 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -1582,8 +1582,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev) IRQF_ONESHOT, "rockchip_thermal", thermal); if (error) - return dev_err_probe(&pdev->dev, error, - "failed to request tsadc irq.\n"); + return error; thermal->chip->control(thermal->regs, true);
The upper-layer devm_request_threaded_irq() function can directly print error information. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/thermal/rockchip_thermal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)