| Message ID | cover.1687974498.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: aacraid: Replace one-element arrays with flexible-array members | expand |
On Wed, Jun 28, 2023 at 11:53:45AM -0600, Gustavo A. R. Silva wrote: > This series aims to replace one-element arrays with flexible-array > members in multiple structures in drivers/scsi/aacraid/aacraid.h. > > This helps with the ongoing efforts to globally enable -Warray-bounds > and get us closer to being able to tighten the FORTIFY_SOURCE routines > on memcpy(). > > These issues were found with the help of Coccinelle and audited and fixed, > manually. > > Link: https://github.com/KSPP/linux/issues/79 > > Gustavo A. R. Silva (10): > scsi: aacraid: Replace one-element array with flexible-array member > scsi: aacraid: Use struct_size() helper in aac_get_safw_ciss_luns() > scsi: aacraid: Replace one-element array with flexible-array member in > struct aac_aifcmd > scsi: aacraid: Replace one-element array with flexible-array member in > struct user_sgmapraw > scsi: aacraid: Replace one-element array with flexible-array member in > struct sgmapraw > scsi: aacraid: Use struct_size() helper in code related to struct > sgmapraw > scsi: aacraid: Replace one-element array with flexible-array member in > struct user_sgmap64 > scsi: aacraid: Replace one-element array with flexible-array member in > struct sgmap > scsi: aacraid: Replace one-element array with flexible-array member in > struct sgmap64 > scsi: aacraid: Replace one-element array with flexible-array member in > struct user_sgmap I'd like to reorganize this series so that all the conversions are first, and then struct_size() additions are at the end. That way, if desired, the conversions can land as fixes to turn the Clang builds green again.
On 6/28/23 14:08, Kees Cook wrote: > On Wed, Jun 28, 2023 at 11:53:45AM -0600, Gustavo A. R. Silva wrote: >> This series aims to replace one-element arrays with flexible-array >> members in multiple structures in drivers/scsi/aacraid/aacraid.h. >> >> This helps with the ongoing efforts to globally enable -Warray-bounds >> and get us closer to being able to tighten the FORTIFY_SOURCE routines >> on memcpy(). >> >> These issues were found with the help of Coccinelle and audited and fixed, >> manually. >> >> Link: https://github.com/KSPP/linux/issues/79 >> >> Gustavo A. R. Silva (10): >> scsi: aacraid: Replace one-element array with flexible-array member >> scsi: aacraid: Use struct_size() helper in aac_get_safw_ciss_luns() >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct aac_aifcmd >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct user_sgmapraw >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct sgmapraw >> scsi: aacraid: Use struct_size() helper in code related to struct >> sgmapraw >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct user_sgmap64 >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct sgmap >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct sgmap64 >> scsi: aacraid: Replace one-element array with flexible-array member in >> struct user_sgmap > > I'd like to reorganize this series so that all the conversions are > first, and then struct_size() additions are at the end. That way, if > desired, the conversions can land as fixes to turn the Clang builds > green again. > OK; I can make that happen. :) -- Gustavo
This series aims to replace one-element arrays with flexible-array members in multiple structures in drivers/scsi/aacraid/aacraid.h. This helps with the ongoing efforts to globally enable -Warray-bounds and get us closer to being able to tighten the FORTIFY_SOURCE routines on memcpy(). These issues were found with the help of Coccinelle and audited and fixed, manually. Link: https://github.com/KSPP/linux/issues/79 Gustavo A. R. Silva (10): scsi: aacraid: Replace one-element array with flexible-array member scsi: aacraid: Use struct_size() helper in aac_get_safw_ciss_luns() scsi: aacraid: Replace one-element array with flexible-array member in struct aac_aifcmd scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmapraw scsi: aacraid: Replace one-element array with flexible-array member in struct sgmapraw scsi: aacraid: Use struct_size() helper in code related to struct sgmapraw scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmap64 scsi: aacraid: Replace one-element array with flexible-array member in struct sgmap scsi: aacraid: Replace one-element array with flexible-array member in struct sgmap64 scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmap drivers/scsi/aacraid/aachba.c | 42 +++++++++++++-------------------- drivers/scsi/aacraid/aacraid.h | 16 ++++++------- drivers/scsi/aacraid/commctrl.c | 6 ++--- drivers/scsi/aacraid/comminit.c | 3 +-- 4 files changed, 28 insertions(+), 39 deletions(-)